Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 10 Jun 2022 14:36:11 +0300
From:   Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To:     Dinh Nguyen <dinguyen@kernel.org>
Cc:     jarkko.nikula@linux.intel.com, mika.westerberg@linux.intel.com,
        robh+dt@kernel.org, krzk+dt@kernel.org, linux-i2c@vger.kernel.org,
        linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCHv2 1/2] i2c: designware: introduce a custom scl recovery
 for SoCFPGA platforms
Message-ID: <YqMsqwLgbI4AuzrE@smile.fi.intel.com>
References: <20220524135441.420600-1-dinguyen@kernel.org>
 <Yo0LKQchQwitJVHm@smile.fi.intel.com>
 <29521c9c-90d3-03b9-cf6f-8519efcd007e@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <29521c9c-90d3-03b9-cf6f-8519efcd007e@kernel.org>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
Precedence: bulk

On Wed, Jun 01, 2022 at 08:48:07AM -0500, Dinh Nguyen wrote:
> On 5/24/22 11:43, Andy Shevchenko wrote:
> > On Tue, May 24, 2022 at 08:54:40AM -0500, Dinh Nguyen wrote:

...

> > > +	switch (dev->flags & MODEL_MASK) {
> > > +	case MODEL_SOCFPGA:
> > > +		rinfo->recover_bus = i2c_socfpga_scl_recovery;
> > > +		break;
> > > +	default:
> > > +		rinfo->recover_bus = i2c_generic_scl_recovery;
> > > +		break;
> > > +	}
> > 
> > > +	adap->bus_recovery_info = rinfo;
> > 
> > Usually we do not assign the pointer while data structure is incomplete.
> > That's said, please leave this line as it was.
> > 
> > On top of that, why you can't move the above switch to the place where old
> > function was assigned?
> 
> The reason is the assignment of the recover_bus needs to get done before the
> call to devm_gpiod_get_optional(), otherwise, the assignment is not taking
> place because of an error after returning from devm_gpiod_get_optional().

Update commit message accordingly then.

Also consider moving GPIO request part in the code, maybe it will bring better
looking / grouped code. Try and see, then choose the best one.

-- 
With Best Regards,
Andy Shevchenko