Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 10 Jun 2022 12:19:50 +0100
From:   Mark Brown <broonie@kernel.org>
To:     Catalin Marinas <catalin.marinas@arm.com>
Cc:     Alejandro Tafalla <atafalla@dnyon.com>,
        Will Deacon <will@kernel.org>,
        ~postmarketos/upstreaming@lists.sr.ht,
        Mark Rutland <mark.rutland@arm.com>,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64/sysreg: Fix typo in Enum element regex
Message-ID: <YqMo1gGVgWQDBQjJ@sirena.org.uk>
References: <20220609204220.12112-1-atafalla@dnyon.com>
 <YqMLmMJ7v48me/5H@arm.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="Jxd/oy2jPK+b7V+i"
Content-Disposition: inline
In-Reply-To: <YqMLmMJ7v48me/5H@arm.com>
Precedence: bulk


--Jxd/oy2jPK+b7V+i
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Fri, Jun 10, 2022 at 10:15:04AM +0100, Catalin Marinas wrote:
> On Thu, Jun 09, 2022 at 10:42:18PM +0200, Alejandro Tafalla wrote:

> > In the awk script, there was a typo with the comparison operator when
> > checking if the matched pattern is inside an Enum block.
> > This prevented the generation of the whole sysreg-defs.h header.

> > -/0b[01]+/ && block = "Enum" {
> > +/0b[01]+/ && block == "Enum" {

> This makes sense but I'm surprised that we haven't noticed it until now
> (maybe some awk versions treat it as a relational operator).

What Catlain said - if we weren't generating the full header contents
I'd expect things to fail to build normally, but it's entirely possible
this is just happening to work with some implementations and the patch
is clearly correct.

Reviewed-by: Mark Brown <broonie@kernel.org>

--Jxd/oy2jPK+b7V+i
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmKjKNUACgkQJNaLcl1U
h9AMIwf/eYpMYBHkr5v/mGTOxTIeRcCffY2jzjF8cFtIr8SYwAdSdYWaO609ZPgd
Dhi5lfCuq62uNTzyvimDMB7ZjuP9Y+s4fInm891igADTUS1p7L1IG8g1zjTWlmKc
Kr4mlLjHqahktGMvYevAYy3BJ8VHtF5IMfoot6r/SRfIpzsoIhb2oWG84DbT4axH
wsSnXGHuEz/UCV/q0GAhmY/iRByKwp4GlwG8sayByWLgxo50hu3B/B0pnmNgylBA
8Tdr4log1c9V2J9VwAFiXScdZn2HjveYl2JTPGg3lZiHBh16jobf1g8rqZim7dAa
HXmskkiEefM4JADNZowdp3nAqSv1mw==
=vlBZ
-----END PGP SIGNATURE-----

--Jxd/oy2jPK+b7V+i--