Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <0e451780-31c8-b1e9-0205-b9e68a57e958@kernel.org>
Date:   Fri, 10 Jun 2022 21:05:57 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.10.0
Subject: Re: [PATCH] docs: filesystems: f2fs: fix description about compress
 ioctl
Content-Language: en-US
To:     Chao Liu <chaoliu719@gmail.com>, Jaegeuk Kim <jaegeuk@kernel.org>,
        Jonathan Corbet <corbet@lwn.net>
Cc:     linux-f2fs-devel@lists.sourceforge.net, linux-doc@vger.kernel.org,
        linux-kernel@vger.kernel.org, Yue Hu <huyue2@coolpad.com>,
        Wayne Zhang <zhangwen@coolpad.com>,
        Chao Liu <liuchao@coolpad.com>
References: <20220602072540.998638-1-chaoliu719@gmail.com>
From:   Chao Yu <chao@kernel.org>
In-Reply-To: <20220602072540.998638-1-chaoliu719@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 2022/6/2 15:25, Chao Liu wrote:
> From: Chao Liu <liuchao@coolpad.com>
> 
> Since commit c61404153eb6 ("f2fs: introduce FI_COMPRESS_RELEASED
> instead of using IMMUTABLE bit"), we no longer use the IMMUTABLE
> bit to prevent writing data for compression. Let's correct the
> corresponding documentation.
> 
> BTW, this patch fixes some alignment issues in the compress
> metadata layout.
> 
> Signed-off-by: Chao Liu <liuchao@coolpad.com>
> ---
>   Documentation/filesystems/f2fs.rst | 13 +++++++------
>   1 file changed, 7 insertions(+), 6 deletions(-)
> 
> diff --git a/Documentation/filesystems/f2fs.rst b/Documentation/filesystems/f2fs.rst
> index ad8dc8c040a2..98dc24f5c6f0 100644
> --- a/Documentation/filesystems/f2fs.rst
> +++ b/Documentation/filesystems/f2fs.rst
> @@ -818,10 +818,11 @@ Compression implementation
>     Instead, the main goal is to reduce data writes to flash disk as much as
>     possible, resulting in extending disk life time as well as relaxing IO
>     congestion. Alternatively, we've added ioctl(F2FS_IOC_RELEASE_COMPRESS_BLOCKS)
> -  interface to reclaim compressed space and show it to user after putting the
> -  immutable bit. Immutable bit, after release, it doesn't allow writing/mmaping
> -  on the file, until reserving compressed space via
> -  ioctl(F2FS_IOC_RESERVE_COMPRESS_BLOCKS) or truncating filesize to zero.
> +  interface to reclaim compressed space and show it to user after setting a
> +  special flag to the inode. Once the compressed space is released, the flag
> +  will block writing data to the file until either the compressed space is
> +  reserved via ioctl(F2FS_IOC_RESERVE_COMPRESS_BLOCKS) or the file size is

s/file size/filesize/

Reviewed-by: Chao Yu <chao@kernel.org>

Thanks,

> +  truncated to zero.
>   
>   Compress metadata layout::
>   
> @@ -830,12 +831,12 @@ Compress metadata layout::
>   		| cluster 1 | cluster 2 | ......... | cluster N |
>   		+-----------------------------------------------+
>   		.           .                       .           .
> -	.                       .                .                      .
> +	  .                      .                .                      .
>       .         Compressed Cluster       .        .        Normal Cluster            .
>       +----------+---------+---------+---------+  +---------+---------+---------+---------+
>       |compr flag| block 1 | block 2 | block 3 |  | block 1 | block 2 | block 3 | block 4 |
>       +----------+---------+---------+---------+  +---------+---------+---------+---------+
> -	    .                             .
> +	       .                             .
>   	    .                                           .
>   	.                                                           .
>   	+-------------+-------------+----------+----------------------------+