Received: by 2002:a5d:925a:0:0:0:0:0 with SMTP id e26csp1395171iol; Fri, 10 Jun 2022 06:43:48 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzejLSxE1II86bI+qcBIPYSagAIAEYVW6Gz1OAbDHCippXf3jB/0EtFT3V6HSkkfOC8kBjQ X-Received: by 2002:a17:906:6485:b0:712:10cd:e3b7 with SMTP id e5-20020a170906648500b0071210cde3b7mr6047455ejm.557.1654868628050; Fri, 10 Jun 2022 06:43:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1654868628; cv=none; d=google.com; s=arc-20160816; b=byWMy1l5CQ4wRdSSKqgntNkVmhT6n3lqXjUUA2M5eOkDc87/cti/Ua+rUQLg3xcOQV DnSxXKP+7q5d66H2yxZaB+Ec3pSAjMH7anrmx1Sx8eMOR7dayo8XHDNhApk3g/slO+2S FVZf035OxgPg2HTVaOUu+xwwPDrz5ewFIik1zxENwUys+Dezb6658qKIf2R6ikaYvZkX Ux2uleA7f8u2e7z+IOpKRy0EwmZBFFIdaNfn07zKK71Z0aEiQqG9GLNEIvQ/fLFeue6F G/aAW5hgIhjwd237MgUCfsRXmiKzKj0ZGWAqKD5pW/Vg1YxpncivJzxvQ5Bso1JIJDqT QsRw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=tnaTqzvgjCCKT9OFZJnGyhQMwJzXlNsbInuW1ZmJipM=; b=Xe5YaZ8zrpLAgfg9AKIPDH9DyRn7uDUYG5HYrU23rr/MEp4NtAg8WlVgcvhrRx6rtI +OhiZCeiXauAEp2qUGiufkZabcxNfblNsCl6ObxEKiRjuENYulmz1S6GdYcX2IcKUIsb P3Ds0gjl9wh9ElXIBFSoqa3WVaWDs938YHq0XIcaoQ3m+M/ZGj/vmMB0lHdKmh6wgCtG w6O6Ab5DafS8rR1xwruk8o8ag9uwMDuR+EW7theoHbOB7FEd8d542vAoPtFAQie+FZmS wfPQnSC8GDCAQLzBb0l2yv0/rZwXE5i0Hvk0s9ugzgb6FnjuGxfxd4lizJDZCELCiUtA Xe4w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ecATqeS8; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id eb13-20020a0564020d0d00b0042dd2daa71asi29515178edb.595.2022.06.10.06.43.21; Fri, 10 Jun 2022 06:43:48 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ecATqeS8; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345590AbiFJM42 (ORCPT + 99 others); Fri, 10 Jun 2022 08:56:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38808 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236365AbiFJM41 (ORCPT ); Fri, 10 Jun 2022 08:56:27 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5345FD770E for ; Fri, 10 Jun 2022 05:56:25 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id E370C612CE for ; Fri, 10 Jun 2022 12:56:24 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8F831C34114; Fri, 10 Jun 2022 12:56:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1654865784; bh=iRFjxovy5CkuRcx0ELJUlqBRymqdTN/K1av4ME90rVk=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=ecATqeS8mHeey0vP4Cx4xZFO7etlCt711IK81DDRdNIOFj3WPV/yXlfB9/0StOZJU e4AFiYQKmYLVSW9KY5uux8J1lcexZ3KN8fM75sy6Z2RytfdFvgfH6+qvVEvWph2QDw 21zKbBDVMwN5NF+WJuWC/oDMGFYbu2Ebzgz/niE89uhqXdSZoIImtijQpjg1fFED7p 6JcjWbwEeYu0z+I8d3h0jY2fC1c/GWHW7RHUyE0EuPQuA4Y0b0zDRdNgN0mZ6j6Cxj UIdYpeJERKLzOytErKXaVRgQ774cPO6iFk2P70THuHRsy4xAAZCG0J5DI7AOJRySqV 35JLcAwUy5A7w== Message-ID: Date: Fri, 10 Jun 2022 20:56:21 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH] f2fs: refine comments for inline flags Content-Language: en-US To: Chao Liu , Jaegeuk Kim Cc: linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, Yue Hu , Wayne Zhang , Chao Liu References: <20220602072449.998303-1-chaoliu719@gmail.com> From: Chao Yu In-Reply-To: <20220602072449.998303-1-chaoliu719@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-9.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A, RCVD_IN_DNSWL_HI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2022/6/2 15:24, Chao Liu wrote: > From: Chao Liu > > Currently, we use f2fs_has_inline_xattr() to check whether the > inode can store inline xattr. However, it might be misinterpreted > as the inode has at least one inline xattr. > > The same is true for f2fs_has_inline_data() and > f2fs_has_inline_dentry(). To be more intuitive and specific, > refine comments of inline flags. > > Signed-off-by: Chao Liu Reviewed-by: Chao Yu Thanks,