Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 10 Jun 2022 16:20:17 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Nicolas Dufresne <nicolas.dufresne@collabora.com>
Cc:     linux-media@vger.kernel.org,
        Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>,
        Mauro Carvalho Chehab <mchehab@kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        kernel@collabora.com, linux-rockchip@lists.infradead.org,
        linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 4/5] media: rkvdec: Re-enable H.264 error detection
Message-ID: <20220610132017.GD2146@kadam>
References: <20220610125215.240539-1-nicolas.dufresne@collabora.com>
 <20220610125215.240539-5-nicolas.dufresne@collabora.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220610125215.240539-5-nicolas.dufresne@collabora.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?V9EGMGY2Nko+bi8nh6OljxZY6B3UhOPuV4fCi7vCI8iBeY9T8sNFcwFtl2nd?=
 =?us-ascii?Q?flId9KL4vHjXOYx2dsHLqbpgmDgBmsfbLWHLGV3IK4VtSpxaRaa11vn7MHXj?=
 =?us-ascii?Q?LDaXAsmaCJ110e7A5aFDfqVt+Y32EEZSfTtj7oCX/vAPgaYts0+jUOPnza5T?=
 =?us-ascii?Q?dI8B6/eOwRFb1X8zpry0jJ2+WjHLoyTzU3K654Xj7Cb1W/jQdbNvw8ALOGTW?=
 =?us-ascii?Q?3qkcYCNoRs1zvq8jprQVQzlCRJxBoyxUl9Y337ynQygy5dEgoXp+mqIM0+5C?=
 =?us-ascii?Q?v7nSAUquGZlSD3NWA4ShR/pfdioKkbvVUqPeKLXvdZXldAd5OHYWnigaCWUi?=
 =?us-ascii?Q?/mvwc/XM+aLnEOxrUVccS5GHruxi2TOTskYnr8KM/L9JVtnv+mUxeMiJyE4O?=
 =?us-ascii?Q?z7wRpbk1eYovGNmHtr9GjnGyYKf5zi/OqpKj4JRzkbGD/oHuQt00WhWr33Pz?=
 =?us-ascii?Q?ho9YybmL09cBSnECgrkz190E1JJpVWhoxcMOAD16tBAtjFX5wrJsccN6VOBb?=
 =?us-ascii?Q?lMbZlWtvz8VEeA46VHSew5d6o19V4bhvblOZ6O5E6ZIr91v8CvcGkGc25/XA?=
 =?us-ascii?Q?qM4soVcENlAlGhTydFle6UwoNaX8FbxF6qVDzTGO+U+2wIYkzlP1/RHFFh37?=
 =?us-ascii?Q?rB6MYB46ClBMks/GBYVqcPr0lZYEFq4Iz1sjhrLKnbKa8rS3r/NDuBKGlnlW?=
 =?us-ascii?Q?QQs7HWtsjBiY8gX5GOY4g3AhO7c/b6h0whFNzEzpH2yYP/2uCBJyBQxKW8OD?=
 =?us-ascii?Q?dwATein2nEh1EySU0QXOquYhyNAelMhzTAN155CIvj0shM+l1Z4WsNQD1R8g?=
 =?us-ascii?Q?FbKEQwYBUEMuVE3rjH7xJe7P0JuPE2aZNnDx1mvh/aROutAtuCPIdDTrpmH0?=
 =?us-ascii?Q?VvcfUgqCM11KgMLVB/zv2V8+7wBhIPCL/Z1ONMiw/A0nqPlyDXwYne6sZEeg?=
 =?us-ascii?Q?EO4nY8bIxnkCuCwTEpHNdY41OwrDzbI2kqpLYKbgsDm/aOgX3ttW1yrhSdoN?=
 =?us-ascii?Q?aO0GKNtCeG7k7qf/H4YMbSFpWhAM7x+hLkqyOmPHkGtnMGvrnTEjmbrw18J2?=
 =?us-ascii?Q?1MxCeRAgfjNpEXFLiOYelTUkqFzkjloBu2gxRS43p6WhitzC835TNdKy0Cvx?=
 =?us-ascii?Q?CEeXpjre7H42zYUNFGaNDH56A28j1Wm9ufjxpPO6xBcJ/cYw0fRhyPivzwtj?=
 =?us-ascii?Q?goBPa5t99xDt7W5pcFdVPN18NioS8yY6ZlG2clRHnJ6EO0vRB41O4wB0XWSW?=
 =?us-ascii?Q?pjKdapQYLngZXdFNDg9D79kTOediWHACsYs95kZPP4ebXMQn2TsZu73qa79v?=
 =?us-ascii?Q?T8P3SMiJv73Fq+YG0GxqhHFsBIeQA4Rb2prYsVNLFXHh+SiGmEplM827LSii?=
 =?us-ascii?Q?SiNU3fLc3frjMXxZBZ+CkfTlEkO3JBi0azBNDUTEgDNlRfEC1FgXhb6AM1z3?=
 =?us-ascii?Q?VjidiAqCYek13l4fv2eL7XorrnIW4sbYICJBuo43FhmtKkC66pvXN1M3qy7Y?=
 =?us-ascii?Q?mvt1Kzn9VVjz2t+EIoTZcNyeRvwn9CZlBz2U0NgP+hseKnjLPo56k6CJJzzP?=
 =?us-ascii?Q?jwNAwmCtB8JJ+6fIrptSR5dXmveohCAHUxWRCmf9ytkAvlmjXOCUgznBHuI0?=
 =?us-ascii?Q?VKQRsO6BAvt1TKY7Lhh+dEN8IM4Ck/ec7Xo8lVz6z2BGzqWGSFqh82tvXVw9?=
 =?us-ascii?Q?RYFSZgR9VkqkHZ0WWZIF6/xPq0YLRJfW/fOidB8gPGxFQDK7iJtOn2kmdN9T?=
 =?us-ascii?Q?Qm9DbqtBuNdGzCvF0uu2OG5YTdPOvP4=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ae728dc4-3539-4c0d-3834-08da4ae3fc7a
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jun 2022 13:20:28.7433
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Mu+pz4Rxx1lXKDE4DNYlFhGv/0b0RX+AW4w+6MAxjE9NqdZKhguGnwtTIowAariu7SR4IUBDRgXK5LdtA9a4suJv++e2KZEtlBEeteifWtQ=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM8PR10MB5479
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.517,18.0.874
 definitions=2022-06-10_06:2022-06-09,2022-06-10 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 bulkscore=0
 malwarescore=0 mlxlogscore=999 adultscore=0 mlxscore=0 phishscore=0
 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2204290000 definitions=main-2206100054
X-Proofpoint-ORIG-GUID: Q2mGQDqnv_rXBSsGusKgbH6Zduhr4qNt
X-Proofpoint-GUID: Q2mGQDqnv_rXBSsGusKgbH6Zduhr4qNt
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Jun 10, 2022 at 08:52:14AM -0400, Nicolas Dufresne wrote:
> This re-enables H.264 error detection, but using the other error mode.
> In that mode, the decoder will skip over the error macro-block or
> slices and complete the decoding. As a side effect, the error status
> is not set in the interrupt status register, and instead errors are
> detected per format. Using this mode workaround the issue that the
> HW get stuck in error stated and allow reporting that some corruption
> may be present in the buffer returned to userland.
> 
> Signed-off-by: Nicolas Dufresne <nicolas.dufresne@collabora.com>
> ---
>  drivers/staging/media/rkvdec/rkvdec-h264.c | 23 +++++++++++++++++++---
>  1 file changed, 20 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/media/rkvdec/rkvdec-h264.c b/drivers/staging/media/rkvdec/rkvdec-h264.c
> index 55596ce6bb6e..60a89918e2c1 100644
> --- a/drivers/staging/media/rkvdec/rkvdec-h264.c
> +++ b/drivers/staging/media/rkvdec/rkvdec-h264.c
> @@ -1175,14 +1175,15 @@ static int rkvdec_h264_run(struct rkvdec_ctx *ctx)
>  
>  	schedule_delayed_work(&rkvdec->watchdog_work, msecs_to_jiffies(2000));
>  
> -	writel(0, rkvdec->regs + RKVDEC_REG_STRMD_ERR_EN);
> -	writel(0, rkvdec->regs + RKVDEC_REG_H264_ERR_E);
> +	writel(0xffffffff, rkvdec->regs + RKVDEC_REG_STRMD_ERR_EN);
> +	writel(0xffffffff, rkvdec->regs + RKVDEC_REG_H264_ERR_E);

This reverts the changes in patch 1/5.  Could we just skip patch 1/5
instead?

regards,
dan carpenter