Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 10 Jun 2022 14:33:11 +0000
From:   Sean Christopherson <seanjc@google.com>
To:     Andrew Jones <drjones@redhat.com>
Cc:     Paolo Bonzini <pbonzini@redhat.com>, kvm@vger.kernel.org,
        Vitaly Kuznetsov <vkuznets@redhat.com>,
        David Matlack <dmatlack@google.com>,
        Ben Gardon <bgardon@google.com>,
        Oliver Upton <oupton@google.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 126/144] KVM: selftests: Convert kvm_binary_stats_test
 away from vCPU IDs
Message-ID: <YqNWJwlGWleTw7sR@google.com>
References: <20220603004331.1523888-1-seanjc@google.com>
 <20220603004331.1523888-127-seanjc@google.com>
 <20220610104851.g2r6yzd6j22xod6m@gator>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220610104851.g2r6yzd6j22xod6m@gator>
Precedence: bulk

On Fri, Jun 10, 2022, Andrew Jones wrote:
> On Fri, Jun 03, 2022 at 12:43:13AM +0000, Sean Christopherson wrote:
> > @@ -220,17 +221,21 @@ int main(int argc, char *argv[])
> >  	/* Create VMs and VCPUs */
> >  	vms = malloc(sizeof(vms[0]) * max_vm);
> >  	TEST_ASSERT(vms, "Allocate memory for storing VM pointers");
> > +
> > +	vcpus = malloc(sizeof(struct kvm_vcpu *) * max_vm * max_vcpu);
> > +	TEST_ASSERT(vcpus, "Allocate memory for storing vCPU pointers");
> > +
> >  	for (i = 0; i < max_vm; ++i) {
> >  		vms[i] = vm_create_barebones();
> >  		for (j = 0; j < max_vcpu; ++j)
> > -			__vm_vcpu_add(vms[i], j);
> > +			vcpus[j * max_vcpu + i] = __vm_vcpu_add(vms[i], j);
> 
> The expression for the index should be 'i * max_vcpu + j'. The swapped
> i,j usage isn't causing problems now because
> DEFAULT_NUM_VM == DEFAULT_NUM_VCPU, but that could change.

It's better to be lucky than good?

Thanks much, I appreciate the reviews!