Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <fad9b50609f9d9828ea14772dbd4d195713f1c4b.1654846687.git.lukas@wunner.de>
In-Reply-To: <fad9b50609f9d9828ea14772dbd4d195713f1c4b.1654846687.git.lukas@wunner.de>
From:   "Rafael J. Wysocki" <rafael@kernel.org>
Date:   Fri, 10 Jun 2022 15:33:54 +0200
Message-ID: <CAJZ5v0jBVyxegaETv5D25N+LNZWRUsJeVcx-p8cGXYod8=smWQ@mail.gmail.com>
Subject: Re: [PATCH] genirq/PM: Unexport {suspend,resume}_device_irqs()
To:     Lukas Wunner <lukas@wunner.de>
Cc:     Thomas Gleixner <tglx@linutronix.de>,
        "Rafael J. Wysocki" <rafael@kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Linux PM <linux-pm@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Fri, Jun 10, 2022 at 9:41 AM Lukas Wunner <lukas@wunner.de> wrote:
>
> Ever since {suspend,resume}_device_irqs() were introduced in 2009
> by commit 0a0c5168df27 ("PM: Introduce functions for suspending and
> resuming device interrupts"), they've been exported even though there
> are no module users and never will be:  The functions are solely called
> by the PM core, which is always built-in.  Unexport them.
>
> Signed-off-by: Lukas Wunner <lukas@wunner.de>

Reviewed-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>

or I can take it if no one else does.

> ---
>  kernel/irq/pm.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/kernel/irq/pm.c b/kernel/irq/pm.c
> index ca71123a6130..c556bc49d213 100644
> --- a/kernel/irq/pm.c
> +++ b/kernel/irq/pm.c
> @@ -147,7 +147,6 @@ void suspend_device_irqs(void)
>                         synchronize_irq(irq);
>         }
>  }
> -EXPORT_SYMBOL_GPL(suspend_device_irqs);
>
>  static void resume_irq(struct irq_desc *desc)
>  {
> @@ -259,4 +258,3 @@ void resume_device_irqs(void)
>  {
>         resume_irqs(false);
>  }
> -EXPORT_SYMBOL_GPL(resume_device_irqs);
> --
> 2.35.2
>