Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 10 Jun 2022 16:49:36 +0000
From:   Yazen Ghannam <yazen.ghannam@amd.com>
To:     Mario Limonciello <mario.limonciello@amd.com>
Cc:     Clemens Ladisch <clemens@ladisch.de>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        "maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)" <x86@kernel.org>,
        "H. Peter Anvin" <hpa@zytor.com>,
        Bjorn Helgaas <bhelgaas@google.com>,
        Guenter Roeck <linux@roeck-us.net>,
        Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= <kw@linux.com>,
        "open list:X86 ARCHITECTURE (32-BIT AND 64-BIT)" 
        <linux-kernel@vger.kernel.org>,
        "open list:PCI SUBSYSTEM" <linux-pci@vger.kernel.org>,
        linux-hwmon@vger.kernel.org, babu.moger@amd.com
Subject: Re: [PATCH v2 3/6] x86/amd_nb: Add Family 19h model 60h-6Fh IDs
Message-ID: <YqN2IMRbmn3s8ly3@yaz-fattaah>
References: <20220602201137.1415-1-mario.limonciello@amd.com>
 <20220602201137.1415-4-mario.limonciello@amd.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220602201137.1415-4-mario.limonciello@amd.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?ZNFdCJ6g1c8COHh00BzvxQpIWA3HepUJxQlp9slQKxsKjxb7EqlzFaYQPEdr?=
 =?us-ascii?Q?q0kJXqSpw5mVLSAd9jqRc+ZFDgvxTC+gGO3djIvdySEiBAhxXKG2pK0cB3YV?=
 =?us-ascii?Q?zrrLVso3aS1dv3NMdRE06Ala2dsfr4lYIHYNPTIBVSyzlxvsM0/s/1rcUdEX?=
 =?us-ascii?Q?AsvWPSLhBFsbGdetbt5oT0IPgwlG0x0YGcwETHx63fyDiiGS2dzdNHJIbRoS?=
 =?us-ascii?Q?hyJTtG5m2D/1TE7ERLHRZRA9Khb5tM8NxBqgCNT48Z7MZzj9GrB2lllPuq+J?=
 =?us-ascii?Q?sHCEX1Tt6sOBcyN4Tx/WdSLMO/tWwYXSb/iDCopyqbzML1iFVv7QQMP6xSZk?=
 =?us-ascii?Q?zksLy/qODByHiKpZrk2k0SMj6EUn8WZmWI5Vp602qNO78HKPcVA+LrBND8zS?=
 =?us-ascii?Q?x1LIE7tQy/+fndllRn/pc7h1KWmMJS3NKAM2FiM6C9Kk+CbS63uE0QF4E4Yx?=
 =?us-ascii?Q?Gnr7VtyanOjHuQedLMTEBka/G8hcJ0M4iSCG9Re4H5/v98WlD2U9fx8x3DR4?=
 =?us-ascii?Q?lyDcCTKlBw2RSstTVWJGL8vZAU/iUb3D25dyXjFAC+KKxPgyWi8pqMttzHu3?=
 =?us-ascii?Q?/Cv8oeMTWm4o1eZlru0jarflN/WuJaQgoQgHPenaB4vZi1A37edSzcwjB0TE?=
 =?us-ascii?Q?gQyQwgRToxoraIo/kxX20b17iPlQgkCJxwwHSGiBwpqGkA+ht7ld8ZLYjw8B?=
 =?us-ascii?Q?oQOUH68IkaHQGHygFrf2hDHDs0O/a1wROVsJPC/LBTAu3eKcXUJV5CyPhqzy?=
 =?us-ascii?Q?R5DkR+mHSwPiMroNE6xhhdG+/airWRtzbNB2Z1Bpy+3uZPUsRQkiqRtWCoyi?=
 =?us-ascii?Q?HiG1grGKwXQhJxzzWN+joqcNdLk72a4vwuTfEfOMpMW6ismQ4UtYQHBXobA8?=
 =?us-ascii?Q?4DLRKvheLmTJEWhXj7gxuAoya5E3vDrg/LYfurFJXshPNvppwpXdUanh9Y/D?=
 =?us-ascii?Q?Ud/lv4GqQI0CgLNyb0UVNGkj0IpvPSYqca//JN74d/ZzuOmoyEeBxZyp6RuG?=
 =?us-ascii?Q?i+A2Oo3OAbCOENz0dYKDGvYnDhH2RL8NjpL8ePIAi9O0bXSfTZPuWYfg3SYM?=
 =?us-ascii?Q?yX79Ps5coB1POGAtU7hzbZLsoL0WXJqT1CrTTXxn2o+t+3PKTUbFdE++DgDD?=
 =?us-ascii?Q?zSeN/Gi8r061otuEcScpQlRSal87ycphdCUL8nvUBfZCWZGrsrMFjqm8m8Ui?=
 =?us-ascii?Q?ASkXBGEQujsRyzSk5tuUupS8rvO/1UvaTkmRCenR7Q51zoNs8wweAfwBXS6P?=
 =?us-ascii?Q?6/VMVnQmY+gATo0wusTOPe9aIJEqmxNx6ABYilXK0PUu0iR+WOHx9TpKPVgY?=
 =?us-ascii?Q?KQ52BJgKxCqSDoak64j1r8Apt7rKWHf8lPbNKx3ECJnQ7DA1rs8KfhLs9N/m?=
 =?us-ascii?Q?oLd1p5dkB2xgSWubnmb+XH6AQmtO7mfgbcUNS5mQJ76ilgA1Sgm2grDRVKhP?=
 =?us-ascii?Q?l4/VKKynUjW2ASupCFT1poNcROyGokkDbaP5WjcIxwHuvJM7neKRpcy9x69o?=
 =?us-ascii?Q?Vg6xdWFniaUf3Utfcz2/YLQgTjKkgDQCEjr1ccUvl7gRP5EXwohRvhWls2yU?=
 =?us-ascii?Q?cS8z8h7jBgKrdgBvw5JoIo87CNrjU8DQ8ZuPznKR50fBOG6JCz9JM/gJnQf9?=
 =?us-ascii?Q?WpV9Tt0xBTP/WbTOrEB7p/aMitCoss45T08beHWn5vBUGyqnKAQXFUDJ2uAD?=
 =?us-ascii?Q?U05vAC45N0cAXpYiMoadBZQTULprtooGAY5n//glnbhBhR+TKzzXS8Kmrf6V?=
 =?us-ascii?Q?3c589KBmJA=3D=3D?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8f9efb4c-4692-4724-c59b-08da4b0136b4
X-MS-Exchange-CrossTenant-AuthSource: BN8PR12MB3108.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jun 2022 16:49:41.3088
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 5f6Mbp5PqufB5pR2//tipSjGWYSitRLC0EUbL7OBmcURFzP5y41P06VdfW1tb63f0U9lNv3tbSeuUg3ER7R2OQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR12MB1684
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Jun 02, 2022 at 03:11:34PM -0500, Mario Limonciello wrote:
> Add support for SMN communication on Family 19h Model 60h.
> 
> Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
> ---
>  arch/x86/kernel/amd_nb.c | 4 ++++
>  include/linux/pci_ids.h  | 1 +
>  2 files changed, 5 insertions(+)
> 
> diff --git a/arch/x86/kernel/amd_nb.c b/arch/x86/kernel/amd_nb.c
> index 15295f5d9aca..491669c24ffd 100644
> --- a/arch/x86/kernel/amd_nb.c
> +++ b/arch/x86/kernel/amd_nb.c
> @@ -32,6 +32,8 @@
>  #define PCI_DEVICE_ID_AMD_19H_M40H_ROOT	0x14b5
>  #define PCI_DEVICE_ID_AMD_19H_M40H_DF_F4 0x167d
>  #define PCI_DEVICE_ID_AMD_19H_M50H_DF_F4 0x166e
> +#define PCI_DEVICE_ID_AMD_19H_M60H_ROOT	0x14d8
> +#define PCI_DEVICE_ID_AMD_19H_M60H_DF_F4 0x14e4
>  #define PCI_DEVICE_ID_AMD_19H_M70H_ROOT	0x14e8
>  #define PCI_DEVICE_ID_AMD_19H_M70H_DF_F4 0x14f4
>

Same here about grouping "ROOT" IDs. Otherwise, looks good.

Reviewed-by: Yazen Ghannam <yazen.ghannam@amd.com>

Thanks,
Yazen