Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 10 Jun 2022 16:46:02 +0000
From:   Yazen Ghannam <yazen.ghannam@amd.com>
To:     Mario Limonciello <mario.limonciello@amd.com>
Cc:     Clemens Ladisch <clemens@ladisch.de>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        "maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)" <x86@kernel.org>,
        "H. Peter Anvin" <hpa@zytor.com>,
        Bjorn Helgaas <bhelgaas@google.com>,
        Guenter Roeck <linux@roeck-us.net>,
        Babu Moger <babu.moger@amd.com>,
        "open list:X86 ARCHITECTURE (32-BIT AND 64-BIT)" 
        <linux-kernel@vger.kernel.org>,
        "open list:PCI SUBSYSTEM" <linux-pci@vger.kernel.org>,
        linux-hwmon@vger.kernel.org
Subject: Re: [PATCH v2 2/6] x86/amd_nb: Add Family 19h model 70h-7Fh IDs
Message-ID: <YqN1Skf2eBr093IZ@yaz-fattaah>
References: <20220602201137.1415-1-mario.limonciello@amd.com>
 <20220602201137.1415-3-mario.limonciello@amd.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220602201137.1415-3-mario.limonciello@amd.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?lo/dwV9o5DsPJ0EFlF3GjsSxdgeHquOerhIGQtIG9fhSwk/dDHLEVaEBvqQW?=
 =?us-ascii?Q?M4mW2mG96T3mNhzIO/yD70Z1eyqTWHJoZZq9Enhmbt4Wha/e0w/wrAm78NyB?=
 =?us-ascii?Q?e4A8DDUv1sRBADi6kJh873DH6lJesPTlNTpXOa1uGYJcgUS94jCZCBBX69tG?=
 =?us-ascii?Q?+tbPGLjVhFoElZmsBcQAKC8EEb6Mt2mpkJ5R4w9RAXl7h8dArvU7VCvMMHsR?=
 =?us-ascii?Q?9laDvz7fVC8tfiNpIHSAhow7yVEB1qyRwLb+ADQkftetOVEa6kK8l2pEzA4D?=
 =?us-ascii?Q?CAQTEDT4tuWNsRz7QCap9Xeyxp6CONprRvfL7ESi/n3morXa/GGVSr6altdX?=
 =?us-ascii?Q?U6r5KKh8/yw91e+vRWBQLAnkoUnzBvUiZkIfrrM8Ch96R0jMFVylW2nC46Ib?=
 =?us-ascii?Q?PbuR6iPsz8oJB6dMp/MrN+MHOTQRJSlWmCokI9X1tksfDqEJ4hUeS4U5vbp8?=
 =?us-ascii?Q?sTak7RmfmNZgXf0QN5iXvJYJRkHP0UCUVgDYGkYZOxiECBeKw7Q1vtScJcIy?=
 =?us-ascii?Q?E3p4cl7r4QPhpqQbL+lm6qvhTBvYRRP0ZGVNGRtqJpxpSGZA7ZHqLlpSrJnO?=
 =?us-ascii?Q?fkA4U09ZkYQFTSoq64bZEco8dVEtSzZp4v3K4MIZuMBc1ltSwMMOCtuB+s02?=
 =?us-ascii?Q?suX2eEhoL6saYfiMuoOYTRPGiz8Ov1FxD5za/MFUJZPJw/sRmpbJc46EKwdQ?=
 =?us-ascii?Q?PcMV8orezBWqoZRaooK03ws3iFE1rcVARsMR5IFuELnNmqpH9xK+bEcz63x4?=
 =?us-ascii?Q?ST85HS94kAvazHQvNkHKeCQVFAfqpOSRJfFFCCAS/nIuQGpXWFhYoqVHc4S3?=
 =?us-ascii?Q?oVHQuxlRin4TuD+7OwTz1CSS9QyOwMtEgkuVTVZz6wSxbG8EYDUAf3mTRLqX?=
 =?us-ascii?Q?TnP1zJ3o+CBPMdQMs9qJa3qyQ9aeIibKZ8jXepzPZb2pOjOLzzMUqYS2S1bT?=
 =?us-ascii?Q?Aq1YEkQ13gZONq/BPKuIsZ7Q9iG2e0NPH9BtTGpAY/CiR30Olg/uL1lgC5iI?=
 =?us-ascii?Q?LyRD2qru3L9RI4FLZgkLVA7v1g12BYrHPtWWAB6QuyRQ/h2mjGYZpu7gaFRn?=
 =?us-ascii?Q?sSPeYp4cMiqE+2/bjBL7V9iZCjdGVvGJl01pAgT1susofD1BOatsQs8RitYB?=
 =?us-ascii?Q?87++0f03k9a2DstLdQBh+RvFCzgjWthUitXxkVRGjfGcoSy4OLpgV+ApLTUD?=
 =?us-ascii?Q?IK7InD2NtvtS5VQVjMNoNRkhz1mJMsTn9BwcCktRAmVoTB5A6TLnCRvPDj1j?=
 =?us-ascii?Q?lNis0xZiYFnnyx5gT66I8uflrU4QhhZ6WamnBf4iaX5SmV9I2I2a6IZKhtYR?=
 =?us-ascii?Q?WbEiW131ONqlE9NkVMjJYld77j4q/gCLxwMxrvN7Ku1meN1NgI1YlDVhJne3?=
 =?us-ascii?Q?1b0RN3Wc1GFQl6qTqYF97JR+h3JFaqJ9d7MxyGkljH5xPMe2vy7oITT8Xedz?=
 =?us-ascii?Q?9919WXehBPxFYvTQu9yZVLd0jrH3xcMq8vplgyTUyw/nI5nblO65tP/BCkuA?=
 =?us-ascii?Q?mWh6USfkZY4podMXqamCno/+MwgE7O8Ecu/q/2HZpyRL5oRv+TVLHnW2D4an?=
 =?us-ascii?Q?5An7UuX60xJMkq8QdNK3zlpfuG1zN41WzZzXXC/1fUKtxEVi0yRF8tuxXzqn?=
 =?us-ascii?Q?oj9lkKYs1IGUEkx5yb4h7NSsxKTDYYpM7371u//jSEf/gGqDTs0f6zUWPxz5?=
 =?us-ascii?Q?A7ROXhLZm/LRk6+soB2LIQBySZV60wx5vb+GYaQrjJR32daoPtwA7zRRJoue?=
 =?us-ascii?Q?1HGkDTCV9A=3D=3D?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 44160e53-d69a-46ff-1a85-08da4b00b66d
X-MS-Exchange-CrossTenant-AuthSource: BN8PR12MB3108.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jun 2022 16:46:06.0439
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: oBFwXPGclLO31WcSfa8gsznEGIgQf57SeE8XLH1x4+JB3Y4wutxIeRBnqVXwfO/zGnt1Aktts3PReKkdmhbJvA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR12MB5170
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Jun 02, 2022 at 03:11:33PM -0500, Mario Limonciello wrote:
> Add support for SMN communication on Family 19h Model 70h.
> 
> Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
> ---
>  arch/x86/kernel/amd_nb.c | 4 ++++
>  include/linux/pci_ids.h  | 1 +
>  2 files changed, 5 insertions(+)
> 
> diff --git a/arch/x86/kernel/amd_nb.c b/arch/x86/kernel/amd_nb.c
> index 60c7bd525237..15295f5d9aca 100644
> --- a/arch/x86/kernel/amd_nb.c
> +++ b/arch/x86/kernel/amd_nb.c
> @@ -32,6 +32,8 @@
>  #define PCI_DEVICE_ID_AMD_19H_M40H_ROOT	0x14b5
>  #define PCI_DEVICE_ID_AMD_19H_M40H_DF_F4 0x167d
>  #define PCI_DEVICE_ID_AMD_19H_M50H_DF_F4 0x166e
> +#define PCI_DEVICE_ID_AMD_19H_M70H_ROOT	0x14e8
> +#define PCI_DEVICE_ID_AMD_19H_M70H_DF_F4 0x14f4
>

The IDs are correct. But can you please group the "ROOT" IDs together
including PCI_DEVICE_ID_AMD_19H_M40H_ROOT? Otherwise, looks good to me.

Reviewed-by: Yazen Ghannam <yazen.ghannam@amd.com>

Thanks,
Yazen