Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Miles Chen <miles.chen@mediatek.com>
To:     <masahiroy@kernel.org>
CC:     <corbet@lwn.net>, <jonathanh@nvidia.com>,
        <linux-doc@vger.kernel.org>, <linux-kbuild@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <llvm@lists.linux.dev>,
        <mpe@ellerman.id.au>, <nathan@kernel.org>,
        <ndesaulniers@google.com>, <penguin-kernel@I-love.SAKURA.ne.jp>,
        <trix@redhat.com>, <wangyugui@e16-tech.com>
Subject: Re: [PATCH v3] scripts/check-local-export: avoid 'wait $!' for process substitution
Date:   Sat, 11 Jun 2022 00:57:24 +0800
Message-ID: <20220610165724.16214-1-miles.chen@mediatek.com>
In-Reply-To: <20220608011100.486735-1-masahiroy@kernel.org>
References: <20220608011100.486735-1-masahiroy@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk

>Bash 4.4, released in 2016, supports 'wait $!' to check the exit status
>of a process substitution, but it seems too new.
>
>Some people using older bash versions (on CentOS 7, Ubuntu 16.04, etc.)
>reported an error like this:
>
>  ./scripts/check-local-export: line 54: wait: pid 17328 is not a child of this shell

Thanks for fixing this!
I hit this issue and this patch fixes my problem.

Tested-by: Miles Chen <miles.chen@mediatek.com> 

>
>I used the process substitution to avoid a pipeline, which executes each
>command in a subshell. If the while-loop is executed in the subshell
>context, variable changes within are lost after the subshell terminates.