Received: by 2002:a5d:925a:0:0:0:0:0 with SMTP id e26csp1588982iol; Fri, 10 Jun 2022 10:25:37 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyDaPz0REokIZVvJ/Lsa6CKoZdVq3DSMnOspZ145o39X85ms23r1rrNQb8eT9xjeJKXeP/r X-Received: by 2002:a17:90b:4f84:b0:1e8:436b:a9ba with SMTP id qe4-20020a17090b4f8400b001e8436ba9bamr745405pjb.191.1654881937480; Fri, 10 Jun 2022 10:25:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1654881937; cv=none; d=google.com; s=arc-20160816; b=EAhDh51mlBagB3NgH0wsm2J6MK/lfme0XDSPL75hqHryBmezdgCJAzGtUrhvuu8h7b Ma+SjUA1LMaAmuatzh0m10b97c64I068C9bXYbziRYXTwTr/r1uP05MyTf+lB4UJkCBQ 3sX669ntInQQIdmlGOf+XqYKgty8cKNHP9zMp2FTHsNjZbtF4lSB2AwB8g3sS5TqoJJj PFyZBz8HXt5taxkyfNACQ3RD16/sMKMKLubrgTiZdPLw9NFlCWE3RVNkDCbPkoOdqkLW mOY1dlYd7ZQh85TgXVL2Im7P9/1tgnPe0YLkOBwTYdpGkaER/IZSpcDR1rJLKViMKG// 8slg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=JpMKUpfeglPcDORt8WEujxxp2hBNUdv79xh1pgftNsY=; b=WMuAsr5jfnC2BAFW5mpbWERV2aE9DfgjUB1cWcAN5QDw8kgB7yNk2Mx07/Rbir74UR cauG2IVp0pqK7elXr4TH7Aw9ZKoIMQT3P2RVRqvn8BAP+mR1ES+GYTyFGQZHFAW0WCNB iwE8F8n9itp/S+1RcVBrE4i+Q3OEj6yNoxCspO93G5Ro0ALY+OxduKnjg0FD6pZ7+pNk F1dFFmBMkfyHjlFdYjLM0h6doeIVYrqjKQlzVixIq8H+FIMg/lhih3cU5Q63TrqVxfHO vs3wCJOei9Zso4IdVLd91VVpGVEcqU3jm9WGi8sHAC7HwMvnkEqdpSZTtYlVyYpHOpn4 UwAA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 200-20020a6217d1000000b0051bfad76f55si22083120pfx.348.2022.06.10.10.25.24; Fri, 10 Jun 2022 10:25:37 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345414AbiFJRA0 (ORCPT + 99 others); Fri, 10 Jun 2022 13:00:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41470 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344239AbiFJRAM (ORCPT ); Fri, 10 Jun 2022 13:00:12 -0400 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 6D31738BF0 for ; Fri, 10 Jun 2022 09:59:43 -0700 (PDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 566B012FC; Fri, 10 Jun 2022 09:59:43 -0700 (PDT) Received: from usa.arm.com (e103737-lin.cambridge.arm.com [10.1.197.49]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 83FE23F766; Fri, 10 Jun 2022 09:59:42 -0700 (PDT) From: Sudeep Holla To: linux-kernel@vger.kernel.org, Cristian Marussi , linux-arm-kernel@lists.infradead.org Cc: Sudeep Holla Subject: Re: [PATCH 1/3] firmware: arm_scmi: Review BASE protocol string-buffers sizes Date: Fri, 10 Jun 2022 17:59:31 +0100 Message-Id: <165488021406.462190.1740470149843111137.b4-ty@arm.com> X-Mailer: git-send-email 2.36.1 In-Reply-To: <20220608095530.497879-1-cristian.marussi@arm.com> References: <20220608095530.497879-1-cristian.marussi@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 8 Jun 2022 10:55:28 +0100, Cristian Marussi wrote: > SCMI Base protocol agent_name/vendor_id/sub_vendor_id are defined by the > specification as NULL-terminated ASCII strings up to 16-bytes in length. > > The underlying buffers and message descriptors are currently bigger than > needed; resize them to fit only the strictly needed 16 bytes. > > While at that, convert Base protocol strings handling routines to use the > preferred strscpy. > > [...] Applied to sudeep.holla/linux (for-next/scmi), thanks! [1/3] firmware: arm_scmi: Review BASE protocol string-buffers sizes https://git.kernel.org/sudeep.holla/c/4314f9f4f8 [2/3] firmware: arm_scmi: Fix SENSOR_AXIS_NAME_GET behaviour when unsupported https://git.kernel.org/sudeep.holla/c/8e60294c80 [3/3] firmware: arm_scmi: Use preferred strscpy to handle strings Merged in 1/3 to avoid any possible bisection issues, since they both deal with the same issue. -- Regards, Sudeep