Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 10 Jun 2022 19:47:20 +0200
From:   Stephen Kitt <steve@sk2.org>
To:     Sebastian Reichel <sebastian.reichel@collabora.com>
Cc:     Thierry Reding <thierry.reding@gmail.com>,
        Sam Ravnborg <sam@ravnborg.org>,
        David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>, linux-kernel@vger.kernel.org,
        dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 2/3] drm/panel: panel-dsi-cm: Use backlight helpers
Message-ID: <20220610194720.485cf7be@heffalump.sk2.org>
In-Reply-To: <20220609215236.ojxw6l2vkf652hgu@mercury.elektranox.org>
References: <20220607182026.1121992-1-steve@sk2.org>
        <20220607182026.1121992-3-steve@sk2.org>
        <20220609215236.ojxw6l2vkf652hgu@mercury.elektranox.org>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="Sig_/Fiv/6RAB4w3meaj/_BS+ruP";
 protocol="application/pgp-signature"; micalg=pgp-sha512
Precedence: bulk

--Sig_/Fiv/6RAB4w3meaj/_BS+ruP
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

Hi Sebastian,

On Thu, 9 Jun 2022 23:52:36 +0200, Sebastian Reichel
<sebastian.reichel@collabora.com> wrote:
> On Tue, Jun 07, 2022 at 08:20:25PM +0200, Stephen Kitt wrote:
> > diff --git a/drivers/gpu/drm/panel/panel-dsi-cm.c
> > b/drivers/gpu/drm/panel/panel-dsi-cm.c index b58cb064975f..aa36dc6cedd3
> > 100644 --- a/drivers/gpu/drm/panel/panel-dsi-cm.c
> > +++ b/drivers/gpu/drm/panel/panel-dsi-cm.c
> > @@ -86,16 +86,10 @@ static void dsicm_bl_power(struct panel_drv_data
> > *ddata, bool enable) return;
> > =20
> >  	if (enable) {
> > -		backlight->props.fb_blank =3D FB_BLANK_UNBLANK;
> > -		backlight->props.state =3D ~(BL_CORE_FBBLANK |
> > BL_CORE_SUSPENDED);
> > -		backlight->props.power =3D FB_BLANK_UNBLANK;
> > +		backlight_enable(backlight);
> >  	} else {
> > -		backlight->props.fb_blank =3D FB_BLANK_NORMAL;
> > -		backlight->props.power =3D FB_BLANK_POWERDOWN;
> > -		backlight->props.state |=3D BL_CORE_FBBLANK |
> > BL_CORE_SUSPENDED;
> > +		backlight_disable(backlight);
> >  	} =20
>=20
> The brackets can be removed now. Otherwise:

>=20
> Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.com>

Thanks, I=E2=80=99ll wait a little more to see if there are any other revie=
ws of the
patches and then push a v2 with that fix.

Regards,

Stephen

--Sig_/Fiv/6RAB4w3meaj/_BS+ruP
Content-Type: application/pgp-signature
Content-Description: OpenPGP digital signature

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEnPVX/hPLkMoq7x0ggNMC9Yhtg5wFAmKjg6gACgkQgNMC9Yht
g5zfSw//WI01jNuYSP0lMjDjiVPi3dZknMK/1vgV6zHCgisK5W9RahwyjRdg9hWW
veSzZA4xLOVHS1WpSEcsQWSRCTAoi22tZ/IhGVFTW9hpWkKUzndtuebMzQ5LuEwq
gP/c6sU3O5qP2tjMyUwDs8zAEugZl6hlcZGtkYdZUk50gUsP2ajEJ2XjblIkikEn
JskElLBZSpvBS06TzHphA7DZZW1B/GjkucvmM6vOVklRtkxbCYck7E2PCM1uPe6x
8U7pacTwdvzdf0j255cSxb6xehc1wTDKCelVrp9VcXyI1PiZb6nzW4+xSE/JF+iZ
Kyrrw8Iuom5Zwr0SlPszmdk8HiKpj+DLRugmH0fHksHAxb09L77zSZZ3krUefXrF
2A7g0AAXxy7OEZtCJyLHPiSL3Q9EHQ3FtzLH+3xddratrbdzjnbq+kPA37GqfWTk
qNo0zrCK4o2E2GFAzZf08Hg6FT5o/4LnYPZikTfmOiOYyBR5FGW2nl2AyoH3WdZC
EfzICSO2fB0i3miIcpTOH+YRJU5G0Ih1acm8FK/1x8A/GSPG/wY0juQMS9Zzkq3Q
FlsH13MKT+fqlTDwf2wl8hF5ESklSJ90CTKITJTxZiWHLkKeKIZ2l8ll5o4qg4jt
O5Rj0KaoPq+pkrIwj0Y//PlpPOd8d/X4pYuct2ujiPXp7pkaHLM=
=9bxl
-----END PGP SIGNATURE-----

--Sig_/Fiv/6RAB4w3meaj/_BS+ruP--