Received: by 2002:a5d:925a:0:0:0:0:0 with SMTP id e26csp1647034iol; Fri, 10 Jun 2022 11:43:02 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwuw1bU0fApgJX/jpd0jeZkcXC1Vf3rQdH1N9aPe/lqKFrrpJMlEWYoSoZHucUAeLZz7rBX X-Received: by 2002:a17:907:2b05:b0:710:dabf:fde2 with SMTP id gc5-20020a1709072b0500b00710dabffde2mr29640037ejc.114.1654886582166; Fri, 10 Jun 2022 11:43:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1654886582; cv=none; d=google.com; s=arc-20160816; b=GMSZdW1e2LBl6obVbz6xXi9LikOK1meS9+90j4fBbc67EiYi8MbfEcrFXhi5LTh1SC DPonGAEw+HRlpS3e7WXoVrXzWvmMjwPjSzft4UR6OPxPqn81qdfLO3iR/FhqLSiB0YWe jZoXB5a8zaj6QNJC2eBkxvVUZyvyBs0Y4URPlZMmoB3/RemnmwMaFvpCZFXaeou3nJFt 09TLP1wInqqxWnv7eSmgnOQGQMtkoQZHN7UI85tEhFSyFpje1fqfZX8DhD2rWAGdVsj1 Zqfo6kEx/5xb3S9qJdtEh7ohie+mxYUb4OwqZTOZOxl+zcRtnEusfAmfE/HKlOjaTPzq CwoA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=5td43/LE7xUx34b6knP7m4z1v8nG7U8TzU1aeN6kGX8=; b=oMaVLqzK4vEoLRmBEpFqnGV1SnM1U1el650V35UcbEfk9kakP6jK+NMVxEtY1Co47E eYcZs0MDCGra33ls11RXh5+j6R19VNho9PcfWkn8ELOI8lpIH3JhdYparaaODz/isriD SCnu65+OgyiX7L8jgC44WaCE6wesP1w+RfRI8d5aFUrGUZ0lZ8Nn3MCak/eM+Xn4J11l U3p2wsnV/OZcry5tp5YAPxBd//dVs5phr5Q2SAQ7kof0nFal9iouwj5lAMvACg1KaBeG posJpo8cHug3homSw81FMbF1qctvDvcc05ggR3m1hl5IqdqrTsTgchLPU74ynyKuXr4l J36Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=XfQw+j0q; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id bo23-20020a0564020b3700b0042a9fccd3f2si19830986edb.353.2022.06.10.11.42.36; Fri, 10 Jun 2022 11:43:02 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=XfQw+j0q; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1349963AbiFJRef (ORCPT + 99 others); Fri, 10 Jun 2022 13:34:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59502 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244325AbiFJRe1 (ORCPT ); Fri, 10 Jun 2022 13:34:27 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 514F818628A for ; Fri, 10 Jun 2022 10:34:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1654882463; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=5td43/LE7xUx34b6knP7m4z1v8nG7U8TzU1aeN6kGX8=; b=XfQw+j0q3AO5YFYVySM44rn3DfhfJc/f4VwUnMhAIVe28h5pG0IrIwJoVqoh0hk47pnkEd HnrFZuQn7qsbApQtP5XzIqoBmgdzxQ6KVEV2oJD7SIyhITXTrVTGGrQUIgjU4/vQp1LteF awFakr4siDMPMFD7J4jTTSsAGR0rMus= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-475-tYR9nyF3NEON76vtap6aEQ-1; Fri, 10 Jun 2022 13:34:22 -0400 X-MC-Unique: tYR9nyF3NEON76vtap6aEQ-1 Received: by mail-wm1-f72.google.com with SMTP id u12-20020a05600c19cc00b0038ec265155fso1607924wmq.6 for ; Fri, 10 Jun 2022 10:34:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=5td43/LE7xUx34b6knP7m4z1v8nG7U8TzU1aeN6kGX8=; b=CHuGITgqjgRhNDkQaYqP3bsrnrNJqziu8QbNPy9IuJKsR3ASR7vPMsZhAEpJ6YhN+x YsXK48YrPadK87aLdqjJCUs892voajUDBmC9QalocHHGjDpuOYjNYwQnaw5Y14Z+NPOi a8MJJed6eGbZslw9b5M5Lt86FAAju1J6ulPAfBwt/+S6GPS1pkl0SyiiOuLaN+T3tOv2 n+iyDpZ8WHCWYP6F9RXxmPVnCO6V9Bjx2iyMA3Xnen3V48+bSmKpKYGJeE9U+t/Ed03t DakH5lMr5f0hnp73bX53EkJoQmB/YVzOBtJyVGosFwPJr4ezb0wKyryUsLVATmxqWZLi LRGQ== X-Gm-Message-State: AOAM530Vfk9bpt9tQuxVSAfkXnm8y1SlUsrKtrR6KQiktVcxN+In0pj0 r5OoxFofYYX4anFPC3GqHsHssQAg22Zpba7ysjpXGLkYXWO2hU+hAjZww1Lf/w8ubG2I6J6IofN 44+nGL/jAUb3TzimwB9jj4AxT X-Received: by 2002:a05:600c:2105:b0:39c:37d0:6f5e with SMTP id u5-20020a05600c210500b0039c37d06f5emr837030wml.44.1654882461162; Fri, 10 Jun 2022 10:34:21 -0700 (PDT) X-Received: by 2002:a05:600c:2105:b0:39c:37d0:6f5e with SMTP id u5-20020a05600c210500b0039c37d06f5emr837013wml.44.1654882460984; Fri, 10 Jun 2022 10:34:20 -0700 (PDT) Received: from gator (cst2-173-67.cust.vodafone.cz. [31.30.173.67]) by smtp.gmail.com with ESMTPSA id n123-20020a1c2781000000b0039c63f4bce0sm3787780wmn.12.2022.06.10.10.34.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Jun 2022 10:34:20 -0700 (PDT) Date: Fri, 10 Jun 2022 19:34:18 +0200 From: Andrew Jones To: Sean Christopherson Cc: Paolo Bonzini , kvm@vger.kernel.org, Vitaly Kuznetsov , David Matlack , Ben Gardon , Oliver Upton , linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 132/144] KVM: selftests: Purge vm+vcpu_id == vcpu silliness Message-ID: <20220610173418.mfwhk5ou5gco6v5x@gator> References: <20220603004331.1523888-1-seanjc@google.com> <20220603004331.1523888-133-seanjc@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220603004331.1523888-133-seanjc@google.com> X-Spam-Status: No, score=-3.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org ... > @@ -1485,73 +1446,57 @@ void vcpu_run_complete_io(struct kvm_vm *vm, uint32_t vcpuid) > } > > /* > - * VM VCPU Get Reg List > - * > - * Input Args: > - * vm - Virtual Machine > - * vcpuid - VCPU ID > - * > - * Output Args: > - * None > - * > - * Return: > - * A pointer to an allocated struct kvm_reg_list > - * > * Get the list of guest registers which are supported for > - * KVM_GET_ONE_REG/KVM_SET_ONE_REG calls > + * KVM_GET_ONE_REG/KVM_SET_ONE_REG ioctls. Returns a kvm_reg_list pointer, > + * it is the callers responsibility to free the list. nit: caller's or callers' Thanks, drew