Received: by 2002:a5d:925a:0:0:0:0:0 with SMTP id e26csp1650748iol; Fri, 10 Jun 2022 11:48:56 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx0AbQNXcZPmBgTdtUiZ1IdCf/YYcNmSpDIMcu/1P0FxoxbYsWcxi+VuW+SoReEEjia20/z X-Received: by 2002:a17:906:7a56:b0:712:a26:8d71 with SMTP id i22-20020a1709067a5600b007120a268d71mr8256388ejo.728.1654886936491; Fri, 10 Jun 2022 11:48:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1654886936; cv=none; d=google.com; s=arc-20160816; b=OSMpb+1fU1x9MTUlOvW0Y+9jUxRQlxZ3YvcXKUKOtXCVUVqU3Wsd1hgMA9zqWvKMO5 eqKFw+SMmNAXNPy0b/IkqIAren3nRaNSVTOHW3djFMyxjxwnOSdIYsV3ETd+Ic+UcLam C7e+7qTrpzPMEJyRS8CL/yALS1Bj8yqlE3A9Vg8yiDJx41LQdM6l3+5/m2xiXS5xLn7l VevEn6O9zEfVopV0w+vTY9E9cLo5OOoaKCDUP1cpuybANoRqaI0kVmiF2/NVpsaX6dEe IJxXVaiZhbgnVITsbTtcynQwjjXYEs5R6VFoJ4igeRcV1I+rzoHZFwC//GKZQ8rxj7+O Nlng== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=uZZMSYsxNi00mISt/w3TR5/PXiZxHkemYMMPWE5iiPc=; b=ZEAOPDLWpHcx+voT8is1ECjkRh/JeFGTXpjb6XcphdF8FoQg0sn5B3iCs2PVMW9PsV yvb5W2IF/K/rQUPdHZghoN742CfYZH9sJC15Z7N/FdsXyOldC22asOkuJoc3J176kMyT D0+rNKp5GMainLL6txfumWLljv7TaEs0gCKat5L/Th7LIbUKZnlJkEzUJYIZNC1NnXwW LAShOfaI741eirRiqsfoUx8k3/rfEe/Hvp19K8XtgCsDxUt+YOyL3x726sJFfiPunZim DJedYZVhLZeCTgeUGtw6ztsmV/MtTIQ7mzovD4/AyFjCR6hUnx+932/eTzoSWY52svoT uICA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=Mnee0qtM; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id dm4-20020a170907948400b0070939c272f8si29308983ejc.273.2022.06.10.11.48.31; Fri, 10 Jun 2022 11:48:56 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=Mnee0qtM; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1347508AbiFJSEL (ORCPT + 99 others); Fri, 10 Jun 2022 14:04:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46780 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1346245AbiFJSEG (ORCPT ); Fri, 10 Jun 2022 14:04:06 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 282D5B4B0 for ; Fri, 10 Jun 2022 11:04:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1654884245; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=uZZMSYsxNi00mISt/w3TR5/PXiZxHkemYMMPWE5iiPc=; b=Mnee0qtMvzb7FKqTSZfbZ9PFSqnMsnqkR5yo71n3hWxijtlDgtirMy+ApiaGxHohlIU7ln OD6Sq7SRhVV5QHm8BhbTjG9hHcdGekTmBeF+4pITQLOXkDuEFL8aQNoM5zyf7ZuyOSOAnl Fdm/YXxRjXMDn7RwOWtNNQ3tpcREC88= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-509-N3MnL7AcObeNw9IZQQV2GA-1; Fri, 10 Jun 2022 14:04:04 -0400 X-MC-Unique: N3MnL7AcObeNw9IZQQV2GA-1 Received: by mail-wm1-f69.google.com with SMTP id k16-20020a7bc310000000b0038e6cf00439so27618wmj.0 for ; Fri, 10 Jun 2022 11:04:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=uZZMSYsxNi00mISt/w3TR5/PXiZxHkemYMMPWE5iiPc=; b=6cHQc7fnmegha8enM0siAH+wauSmHgqtJOPRmGXOYXCcC+t+oA04ERYsDo0ahSgygK Rf5feuxfGT/m+4QoTbg69NXBBFux8rIDHzFTHvPzjek8aucgfse/oRtISiCRzh7IWT3D x/NVRdNVsLXZ7a1wLf3tdsCX5GLUouSHxMvto0R52sKVSV7Yw05WgLhZxcAXSh2qPdLt hK48tVVdLeBtaRVi6e+UgN9CWl4l0lKUgy5cw0moHIFBNkHGr2RA0wAqn/Q7BXL26AlG m7ofweP3qu3ZGZaxqxhvKU/74mOnmxd4+MPw3EQ5QiWXevP0fiN1efgUSCd6MMVWhiF7 wPPA== X-Gm-Message-State: AOAM530oCm4r7e2ussvjZmIatWb1DpULkK0edvfs/myddRM3nsfh1K3f qtdmWqKJYPRljWgwjd3Y4YqTZslsb79eGW+XzY2U/18R3pGnW81v++u+7wpYe4W2QsT6/LWdU/6 lcqJQX/qBlLGzFZwsAcgs79Uv X-Received: by 2002:a1c:5444:0:b0:39c:3761:ac37 with SMTP id p4-20020a1c5444000000b0039c3761ac37mr943461wmi.144.1654884242952; Fri, 10 Jun 2022 11:04:02 -0700 (PDT) X-Received: by 2002:a1c:5444:0:b0:39c:3761:ac37 with SMTP id p4-20020a1c5444000000b0039c3761ac37mr943440wmi.144.1654884242685; Fri, 10 Jun 2022 11:04:02 -0700 (PDT) Received: from gator (cst2-173-67.cust.vodafone.cz. [31.30.173.67]) by smtp.gmail.com with ESMTPSA id u2-20020a056000038200b0020ff3a2a925sm68257wrf.63.2022.06.10.11.04.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Jun 2022 11:04:02 -0700 (PDT) Date: Fri, 10 Jun 2022 20:03:59 +0200 From: Andrew Jones To: Sean Christopherson Cc: Paolo Bonzini , kvm@vger.kernel.org, Vitaly Kuznetsov , David Matlack , Ben Gardon , Oliver Upton , linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 142/144] KVM: selftests: Add kvm_has_cap() to provide syntactic sugar Message-ID: <20220610180359.sx3yiunvpu56stm5@gator> References: <20220603004331.1523888-1-seanjc@google.com> <20220603004331.1523888-143-seanjc@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220603004331.1523888-143-seanjc@google.com> X-Spam-Status: No, score=-3.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jun 03, 2022 at 12:43:29AM +0000, Sean Christopherson wrote: ... > diff --git a/tools/testing/selftests/kvm/lib/kvm_util.c b/tools/testing/selftests/kvm/lib/kvm_util.c > index 8f7ee9cb551c..12b7c40542df 100644 > --- a/tools/testing/selftests/kvm/lib/kvm_util.c > +++ b/tools/testing/selftests/kvm/lib/kvm_util.c > @@ -80,7 +80,7 @@ unsigned int kvm_check_cap(long cap) > > close(kvm_fd); > > - return ret; > + return (unsigned int)ret; > } This belongs in the last patch. Thanks, drew