Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762957AbXEUWQP (ORCPT ); Mon, 21 May 2007 18:16:15 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1758179AbXEUWP7 (ORCPT ); Mon, 21 May 2007 18:15:59 -0400 Received: from as1.cineca.com ([130.186.84.251]:55524 "EHLO as1.cineca.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757441AbXEUWP6 (ORCPT ); Mon, 21 May 2007 18:15:58 -0400 Message-ID: <465219FA.7080305@users.sourceforge.net> From: Andrea Righi Reply-To: righiandr@users.sourceforge.net User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.1.3) Gecko/20070326 Thunderbird/2.0.0.0 Mnenhy/0.7.5.666 MIME-Version: 1.0 To: Folkert van Heusden Cc: Jan Engelhardt , Andi Kleen , Stephen Hemminger , Eric Dumazet , Rik van Riel , LKML , linux-mm@kvack.org Subject: Re: signals logged / [RFC] log out-of-virtual-memory events References: <464C9D82.60105@redhat.com> <20070520205500.GJ22452@vanheusden.com> <200705202314.57758.ak@suse.de> <46517817.1080208@users.sourceforge.net> <20070521110406.GA14802@vanheusden.com> <20070521124734.GB14802@vanheusden.com> <4651A564.9090509@users.sourceforge.net> <20070521185947.GF14802@vanheusden.com> In-Reply-To: <20070521185947.GF14802@vanheusden.com> X-Enigmail-Version: 0.95.0 OpenPGP: id=77CEF397; url=keyserver.veridis.com Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 7bit Date: Tue, 22 May 2007 00:15:55 +0200 (MEST) Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1305 Lines: 28 Folkert van Heusden wrote: >>>>> What about the following enhancement: I check with sig_fatal if it would >>>>> kill the process and only then emit a message. So when an application >>>>> takes care itself of handling it nothing is printed. >>>>> + /* emit some logging for unhandled signals >>>>> + */ >>>>> + if (sig_fatal(t, sig)) >>>> Not unhandled_signal()? >>> Can we already use that one in send_signal? As the signal needs to be >>> send first I think before we know if it was handled or not? sig_fatal >>> checks if the handler is set to default - which is it is not taken care >>> of. >> What about ptrace()'d processes? I don't think we should log signals for them... > > Why not? Maybe sometimes it's useful, maybe not, but I suppose that usually only the controlling process should care about the critical signals received by the controlled process. I simply don't think it should be a system issue. For example I wouldn't like to have a lot of messages in the kernel logs just because I'm debugging some segfaulting programs with gdb. -Andrea - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/