Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 10 Jun 2022 21:52:36 +0200
From:   Stephen Kitt <steve@sk2.org>
To:     Sam Ravnborg <sam@ravnborg.org>
Cc:     Sebastian Reichel <sebastian.reichel@collabora.com>,
        David Airlie <airlied@linux.ie>, linux-kernel@vger.kernel.org,
        dri-devel@lists.freedesktop.org,
        Thierry Reding <thierry.reding@gmail.com>
Subject: Re: [PATCH 2/3] drm/panel: panel-dsi-cm: Use backlight helpers
Message-ID: <20220610215236.0d5d47b7@heffalump.sk2.org>
In-Reply-To: <YqObYPttYuRDikrO@ravnborg.org>
References: <20220607182026.1121992-1-steve@sk2.org>
        <20220607182026.1121992-3-steve@sk2.org>
        <20220609215236.ojxw6l2vkf652hgu@mercury.elektranox.org>
        <20220610194720.485cf7be@heffalump.sk2.org>
        <YqObYPttYuRDikrO@ravnborg.org>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="Sig_/h3C.i8DgeSuOC0V+IcexQeD";
 protocol="application/pgp-signature"; micalg=pgp-sha512
Precedence: bulk

--Sig_/h3C.i8DgeSuOC0V+IcexQeD
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

On Fri, 10 Jun 2022 21:28:32 +0200, Sam Ravnborg <sam@ravnborg.org> wrote:
> Hi Stephen.
> On Fri, Jun 10, 2022 at 07:47:20PM +0200, Stephen Kitt wrote:
> > Hi Sebastian,
> >=20
> > On Thu, 9 Jun 2022 23:52:36 +0200, Sebastian Reichel
> > <sebastian.reichel@collabora.com> wrote: =20
> > > On Tue, Jun 07, 2022 at 08:20:25PM +0200, Stephen Kitt wrote: =20
> > > > diff --git a/drivers/gpu/drm/panel/panel-dsi-cm.c
> > > > b/drivers/gpu/drm/panel/panel-dsi-cm.c index
> > > > b58cb064975f..aa36dc6cedd3 100644 ---
> > > > a/drivers/gpu/drm/panel/panel-dsi-cm.c +++
> > > > b/drivers/gpu/drm/panel/panel-dsi-cm.c @@ -86,16 +86,10 @@ static
> > > > void dsicm_bl_power(struct panel_drv_data *ddata, bool enable) retu=
rn;
> > > > =20
> > > >  	if (enable) {
> > > > -		backlight->props.fb_blank =3D FB_BLANK_UNBLANK;
> > > > -		backlight->props.state =3D ~(BL_CORE_FBBLANK |
> > > > BL_CORE_SUSPENDED);
> > > > -		backlight->props.power =3D FB_BLANK_UNBLANK;
> > > > +		backlight_enable(backlight);
> > > >  	} else {
> > > > -		backlight->props.fb_blank =3D FB_BLANK_NORMAL;
> > > > -		backlight->props.power =3D FB_BLANK_POWERDOWN;
> > > > -		backlight->props.state |=3D BL_CORE_FBBLANK |
> > > > BL_CORE_SUSPENDED;
> > > > +		backlight_disable(backlight);
> > > >  	}   =20
> > >=20
> > > The brackets can be removed now. Otherwise: =20
> >  =20
> > >=20
> > > Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.com> =20
> >=20
> > Thanks, I=E2=80=99ll wait a little more to see if there are any other r=
eviews of
> > the patches and then push a v2 with that fix. =20
> It would be very nice if you could kill all uses of FB_BLANK in the
> drivers/gpu/drm/panel/* drivers, and post them as one series.
> This is long overdue to introduce the backlight helpers.
>=20
> The three you posted is already a nice step forward, and there may be
> more panel drivers I have missed.

With this series on top of 5.19-rc1, the only remaining .fb_blank reference=
 is
in acx565akm_backlight_init() in panel-sony-acx565akm.c; I was planning on
nuking that along with the other .fb_blank initialisers in a series removing
.fb_blank entirely from backlight_properties. I=E2=80=99ll add it as a four=
th patch
for drm/panel if that makes things easier!

There will still be references to FB_BLANK constants since they=E2=80=99re =
used for
backlight_properties.power values. Would it make sense to rename those?

Regards,

Stephen

--Sig_/h3C.i8DgeSuOC0V+IcexQeD
Content-Type: application/pgp-signature
Content-Description: OpenPGP digital signature

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEnPVX/hPLkMoq7x0ggNMC9Yhtg5wFAmKjoQQACgkQgNMC9Yht
g5w1wA/+LN0+/CDVxZV49N+eebrd08Wh2wSZNW/GHE4YOp6TbzDidFX2NCp7PDG3
huw6ptYSS5zwufLv/oLE4HlshS6+5fVyvZyungOSpwfto4Ay5KR211xsCbxpdFk/
QDNRR6pn81hWzRxmdLle79HO1oWx1f2k1rVGSIYwt5LyxImdn3qS3CmNxYTR8ful
H8Yu2CJ+udrhSxflQW74mpYzVTs7elnXL5MIhJ9noG1QJ9Ymn2fFth33sHNd6sWV
S/SR0K1UUobBXVP37CyjldxTdxGYiu50kKrdiBEecp9RmE9fM3Gayzqep62mtBX4
0SZncfWuiR5rB/+nvXgpvrjl+4Acas1lgfr+YwyXGnXNINUWcQBhZBPXx45dcFPP
dosuSR+mkegJTcWjJgDarBAHNuYZfQ+3q0IB+M33D+oAkcgFhDZrgKJSK7peVi8n
3i32dooNuMa6ljSStEkVW1N6ixNI2uhBcUydD3aB4SiDDGgfc5C1wTMTaVEFbkqT
CUOZ1uTauftmBUyVIOEQ8Zij0p9+6AznP1kXfAA/qRm+xg1NDdkBo0198ToPnCDz
Y5ykpmQ8wdj9IH/xlAwXNEdX1NtyuLPbx/GnpLx7m5g6m+f77DueJcXQhzz4WMDd
Cy9/Jm5zVEw49ziokdLjhgYGx+qnQLm2hx+F/fzZAjF8fLDtzKg=
=qbaU
-----END PGP SIGNATURE-----

--Sig_/h3C.i8DgeSuOC0V+IcexQeD--