Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 10 Jun 2022 21:56:06 +0200
From:   Stephen Kitt <steve@sk2.org>
To:     Sam Ravnborg <sam@ravnborg.org>
Cc:     Sebastian Reichel <sebastian.reichel@collabora.com>,
        David Airlie <airlied@linux.ie>, linux-kernel@vger.kernel.org,
        dri-devel@lists.freedesktop.org,
        Thierry Reding <thierry.reding@gmail.com>
Subject: Re: [PATCH 2/3] drm/panel: panel-dsi-cm: Use backlight helpers
Message-ID: <20220610215606.5c7a97b9@heffalump.sk2.org>
In-Reply-To: <20220610215236.0d5d47b7@heffalump.sk2.org>
References: <20220607182026.1121992-1-steve@sk2.org>
        <20220607182026.1121992-3-steve@sk2.org>
        <20220609215236.ojxw6l2vkf652hgu@mercury.elektranox.org>
        <20220610194720.485cf7be@heffalump.sk2.org>
        <YqObYPttYuRDikrO@ravnborg.org>
        <20220610215236.0d5d47b7@heffalump.sk2.org>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="Sig_/80XS4+CdZ9JSPRbvT9=p+Py";
 protocol="application/pgp-signature"; micalg=pgp-sha512
Precedence: bulk

--Sig_/80XS4+CdZ9JSPRbvT9=p+Py
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

On Fri, 10 Jun 2022 21:52:36 +0200, Stephen Kitt <steve@sk2.org> wrote:

> On Fri, 10 Jun 2022 21:28:32 +0200, Sam Ravnborg <sam@ravnborg.org> wrote:
> > Hi Stephen.
> > On Fri, Jun 10, 2022 at 07:47:20PM +0200, Stephen Kitt wrote: =20
> > > Hi Sebastian,
> > >=20
> > > On Thu, 9 Jun 2022 23:52:36 +0200, Sebastian Reichel
> > > <sebastian.reichel@collabora.com> wrote:   =20
> > > > On Tue, Jun 07, 2022 at 08:20:25PM +0200, Stephen Kitt wrote:   =20
> > > > > diff --git a/drivers/gpu/drm/panel/panel-dsi-cm.c
> > > > > b/drivers/gpu/drm/panel/panel-dsi-cm.c index
> > > > > b58cb064975f..aa36dc6cedd3 100644 ---
> > > > > a/drivers/gpu/drm/panel/panel-dsi-cm.c +++
> > > > > b/drivers/gpu/drm/panel/panel-dsi-cm.c @@ -86,16 +86,10 @@ static
> > > > > void dsicm_bl_power(struct panel_drv_data *ddata, bool enable)
> > > > > return;=20
> > > > >  	if (enable) {
> > > > > -		backlight->props.fb_blank =3D FB_BLANK_UNBLANK;
> > > > > -		backlight->props.state =3D ~(BL_CORE_FBBLANK |
> > > > > BL_CORE_SUSPENDED);
> > > > > -		backlight->props.power =3D FB_BLANK_UNBLANK;
> > > > > +		backlight_enable(backlight);
> > > > >  	} else {
> > > > > -		backlight->props.fb_blank =3D FB_BLANK_NORMAL;
> > > > > -		backlight->props.power =3D FB_BLANK_POWERDOWN;
> > > > > -		backlight->props.state |=3D BL_CORE_FBBLANK |
> > > > > BL_CORE_SUSPENDED;
> > > > > +		backlight_disable(backlight);
> > > > >  	}     =20
> > > >=20
> > > > The brackets can be removed now. Otherwise:   =20
> > >    =20
> > > >=20
> > > > Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.com>   =
=20
> > >=20
> > > Thanks, I=E2=80=99ll wait a little more to see if there are any other=
 reviews of
> > > the patches and then push a v2 with that fix.   =20
> > It would be very nice if you could kill all uses of FB_BLANK in the
> > drivers/gpu/drm/panel/* drivers, and post them as one series.
> > This is long overdue to introduce the backlight helpers.
> >=20
> > The three you posted is already a nice step forward, and there may be
> > more panel drivers I have missed. =20
>=20
> With this series on top of 5.19-rc1, the only remaining .fb_blank referen=
ce
> is in acx565akm_backlight_init() in panel-sony-acx565akm.c; I was planning
> on nuking that along with the other .fb_blank initialisers in a series
> removing .fb_blank entirely from backlight_properties. I=E2=80=99ll add i=
t as a
> fourth patch for drm/panel if that makes things easier!

That=E2=80=99s in drivers/gpu/drm/panel of course, there are a few others e=
lsewhere
(I=E2=80=99ve got patches in flight for most of them, I=E2=80=99ve got the =
rest ready for
submission).

> There will still be references to FB_BLANK constants since they=E2=80=99r=
e used for
> backlight_properties.power values. Would it make sense to rename those?

Just to make sure =E2=80=94 I=E2=80=99m cleaning up backlight_properties.fb=
_blank, not
fb_ops.fb_blank. I wasn=E2=80=99t planning on touching the latter...

Regards,

Stephen

--Sig_/80XS4+CdZ9JSPRbvT9=p+Py
Content-Type: application/pgp-signature
Content-Description: OpenPGP digital signature

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEnPVX/hPLkMoq7x0ggNMC9Yhtg5wFAmKjodYACgkQgNMC9Yht
g5zgdg/+IdFMt3CSBicFd90HvGT0WoTKYAJFPFnHEWkMP5NNbOshaTX7eHnYfuB6
gDkYhXuGC6OZJ1N839HXyXWPkmL4iZX/+Ba1hCFqOx+2znIY+zRRlf19+EdvyuGU
jarSv7VZScgVjrFtpVtt1DRRlFqG86ppemyH3og1S+7gQ1gss7maNILXyRg/40lj
VhmluONX1E+pIW9Dh50iGKEd3Gn/Im4B0UwV383fLlOMgtOyjGJ5BfMKJ/E+A3vo
XedrZPJ3xFFSo9l5kNKnGChwXBkUfBKg74fc1q1QmpFVb/dTAVHWy0bL7bCpSoPs
s/XfpgIFEQqWdrKTB9yR2O67OLHL0AnMUDYJcIemBcyEmVL6WlEpKp1I7czEP8Fq
m79YxTTzO12Sath7Yh6ntGYBgMLBO57Vl+CSqDNpuXQAWD7u5HQLpHiYE8vaAfPG
D+WHSu4ZUVOrpAe8TonrzKgXTsHwZzR0JZ2EmSSJsyPmmSk+0Ro8PR64grw7n4Di
FUqVotIKtY7uDfXsRiTNhPlIpde1Sm4MDQPhITEcVdSRCXkTdsq3jZFhvKW8l8Wx
bQxICmVk1WQGubs++s8ArUxJhO4KnAzsB3yiv/obcMT4lgWKbUmUmyjSlYngLVnq
jaP+Hb4auLOEWvoWOReySy7ovgrkhhZ9zuqGvDYB3IToa2uoULs=
=HpMT
-----END PGP SIGNATURE-----

--Sig_/80XS4+CdZ9JSPRbvT9=p+Py--