Received: by 2002:a5d:925a:0:0:0:0:0 with SMTP id e26csp1780972iol; Fri, 10 Jun 2022 15:04:38 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx6meg2+srQXmjm689eM+xZ+K67AbNqtmmJGuPFkfrniQVB+tMu8N/Xg5svQTLLye0mKVou X-Received: by 2002:a17:907:1c2a:b0:6ff:4275:1e54 with SMTP id nc42-20020a1709071c2a00b006ff42751e54mr43083867ejc.138.1654898678183; Fri, 10 Jun 2022 15:04:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1654898678; cv=none; d=google.com; s=arc-20160816; b=Yx/ry3w5gkv+kvW+n0lGUnu7veYDgfWhYxR4LCaN1pCqwO3BOd71XAgVWr0icO8rGY HhI0eWwKFlalFG2pM25pYmwX5aqxoPEnyy++zic8cUbYT5TS1bEsUXJ8sp/CMskJZTdP 1Y6FHlZKDigWhBC2krLLj3uQbk1eur/JMZV3CdIxwyW4hkulonA7MioIdcXPFulRPzF/ /Aro5T/d+1i7d9bxejwW2R+jdI+DljWdyTIu8zaM8DHGFIZyWULQMA4n7+fh7k+cBtam s+5avvF6mdbvG8V9aR+WtnBrVO/xu4201BFUVNgob/cW61GN7R53lmXgpaGVVXtzwbzU iAzA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:references:in-reply-to:subject:cc:to:from :dkim-signature; bh=D+aGFkn3MMYrpYUMA1fpcNyVhojWLAMYD9npxZIcNjY=; b=lzNka0RfDnfEQ5y0baAoWGjQIAS/+f8d/jyMYWW5rNs9vefCRBy31HUXSjy9ICrnt+ +8XV6Sv+LLX7iU6porm9LPzREWdkVHl4a9ZWQBXGfObYQZu+M4VwrSpHVjcnDXrRf/Zy oscekIweyrGCsq1shsuTDq9BDp5SG7c1miTv7OvIkfYx8w9q1Da4/Wz0drjBk8R2PtPn +5Uy4I5UoQDP6fex+79XSgom+jpa2uS7abGZO+XQnj6ZUdcyfWgHHmLpRiddkx6frNPz FRMKUHrVWm74SDKG49BSIwh1QQZN8YSmWVRhAjWKJPWW+T8tntvGhT18o+wHKhcRDNvZ FG/Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=inj+FjTL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id m25-20020a509319000000b0042aece2ebf2si369368eda.276.2022.06.10.15.04.12; Fri, 10 Jun 2022 15:04:38 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=inj+FjTL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1350467AbiFJUeg (ORCPT + 99 others); Fri, 10 Jun 2022 16:34:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59818 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1350663AbiFJUea (ORCPT ); Fri, 10 Jun 2022 16:34:30 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id DD25A3028A5 for ; Fri, 10 Jun 2022 13:34:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1654893265; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=D+aGFkn3MMYrpYUMA1fpcNyVhojWLAMYD9npxZIcNjY=; b=inj+FjTL2Zgjyvy8+cFIKVwue6d5r2zU6R+/GpVI8qkhVqsZk95qvM2lJamI7XSClChP+T wMBFhGThj95y76w0LfI0zx4SjUoGMuZ+diursiqHCDugbrlfysJJAhQvaGLW602myoN1SH 0YUO6S56eonQy44YqyxNRrRCcxF3mSg= Received: from mail-ej1-f69.google.com (mail-ej1-f69.google.com [209.85.218.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-656-ADojAG_wP7KSCBNz9A790A-1; Fri, 10 Jun 2022 16:34:23 -0400 X-MC-Unique: ADojAG_wP7KSCBNz9A790A-1 Received: by mail-ej1-f69.google.com with SMTP id x2-20020a1709065ac200b006d9b316257fso42157ejs.12 for ; Fri, 10 Jun 2022 13:34:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version:content-transfer-encoding; bh=D+aGFkn3MMYrpYUMA1fpcNyVhojWLAMYD9npxZIcNjY=; b=GN58SKtKa53TZMaNtO8ReE6OKLoFLII8+qMUbBiji2LzmffKmzbw0gl4FWrPKPUMaG Wd6512rkvB/Vo23aP8BddtPKWhOIDRnpDOPGcw2uqLAb+4zj4NmZ3P9FUUWXocMKLmm3 PLWz1cjm8BciOSWsxVGkvG0Ct5o0asrj1yc2RJ3wGXsx0qORD0P/svviBu+LTpVh022d y6vMvNOZTiFCI+RcWYbmqpQKMNUJB8Hue0rN8DbIDAj1Rimiyi1BhAsLrlHMXQQazlvz Ps0VoiTeleQyR/swEoZ/bhFoRZ/7mirI6RisJSN7E9dlz7MEbvrD3k+ozy2l1dhrfRc9 nP6g== X-Gm-Message-State: AOAM531zRe41dVHusU01ZgrosMu4Q47L9uQTxRQz8wvYiMUEi9DgXG+b +evf/bDo3oWeNBx+HLV7wvfT/yRFZibTB3dPYDuFcNzq4EH2s9cgbNWhN/eL06Oy7g571e8aB/6 aH0/DFALKgAoYKx6eT2RHt3GW X-Received: by 2002:a17:906:6a23:b0:711:ea9b:89ba with SMTP id qw35-20020a1709066a2300b00711ea9b89bamr16479289ejc.740.1654893262626; Fri, 10 Jun 2022 13:34:22 -0700 (PDT) X-Received: by 2002:a17:906:6a23:b0:711:ea9b:89ba with SMTP id qw35-20020a1709066a2300b00711ea9b89bamr16479269ejc.740.1654893262291; Fri, 10 Jun 2022 13:34:22 -0700 (PDT) Received: from alrua-x1.borgediget.toke.dk ([45.145.92.2]) by smtp.gmail.com with ESMTPSA id jw15-20020a17090776af00b006fec9cf9237sm29367ejc.130.2022.06.10.13.34.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Jun 2022 13:34:21 -0700 (PDT) Received: by alrua-x1.borgediget.toke.dk (Postfix, from userid 1000) id 8E880405EFB; Fri, 10 Jun 2022 22:34:20 +0200 (CEST) From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= To: Zhengchao Shao , bpf@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, ast@kernel.org, daniel@iogearbox.net, davem@davemloft.net, kuba@kernel.org, hawk@kernel.org, john.fastabend@gmail.com, andrii@kernel.org, kafai@fb.com, songliubraving@fb.com, yhs@fb.com, kpsingh@kernel.org Cc: weiyongjun1@huawei.com, shaozhengchao@huawei.com, yuehaibing@huawei.com Subject: Re: [PATCH v6,bpf-next] samples/bpf: check detach prog exist or not in xdp_fwd In-Reply-To: <20220606005425.261967-1-shaozhengchao@huawei.com> References: <20220606005425.261967-1-shaozhengchao@huawei.com> X-Clacks-Overhead: GNU Terry Pratchett Date: Fri, 10 Jun 2022 22:34:20 +0200 Message-ID: <87edzw2r77.fsf@toke.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-3.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Zhengchao Shao writes: > Before detach the prog, we should check detach prog exist or not. > > Signed-off-by: Zhengchao Shao LGTM! Reviewed-by: Toke H=C3=B8iland-J=C3=B8rgensen