Received: by 2002:a5d:925a:0:0:0:0:0 with SMTP id e26csp8909iol; Fri, 10 Jun 2022 19:38:42 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyzeGngD9BGR5isg80tltI1GEXmj8xXOnmuuekrAMhykTG6diyNCSZYjph9HmVSpHmb4ehm X-Received: by 2002:a17:902:9a8d:b0:167:77c3:4c86 with SMTP id w13-20020a1709029a8d00b0016777c34c86mr30250179plp.122.1654915122509; Fri, 10 Jun 2022 19:38:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1654915122; cv=none; d=google.com; s=arc-20160816; b=CecoChsXEtnthr1xxQie9upkbl9P9/IcMA5CwU5Ha370Iqg1Rxq0MDD5XHeeSI8Dgz rEgOutJlgaEAV4/adClSmxO5j4vCOlj58knqJP/iUq7p41xAQVLLE8/DUPGvtHLYGXpR Czdo4gfMTbZqPX/kbufKYrqk4XlvOjdTMWSkreWowuXgI8LoJlIbOri7cJP30/Gau3ca VTA9Hgd/IwVp5GQurG3K+dOckgBk6gKlcNxwKG4ey32Kf3frQHB2DekvgIkb8F2jiTtj O6mKeL99pghPZ582/Hisr94/vop2NWD5A8D1gmx99fQ+JXqONhKk74Za2+qxJoKwQ7fr ylXQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:message-id:date:subject:cc:to:from; bh=6ZfTEogtu8cEe/xMXFj4vMFMcOXDgJ8hTrEhjEgUah8=; b=tK5Z1AJGsb2FxdFXTSAGMMxGllDW2CziYSsTJFTvx77hkJtF672I5BGD1sJTyk3Q6A kmrxsRhlitTgzaCf7j11TtSUgrfP0Ai7OsHO5UTag7u7OQt4VN0Zb5JtqUheGkUyjQWk d8aMEg8ZVk3ADHLjnSPSfXnYQzDEVLWQWXA8ZcuWGb4tQitGqpVvc/dxvnjcapRbL2ja 75LfLpEePGxpQdMgkX0yjshu2xOtYEy4auJu95nvBVL20ioo96XD/wfyPX3Zr6rfhRea u9uyL5U9sk4uSdIpo9plLi70cUVedTYcJ4n+DdRcc8YtW55cSZidUwHtNNH6CZZd6j5K pJqA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id u185-20020a6379c2000000b004037c60a2c6si915101pgc.668.2022.06.10.19.38.29; Fri, 10 Jun 2022 19:38:42 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1347415AbiFKCQv (ORCPT + 99 others); Fri, 10 Jun 2022 22:16:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44788 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244605AbiFKCQv (ORCPT ); Fri, 10 Jun 2022 22:16:51 -0400 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2D7572FE60E; Fri, 10 Jun 2022 19:16:50 -0700 (PDT) Received: from kwepemi500023.china.huawei.com (unknown [172.30.72.57]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4LKhHw0qD0zjX7G; Sat, 11 Jun 2022 10:15:24 +0800 (CST) Received: from huawei.com (10.175.112.208) by kwepemi500023.china.huawei.com (7.221.188.76) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Sat, 11 Jun 2022 10:16:47 +0800 From: Peng Wu To: , , CC: , , , , Subject: [PATCH] spi: micro: fix unreasonable clk_prepare_enable() on error in mchp_corespi_probe() Date: Sat, 11 Jun 2022 02:11:17 +0000 Message-ID: <20220611021117.40494-1-wupeng58@huawei.com> X-Mailer: git-send-email 2.17.1 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.175.112.208] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To kwepemi500023.china.huawei.com (7.221.188.76) X-CFilter-Loop: Reflected X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fix the unreasonable clk_prepare_enable() with clk_disable_unprepare() before return from mchp_corespi_probe() in the error handling case. Signed-off-by: Peng Wu --- drivers/spi/spi-microchip-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/spi/spi-microchip-core.c b/drivers/spi/spi-microchip-core.c index 5b2aee30fa04..bf6847d95fe3 100644 --- a/drivers/spi/spi-microchip-core.c +++ b/drivers/spi/spi-microchip-core.c @@ -580,7 +580,7 @@ static int mchp_corespi_probe(struct platform_device *pdev) error_release_hardware: mchp_corespi_disable(spi); - clk_prepare_enable(spi->clk); + clk_disable_unprepare(spi->clk); error_release_master: spi_master_put(master); -- 2.17.1