Received: by 2002:a5d:925a:0:0:0:0:0 with SMTP id e26csp212323iol; Sat, 11 Jun 2022 02:23:48 -0700 (PDT) X-Google-Smtp-Source: ABdhPJym9pBVzyTwHlR2gpdpkvq9YyXoTBEboi0ddy7QNq2qHz+ezPl3HpJDZtADqkzDk2xj5+K5 X-Received: by 2002:a17:90b:4b10:b0:1e8:3609:7fc7 with SMTP id lx16-20020a17090b4b1000b001e836097fc7mr4168911pjb.150.1654939428233; Sat, 11 Jun 2022 02:23:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1654939428; cv=none; d=google.com; s=arc-20160816; b=HqFNBz2grxer51VwXvIu/7ApUgP2YAGZ5/AA5qqVDdi52en5GWNhwzGWUQAZGYDPcZ EcwEtXrXe5lDTRVjdBAAcqLlJ0WWd6A7teIlxT4zdICAcho5oi8VtokR9x8MTvRSuh5s XTjUw7RWidXd2HhWK74jkrgNkAgiJ83UcwBGypCKTtduQtgt1Nmt/7PeoAbD73R0NGbo ylwY8eBxPn1JllcNv8FWI5hd+6uP79R+t1BpaH53uUB3AfcigrXtSZ4TfybdvI0/5+NR OthYdrDJOZKH0iNOafn5Dnasw1iob1HKQCcXAo3rMSl1ccwTlNdePxL7zDQC3JXxI8zl z9XQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=kgTyrgtD/vWHHcRC/0sprBGuCN/0gxyL+3T2gDCT8x8=; b=mEXWBxnDV3ElncSQgKplwQYl0wkbiisK2FIl7I1GjRKTE3dVou4XRX+I53L8OV1Acy bpRjP1VjSEt/IDYBrISUHMRfA6918Zzs1GHsq6hvBlIOsMa4gblJRcDqQqCXoHcAmxii Ac9Qzyy3r89McfZvCz6IMwkWoDpBmr2w6yZ6Xvf5CSEoO9kP7b7n/FGGoCQOEqA/d6/y Lw7qFe9denaQL+mbOF0UQJ1f8zM0odvs7i9b66eE9YKoZznynp00VjGIHhPzeTeqb12f gSNSbBj3akW9jp1vXYFj0jeqf4+sQ7uKp4sZ4jibaM2mZyHn3i+lgxL/7s8VU0PdDC/U Go9w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 19-20020a170902e9d300b001676e7406edsi2144834plk.195.2022.06.11.02.23.33; Sat, 11 Jun 2022 02:23:48 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232284AbiFKIsB (ORCPT + 99 others); Sat, 11 Jun 2022 04:48:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57230 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231615AbiFKIre (ORCPT ); Sat, 11 Jun 2022 04:47:34 -0400 Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2D1F65F67 for ; Sat, 11 Jun 2022 01:47:34 -0700 (PDT) Received: from canpemm500002.china.huawei.com (unknown [172.30.72.56]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4LKryB44FLzgYGf; Sat, 11 Jun 2022 16:45:38 +0800 (CST) Received: from huawei.com (10.175.124.27) by canpemm500002.china.huawei.com (7.192.104.244) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Sat, 11 Jun 2022 16:47:30 +0800 From: Miaohe Lin To: CC: , , , , , , , , , , , Subject: [PATCH 6/7] mm/khugepaged: remove unneeded return value of khugepaged_add_pte_mapped_thp() Date: Sat, 11 Jun 2022 16:47:30 +0800 Message-ID: <20220611084731.55155-7-linmiaohe@huawei.com> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20220611084731.55155-1-linmiaohe@huawei.com> References: <20220611084731.55155-1-linmiaohe@huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7BIT Content-Type: text/plain; charset=US-ASCII X-Originating-IP: [10.175.124.27] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To canpemm500002.china.huawei.com (7.192.104.244) X-CFilter-Loop: Reflected X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The return value of khugepaged_add_pte_mapped_thp() is always 0 and also ignored. Remove it to clean up the code. Signed-off-by: Miaohe Lin --- mm/khugepaged.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/mm/khugepaged.c b/mm/khugepaged.c index 142e26e4bdbf..ee0a719c8be9 100644 --- a/mm/khugepaged.c +++ b/mm/khugepaged.c @@ -1372,7 +1372,7 @@ static void collect_mm_slot(struct mm_slot *mm_slot) * Notify khugepaged that given addr of the mm is pte-mapped THP. Then * khugepaged should try to collapse the page table. */ -static int khugepaged_add_pte_mapped_thp(struct mm_struct *mm, +static void khugepaged_add_pte_mapped_thp(struct mm_struct *mm, unsigned long addr) { struct mm_slot *mm_slot; @@ -1384,7 +1384,6 @@ static int khugepaged_add_pte_mapped_thp(struct mm_struct *mm, if (likely(mm_slot && mm_slot->nr_pte_mapped_thp < MAX_PTE_MAPPED_THP)) mm_slot->pte_mapped_thp[mm_slot->nr_pte_mapped_thp++] = addr; spin_unlock(&khugepaged_mm_lock); - return 0; } static void collapse_and_free_pmd(struct mm_struct *mm, struct vm_area_struct *vma, -- 2.23.0