Received: by 2002:a5d:925a:0:0:0:0:0 with SMTP id e26csp218048iol; Sat, 11 Jun 2022 02:33:37 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyo9dVuinTC4sfbjOYMnA4xXeIPSrAjpUe5mkvPqxe8b33jT4XZGmMPGXd0iHDbGhAfu3Pe X-Received: by 2002:a65:6745:0:b0:3fd:fd52:85bc with SMTP id c5-20020a656745000000b003fdfd5285bcmr21140842pgu.350.1654940017708; Sat, 11 Jun 2022 02:33:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1654940017; cv=none; d=google.com; s=arc-20160816; b=YiJL3sFXKwFFaABeVhiok6khzt3bF3i4FiUep6pymuzbzWlqyG7W1d33jgUoxaY0Qw /7X27aCWD7CXJur+Wj08u92/t7n7eyOEX5rvFxv1HWS4iTP/9LRWJgVLbdmyPWjiNG20 bPCXCyMb4r/fLDExh9HwBPl27WmezUxVWcB2PZF85gNZEH3CLesvOrhV1rMzZAbsGti1 9/25jczHbJUAbVnnhqMP9/1P2TrrurxaWDG7dKcw9Q8+IqNdyhNWcfCekOasGrz7lAvS 3Z0h0XRIte7wz2LSQh7ju98jF+tMOOOnijddNfTHWq+oUHFwh6GNVl1TNxX6jw4SUk4g ayCg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=3GFcFwqnFGmcRNmokcZ6QcxITcGcLvGSBnxe2xUhRi8=; b=ca0xmQxfuvKYUCSO6B2wm/q35JotYiYvTvrOEPupUZp+6fObkR0dQWY0ZVLbOwlGbT SpXjvXkBHaXGBz7iXA03CNm8t/UC4Nt+mWsEiAsCLPWLyZ+Zzf5cTAcQQKb8cafDKoKT gjOM96gvUFEjsLl33QtlKNbPniDYnISWOdXx6HeiNWl+1aJonkh91lrxfxFEMUQuX4xy Y3nvLZgjv80UEvbShPCCKkXTR3pzOozsXbpvwu7iQPKn9jBo4NGgiXKW/HaQ3AYIDVU4 1Q2bQPhC24Pv84iSRAT1BzLkk3o/7FEmqFhh4+0trCHoeRlpYwKQtXsOs2r1e89EGntv /+Hg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=IhYK9SJr; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id o15-20020a170902d4cf00b0016784c7b21csi2451483plg.342.2022.06.11.02.33.25; Sat, 11 Jun 2022 02:33:37 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=IhYK9SJr; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229744AbiFKGBJ (ORCPT + 99 others); Sat, 11 Jun 2022 02:01:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42242 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229699AbiFKGBF (ORCPT ); Sat, 11 Jun 2022 02:01:05 -0400 Received: from mail-pj1-x102d.google.com (mail-pj1-x102d.google.com [IPv6:2607:f8b0:4864:20::102d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 201D2639A for ; Fri, 10 Jun 2022 23:01:02 -0700 (PDT) Received: by mail-pj1-x102d.google.com with SMTP id mh16-20020a17090b4ad000b001e8313301f1so4627317pjb.1 for ; Fri, 10 Jun 2022 23:01:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=3GFcFwqnFGmcRNmokcZ6QcxITcGcLvGSBnxe2xUhRi8=; b=IhYK9SJrhXq+qv1WiqB9FLLyFfKRj6/LONo25ON2I+xiq7D8kxxiuRj370SIb/01Km 4gLaz5vOJBdR/vDD8jKvcf0cfGJsH0IormapMgd6vYFQTTxeSk0C9taU8BoZGD4Jj5fa 4u6bRx3oHK3wCWS/+jm6BcndC/WKUqku29P2Q= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=3GFcFwqnFGmcRNmokcZ6QcxITcGcLvGSBnxe2xUhRi8=; b=zHoEEdE4NkwR1LbGk6k2wIzG1TWXh61bd8Qr5JtMgZv0aEiCLrEpHmCJBa6pl93SJw fsmGGWcustUnkglp2QpDCMhJqX7Qr5nWZXS0zKrbFWWK1WdpD3Ixuzja6m3CiEVslZfk PSlkQc5dSRL+u3mGqlfJahxvhCcW2myiVmMjGFV9X+lsu95OdYUjurPGXwqVGB+Xvrab uJ/ZCrVxuEgekNCFbQnrrYMZCupzlYVoMuX3hB88sNczv0/t2vtDxpJi5nVDe5U2Npw/ E1i0DI2fvVxNvRQyJuM2bbJ+mqog3bIU5awkIpRxQ0k5JGHM/2XdftisxpAorzhcrqxu xucQ== X-Gm-Message-State: AOAM530Lk4I+FxtniXc9jxYRQ5Jkg3fCwk5OcrsEibr/ZxGP0IN7PfPK ox63opnh7lyBK4ywRM+s5ZZQdQ== X-Received: by 2002:a17:902:7611:b0:168:cb95:fd27 with SMTP id k17-20020a170902761100b00168cb95fd27mr1051867pll.126.1654927261517; Fri, 10 Jun 2022 23:01:01 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id a7-20020a1709027e4700b00168b4b550f2sm726508pln.54.2022.06.10.23.01.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Jun 2022 23:01:00 -0700 (PDT) Date: Fri, 10 Jun 2022 23:01:00 -0700 From: Kees Cook To: Sami Tolvanen Cc: linux-kernel@vger.kernel.org, Josh Poimboeuf , Peter Zijlstra , x86@kernel.org, Catalin Marinas , Will Deacon , Mark Rutland , Nathan Chancellor , Nick Desaulniers , Joao Moreira , Sedat Dilek , Steven Rostedt , linux-hardening@vger.kernel.org, linux-arm-kernel@lists.infradead.org, llvm@lists.linux.dev Subject: Re: [RFC PATCH v3 07/20] lkdtm: Emit an indirect call for CFI tests Message-ID: <202206102300.26A43F5D8@keescook> References: <20220610233513.1798771-1-samitolvanen@google.com> <20220610233513.1798771-8-samitolvanen@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220610233513.1798771-8-samitolvanen@google.com> X-Spam-Status: No, score=-3.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jun 10, 2022 at 04:35:00PM -0700, Sami Tolvanen wrote: > Clang can convert the indirect calls in lkdtm_CFI_FORWARD_PROTO into > direct calls. Move the call into a noinline function that accepts the > target address as an argument to ensure the compiler actually emits an > indirect call instead. > > Signed-off-by: Sami Tolvanen Acked-by: Kees Cook -- Kees Cook