Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Dongli Zhang <dongli.zhang@oracle.com>
To:     iommu@lists.linux-foundation.org, linux-doc@vger.kernel.org,
        x86@kernel.org
Cc:     linux-kernel@vger.kernel.org, joe.jin@oracle.com,
        hch@infradead.org, m.szyprowski@samsung.com, tglx@linutronix.de,
        mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com,
        corbet@lwn.net
Subject: [PATCH v1 4/4] swiotlb: panic if nslabs is too small
Date:   Sat, 11 Jun 2022 01:25:14 -0700
Message-Id: <20220611082514.37112-5-dongli.zhang@oracle.com>
In-Reply-To: <20220611082514.37112-1-dongli.zhang@oracle.com>
References: <20220611082514.37112-1-dongli.zhang@oracle.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Vplc4T2Axtn6mYTFp7YasV4eXI3/CNm6yEBbl4E19qRsE4hCU2aif16A6GU/?=
 =?us-ascii?Q?AjAKriisQNkdnZavm0Sa0g6mHkCCbGDDqiv7QjE/wYyAS/ffXDSe1g2KOdl8?=
 =?us-ascii?Q?SSZw5++VRlo9tK4mtfR15TwlwMvy5oCEx2GAk0Z0fSw3KCZ/TkUcqf+0+awq?=
 =?us-ascii?Q?Fx/9KlxYehWG35aHyviinbKjlfRIy8cm6tR4+GahchZYuMXdTUyNLbD3hOYB?=
 =?us-ascii?Q?hOiBffEFDUTWdD8hGLMikewBAXFGvllaKqoqgwJ6eO1z4lpC9SR5beZi9BVX?=
 =?us-ascii?Q?9vcqr2RRjuE/3TmINEWbA+G00/IFaqomDvl8YbWVW2Dc3/FdMZNJnLADS/a3?=
 =?us-ascii?Q?Uu+j6iV4pkgVWHS/G7+RVudOcU/etfFv9PAySEOTWUnc7yCLv8B/5Nt/FT6L?=
 =?us-ascii?Q?8ITol80Xt1bHnuQzTJTAFRq6NwWvS+eEOkueEAy4aI1eoLvOpP8lLp8zYhZM?=
 =?us-ascii?Q?K07NMpovHa6I85M/j7Gslcl9sTjLa65qKjhfAdIbMETONk2ltMv6zDaqs9q+?=
 =?us-ascii?Q?+zsSWH1EKUFBJbo2urzOKwu6UtXg+ngc9ipANsx/RLs+5F4o9lz+Odh0kFsp?=
 =?us-ascii?Q?Ot+OuAgC7m65Mmdr12RziZT2y9tGj0MFFKgIYk7xxc+gZZR+w7aAaHmipDkE?=
 =?us-ascii?Q?v2cBytK7zPFtOhIvrRzAUkqTeSMjPb2Gdx2eI2CG8gqjGhYJBBpg9HuHuCuu?=
 =?us-ascii?Q?VrgSeJRwu7ocFK3iCP5eYQjyTC4yRi6Wi7vCbeFPfFDmcHveHpuB13Ftdyy/?=
 =?us-ascii?Q?h21V1ck1gJdOXUZ1AwqMxU53/P4DiKx8VcSfu9q6ogGcI2mhioIRfYrSkjMU?=
 =?us-ascii?Q?Q2sdDC5PPGF8qnx4tBdNSuN1fGz8iX8xSMMS4HYx9Qbob3gbWtZ8tu2/tJKd?=
 =?us-ascii?Q?g6z7Py/cbznhT9i8qnpgyVwTz5mbVDAI01GFRYnivafTG1g7DIW0ANoeqzcx?=
 =?us-ascii?Q?RwwThrLlnv41Fb+r1qXPmubX9MnX11hWppI3sRX0PmiWz1fKkS9f0Xk2VDKm?=
 =?us-ascii?Q?9bf1TKcR0uBiLqP22yeK423r1PjRmiZZOASavav61dhcBSi0iIIotIptguW4?=
 =?us-ascii?Q?A5tcrrVOU9op8dtsy60rfAND7B3wNNoW1xB5za8+OhfCckOHEASFUCTbSJoX?=
 =?us-ascii?Q?iyIzwuP+Ms1TdfXjVhEWA+oue/CqZGJ5VTPX6OjtDFu+UtGXFD0EJuWWGjuT?=
 =?us-ascii?Q?AvtyF1VXF5swZL4+TupZbkE8oojyJvoYXyWXvYM5hqUz2e1z+zJUpQrZTZcA?=
 =?us-ascii?Q?Z3P6iKU2TZ17xRwDYPklW89emaYG173xVcN46IOvgFTUxfW6tkZBfqDwmT8O?=
 =?us-ascii?Q?TZ/cV1ysiPDF70Cc+mABKpRwi2l8rWFDOoo+O68krQx9bv+19qEsLeMakmde?=
 =?us-ascii?Q?RBQTtW2CBCmkzeo2AU9oYKkeijzWwoCsQIB0ThRljSEjI3XLCypdGnPGnpOG?=
 =?us-ascii?Q?yrqHRRZjnONgLN223uVMNIQj28tyceKhAcZn7rAGb87+WJt+CJs9TJ2QSuCa?=
 =?us-ascii?Q?YB//x5+dfE4nB8DgfctJEJ9yQC2E+YEucZy+yn6ixrsljVx/l+2A/lVnNG4l?=
 =?us-ascii?Q?It0ILfHEV7gStQrVD+fitDaCSPnX7wfgwEwjVpW0nCXN7nbF1xFA9b62Jg2u?=
 =?us-ascii?Q?XeCD0nCjDoJD2MuxSozpZVLggRevsildUD0aMpwVl2vPzkV8P6uZhbiQm1ls?=
 =?us-ascii?Q?0eG8CfHHp97rCOxnt6rI4HCihsPw9KdNgskZk2ABpD68rScaY6oAsbiK+UOp?=
 =?us-ascii?Q?Kwt9325vLCYdrgZbqNnSxZrGC+oUUfk=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 185145fa-c430-475d-7f3d-08da4b83f746
X-MS-Exchange-CrossTenant-AuthSource: BYAPR10MB2663.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jun 2022 08:25:38.9300
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: iomXJeXny6bCxoavptsJvJJTVLrOOS0ngp3P+gE1GkUYWQL/DHyxGRSm8Wi+vOOB9A2JY/lJi8/axXCjggkpzA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR10MB2945
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.517,18.0.874
 definitions=2022-06-11_03:2022-06-09,2022-06-11 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 suspectscore=0
 mlxlogscore=999 adultscore=0 mlxscore=0 malwarescore=0 spamscore=0
 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2204290000 definitions=main-2206110032
X-Proofpoint-GUID: eUpcJ-iOAbARGOOjd4axl89SnuOWizF9
X-Proofpoint-ORIG-GUID: eUpcJ-iOAbARGOOjd4axl89SnuOWizF9
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Panic on purpose if nslabs is too small, in order to sync with the remap
retry logic.

In addition, print the number of bytes for tlb alloc failure.

Signed-off-by: Dongli Zhang <dongli.zhang@oracle.com>
---
 kernel/dma/swiotlb.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/kernel/dma/swiotlb.c b/kernel/dma/swiotlb.c
index fd21f4162f4b..1758b724c7a8 100644
--- a/kernel/dma/swiotlb.c
+++ b/kernel/dma/swiotlb.c
@@ -242,6 +242,9 @@ void __init swiotlb_init_remap(bool addressing_limit, unsigned int flags,
 	if (swiotlb_force_disable)
 		return;
 
+	if (nslabs < IO_TLB_MIN_SLABS)
+		panic("%s: nslabs = %lu too small\n", __func__, nslabs);
+
 	/*
 	 * By default allocate the bounce buffer memory from low memory, but
 	 * allow to pick a location everywhere for hypervisors with guest
@@ -254,7 +257,8 @@ void __init swiotlb_init_remap(bool addressing_limit, unsigned int flags,
 	else
 		tlb = memblock_alloc_low(bytes, PAGE_SIZE);
 	if (!tlb) {
-		pr_warn("%s: failed to allocate tlb structure\n", __func__);
+		pr_warn("%s: Failed to allocate %zu bytes tlb structure\n",
+			__func__, bytes);
 		return;
 	}
 
-- 
2.17.1