Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sat, 11 Jun 2022 17:31:03 +0800
From:   Shawn Guo <shawnguo@kernel.org>
To:     Ulrich =?iso-8859-1?Q?=D6lmann?= <u.oelmann@pengutronix.de>
Cc:     Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Sascha Hauer <s.hauer@pengutronix.de>,
        NXP Linux Team <linux-imx@nxp.com>,
        Fabio Estevam <festevam@gmail.com>,
        Pengutronix Kernel Team <kernel@pengutronix.de>,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        Oleksij Rempel <o.rempel@pengutronix.de>,
        Juergen Borleis <jbe@pengutronix.de>,
        Michael Grzeschik <m.grzeschik@pengutronix.de>,
        Marco Felsch <m.felsch@pengutronix.de>,
        Lucas Stach <l.stach@pengutronix.de>,
        =?iso-8859-1?Q?S=F8ren?= Andersen <san@skov.dk>,
        Sam Ravnborg <sam@ravnborg.org>
Subject: Re: [PATCH] ARM: dts: imx6: skov: add pwm-regulator to control the
 panel's VCOM
Message-ID: <20220611093103.GI254723@dragon>
References: <20220517071814.3626702-1-u.oelmann@pengutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20220517071814.3626702-1-u.oelmann@pengutronix.de>
Precedence: bulk

On Tue, May 17, 2022 at 09:18:14AM +0200, Ulrich ?lmann wrote:
> Skov's i.MX6 based boards come in different flavors which have different panels
> attached. For optimal contrast experience each panel type needs an individual
> common voltage (VCOM) to drive its TFT backplane. The latter is generated by an
> LCD bias supply IC controlled by a pwm as input signal. Introduce a pwm-
> regulator to describe this hardware property and parameterize it appropriately
> for the different boards.
> 
> Signed-off-by: Ulrich ?lmann <u.oelmann@pengutronix.de>
> ---
>  arch/arm/boot/dts/imx6q-skov-reve-mi1010ait-1cp1.dts |  6 ++++++
>  arch/arm/boot/dts/imx6qdl-skov-cpu.dtsi              | 10 ++++++++++
>  2 files changed, 16 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/imx6q-skov-reve-mi1010ait-1cp1.dts b/arch/arm/boot/dts/imx6q-skov-reve-mi1010ait-1cp1.dts
> index 7f1f19b74bfa..a3f247c722b4 100644
> --- a/arch/arm/boot/dts/imx6q-skov-reve-mi1010ait-1cp1.dts
> +++ b/arch/arm/boot/dts/imx6q-skov-reve-mi1010ait-1cp1.dts
> @@ -125,3 +125,9 @@ MX6QDL_PAD_EIM_D23__GPIO3_IO23		0x1b0b0
>  		>;
>  	};
>  };
> +
> +&reg_tft_vcom {
> +	regulator-min-microvolt = <3160000>;
> +	regulator-max-microvolt = <3160000>;
> +	voltage-table = <3160000 73>;
> +};
> diff --git a/arch/arm/boot/dts/imx6qdl-skov-cpu.dtsi b/arch/arm/boot/dts/imx6qdl-skov-cpu.dtsi
> index 77a91a97e6cf..3def1b621c8e 100644
> --- a/arch/arm/boot/dts/imx6qdl-skov-cpu.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl-skov-cpu.dtsi
> @@ -149,6 +149,16 @@ reg_can2_stby: regulator-can2-stby {
>  		gpio = <&gpio4 11 GPIO_ACTIVE_LOW>;
>  	};
>  
> +	reg_tft_vcom: regulator-tft-vcom {
> +		compatible = "pwm-regulator";
> +		pwms = <&pwm3 0 20000 0>;
> +		regulator-name = "tft_vcom";
> +		regulator-min-microvolt = <3600000>;
> +		regulator-max-microvolt = <3600000>;
> +		regulator-always-on;

You want it to be unmanaged and always-on?

Shawn

> +		voltage-table = <3600000 26>;
> +	};
> +
>  	reg_vcc_mmc: regulator-vcc-mmc {
>  		compatible = "regulator-fixed";
>  		pinctrl-names = "default";
> -- 
> 2.30.2
>