Received: by 2002:a5d:925a:0:0:0:0:0 with SMTP id e26csp393621iol; Sat, 11 Jun 2022 06:51:22 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyiT6lbfYOtEl8B3BWHr+3cDdnM0VSzO2Mt36rHKkgcJAzHO4aGSIURQDukR4zRld4fA3ah X-Received: by 2002:a63:788:0:b0:3fc:6922:704 with SMTP id 130-20020a630788000000b003fc69220704mr44013169pgh.6.1654955482704; Sat, 11 Jun 2022 06:51:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1654955482; cv=none; d=google.com; s=arc-20160816; b=wVIWkgTEogtYRFEMd19I5O06qbk644nNSK//d6VmQGMtbuiAmjprEhgB1u1PjVoGJJ UZ3MpkHoU3oGTb6DbKlSTqgY8xlzGYQ0ODlAHso2Jzs6Dr5NzEpsPBly3TPjzp7IjWEx 4F8rAbe7xcYX3oNWdTtMZ0uTNPHGwzeyn055bmbxs5fu+RMoeaEJN450YhCN3VXCzxPX SHAxG3IIjUu3G45TUzXUaDXfJu9ImX/ceplBYJG4U/5cHh1r207Xxx4KHVcLHonkIayA lrz8pmDw1RN5dG3Ld4Df3ZQcLRQEckL1m8iOWa9afflZWRU6CyTAhVjRpVj2S7N0Anx+ Bnnw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=Wlcsw5qD8PfGU15nnW09KK/BVP7r8f7rc1SV3lLroqU=; b=c4Pn+fANtr/yN4xyTbJLNRKNH712JAqJYQYJF/uGPuEBulyU/Xnpzg0hSqN8GREijF o5i+FgXUYSMXNdNJbqsHGbt0z0oOw0LlTFOGW1gIuNx0KJBX8oK17PcN06v47BgtrMz0 xMUx81deMvPF1MPSPAtnv+rIZoS0RPvO/8tlJdtogWFSTALfO8OOkYv2S5GUzuubn7vs w9zrx+rY5pcj4xpaKATmteZM56BJC8+wWWQ3URGZyhLtD6/5zuFwf+8ljAQRkC4hnx+l TFAEvT8uP0qx+jGbNzxdq6h4Bd7/TBcSY/P3XbucpGXbhM02uO2MOQKAg8HH96xwDBkm u8Uw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id p10-20020a170902e74a00b00161f0ac7250si3297830plf.276.2022.06.11.06.51.09; Sat, 11 Jun 2022 06:51:22 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233291AbiFKMb6 (ORCPT + 99 others); Sat, 11 Jun 2022 08:31:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59156 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232681AbiFKMbs (ORCPT ); Sat, 11 Jun 2022 08:31:48 -0400 Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DE9B76273; Sat, 11 Jun 2022 05:31:45 -0700 (PDT) Received: from dggemv703-chm.china.huawei.com (unknown [172.30.72.57]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4LKxwv0dHhzgYgx; Sat, 11 Jun 2022 20:29:51 +0800 (CST) Received: from kwepemm600016.china.huawei.com (7.193.23.20) by dggemv703-chm.china.huawei.com (10.3.19.46) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Sat, 11 Jun 2022 20:31:44 +0800 Received: from localhost.localdomain (10.67.165.24) by kwepemm600016.china.huawei.com (7.193.23.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Sat, 11 Jun 2022 20:31:43 +0800 From: Guangbin Huang To: , CC: , , , , Subject: [PATCH net 2/6] net: hns3: don't push link state to VF if unalive Date: Sat, 11 Jun 2022 20:25:25 +0800 Message-ID: <20220611122529.18571-3-huangguangbin2@huawei.com> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20220611122529.18571-1-huangguangbin2@huawei.com> References: <20220611122529.18571-1-huangguangbin2@huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7BIT Content-Type: text/plain; charset=US-ASCII X-Originating-IP: [10.67.165.24] X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To kwepemm600016.china.huawei.com (7.193.23.20) X-CFilter-Loop: Reflected X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jian Shen It's unnecessary to push link state to unalive VF, and the VF will query link state from PF when it being start works. Fixes: 18b6e31f8bf4 ("net: hns3: PF add support for pushing link status to VFs") Signed-off-by: Jian Shen Signed-off-by: Guangbin Huang --- drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c index fc0265b63331..2e891b837c51 100644 --- a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c +++ b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c @@ -3376,6 +3376,12 @@ static int hclge_set_vf_link_state(struct hnae3_handle *handle, int vf, link_state_old = vport->vf_info.link_state; vport->vf_info.link_state = link_state; + /* return success directly if the VF is unalive, VF will + * query link state itself when it starts work. + */ + if (!test_bit(HCLGE_VPORT_STATE_ALIVE, &vport->state)) + return 0; + ret = hclge_push_vf_link_status(vport); if (ret) { vport->vf_info.link_state = link_state_old; -- 2.33.0