Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sat, 11 Jun 2022 15:31:32 +0200
From:   Marc Kleine-Budde <mkl@pengutronix.de>
To:     Max Staudt <max@enpas.org>
Cc:     Vincent Mailhol <vincent.mailhol@gmail.com>,
        Wolfgang Grandegger <wg@grandegger.com>,
        linux-can@vger.kernel.org,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Oliver Neukum <oneukum@suse.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v7] can, tty: can327 CAN/ldisc driver for ELM327 based
 OBD-II adapters
Message-ID: <20220611133132.bqxlnqwp53qq6qor@pengutronix.de>
References: <20220602213544.68273-1-max@enpas.org>
 <CAMZ6RqLLn3tE6kPd+yyHURsbBU_jVKN=u4=YvhZVyAf_NyRqCQ@mail.gmail.com>
 <CAMZ6RqKM7Z3GzO6vKyWf7D1z=HvJBN2QaZz1==LBsEJKjz=Qag@mail.gmail.com>
 <20220611151649.5a9c5676.max@enpas.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="jrfniq2pzy2znubv"
Content-Disposition: inline
In-Reply-To: <20220611151649.5a9c5676.max@enpas.org>
Precedence: bulk


--jrfniq2pzy2znubv
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On 11.06.2022 15:16:49, Max Staudt wrote:
> On Sat, 4 Jun 2022 00:47:10 +0900
> Vincent Mailhol <vincent.mailhol@gmail.com> wrote:
>=20
> > > > +#define ELM327_CAN_CONFIG_SEND_SFF           0x8000
> > > > +#define ELM327_CAN_CONFIG_VARIABLE_DLC       0x4000
> > > > +#define ELM327_CAN_CONFIG_RECV_BOTH_SFF_EFF  0x2000
> > > > +#define ELM327_CAN_CONFIG_BAUDRATE_MULT_8_7  0x1000 =20
> >=20
> > This ELM327_CAN_CONFIG_BAUDRATE_MULT_8_7 macro is not used.
>=20
> True. It does document a flag in the ELM327 configuration registers
> though, and it was originally meant for adding 7/8 bitrates (e.g. 87500
> as a companion to 100000). I never got around to implementing those
> bitrates, though.
>=20
> I find opportunistic documentation helpful for future reference and
> to give casual readers hints - can I leave it in there anyway, or is it
> deemed an eyesore?

IMHO leave it in the driver.

regards,
Marc

--=20
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |

--jrfniq2pzy2znubv
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEBsvAIBsPu6mG7thcrX5LkNig010FAmKkmTEACgkQrX5LkNig
012h1QgArRe6Ygprzy/rsgBoX66oIX4v1SxjMrPdlWyVML0O/vf6sAB/Th1Ujp4/
baciutN59F4rlC5D6bAP4n2UUKTBWiUAdNpa/sV/eKKr5AQGWEKxWIqHcOsuFBDc
LlQh0/UitfSFtjUGHeJxUjqHUjKxJnNuRGCgRf+iD4O9M7bgwOH2y3RM7ddrke0p
22qVHJ/dT1/Lc7jF6gMEZPAsOiDqvC1l3PswcBXwE9ea1N9wka0eIRPtLaH16MZN
/2UPlH4kf1knS6P73LTFt2ooWNGze3ff9gQJoSiGqNOGJWpCWX4TmPNtzcqHGwtm
N6uj88rAOwikrggsjEQO+jjSOwhZMg==
=edMq
-----END PGP SIGNATURE-----

--jrfniq2pzy2znubv--