Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sat, 11 Jun 2022 15:36:08 +0200
From:   Marc Kleine-Budde <mkl@pengutronix.de>
To:     Max Staudt <max@enpas.org>
Cc:     Vincent Mailhol <vincent.mailhol@gmail.com>,
        Wolfgang Grandegger <wg@grandegger.com>,
        linux-can@vger.kernel.org,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Oliver Neukum <oneukum@suse.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v7] can, tty: can327 CAN/ldisc driver for ELM327 based
 OBD-II adapters
Message-ID: <20220611133608.3zdfb3nnl5445kr7@pengutronix.de>
References: <20220602213544.68273-1-max@enpas.org>
 <CAMZ6RqLLn3tE6kPd+yyHURsbBU_jVKN=u4=YvhZVyAf_NyRqCQ@mail.gmail.com>
 <20220611151551.5024f51e.max@enpas.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="5edtfo4qnqqn26om"
Content-Disposition: inline
In-Reply-To: <20220611151551.5024f51e.max@enpas.org>
Precedence: bulk


--5edtfo4qnqqn26om
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On 11.06.2022 15:15:51, Max Staudt wrote:
> @Marc, Wolfgang - one SocketCAN design question about bitrate setting at
> the end. I'd appreciate your opinion on my dummy do_set_bittiming().

[...]

> > > +/* Dummy needed to use bitrate_const */
> > > +static int can327_do_set_bittiming(struct net_device *netdev)
> > > +{
> > > +       return 0;
> > > +} =20
> >=20
> > Is this dummy function really needed? If think that access to
> > can_priv::do_set_bittiming is always garded. Setting it to NULL should
> > be OK. c.f.:
> > https://elixir.bootlin.com/linux/latest/source/drivers/net/can/dev/netl=
ink.c#L198
>=20
> drivers/net/can/dev/netlink.c - can_changelink():
>=20
> 	/* Calculate bittiming parameters based on
> 	 * bittiming_const if set, otherwise pass bitrate
> 	 * directly via do_set_bitrate(). Bail out if neither
> 	 * is given.
> 	 */
> 	if (!priv->bittiming_const && !priv->do_set_bittiming)
> 		return -EOPNOTSUPP;
>=20
> can327 has neither of these two, so I provide a dummy for one.
>=20
> What should I do instead?

What about this change?

diff --git a/drivers/net/can/dev/netlink.c b/drivers/net/can/dev/netlink.c
index 7633d98e3912..667ddd28fcdc 100644
--- a/drivers/net/can/dev/netlink.c
+++ b/drivers/net/can/dev/netlink.c
@@ -176,7 +176,8 @@ static int can_changelink(struct net_device *dev, struc=
t nlattr *tb[],
                 * directly via do_set_bitrate(). Bail out if neither
                 * is given.
                 */
-               if (!priv->bittiming_const && !priv->do_set_bittiming)
+               if (!priv->bittiming_const && !priv->do_set_bittiming &&
+                   !priv->bitrate_const)
                        return -EOPNOTSUPP;
=20
                memcpy(&bt, nla_data(data[IFLA_CAN_BITTIMING]), sizeof(bt));

If it works I'll make a patch and apply it to net-next/master so that
you can base your series on this.

> While at it, a comment in elm327_init mentioned bittiming_const - that
> was from the pre-bitrate_const (< v4.11) times, and I've now updated it
> to mention bitrate_const instead.

regards,
Marc

--=20
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |

--5edtfo4qnqqn26om
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEBsvAIBsPu6mG7thcrX5LkNig010FAmKkmkUACgkQrX5LkNig
011eDgf7BAiZK/sQ02v4VkaRbtTc7AzHRodPZZJGQMfwJTPwsix2ExBYkUpVwXeZ
QTKUcIK2cVWiojidYmWXeuS7uHu62y9smz2PwjZuUg1etbeRxfG3V/o9am3DOLnv
mHFeaTMxVLij01BW6GI4vVqbvW9m9uyZmF/I3pKZJVNFZ+X2VX2I2knKHyuFV2oD
e59UOlIvSytJ7xEZn9dU4xSRgtMUX9yxBHe//M8Zq6DaRldf8jZ0fzJMzZcdbjg+
Kd04UgB8Yo33P9n4eDz9HEpkdgoJKBkb7Bq+PGw/DXA9vP0YUcCYYS4zevRqKbo0
u+sIue7VyQj54MuSJEo7xkU2ukKWJQ==
=lJBy
-----END PGP SIGNATURE-----

--5edtfo4qnqqn26om--