Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220611065300.885212-1-frattaroli.nicolas@gmail.com>
In-Reply-To: <20220611065300.885212-1-frattaroli.nicolas@gmail.com>
From:   Peter Geis <pgwipeout@gmail.com>
Date:   Sat, 11 Jun 2022 09:50:54 -0400
Message-ID: <CAMdYzYpvtZf8q+7Fon-nj=XbjZ-XQdD-bnY0mdaBxELVad2Cgg@mail.gmail.com>
Subject: Re: [PATCH v3 0/2] HDMI Audio on RK356x/Quartz64 Model A
To:     Nicolas Frattaroli <frattaroli.nicolas@gmail.com>
Cc:     Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Heiko Stuebner <heiko@sntech.de>,
        Michael Riesch <michael.riesch@wolfvision.net>,
        Sascha Hauer <s.hauer@pengutronix.de>,
        Liang Chen <cl@rock-chips.com>,
        devicetree <devicetree@vger.kernel.org>,
        arm-mail-list <linux-arm-kernel@lists.infradead.org>,
        "open list:ARM/Rockchip SoC..." <linux-rockchip@lists.infradead.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Sat, Jun 11, 2022 at 2:53 AM Nicolas Frattaroli
<frattaroli.nicolas@gmail.com> wrote:
>
> This enables HDMI audio on Quartz64 Model A, and the RK356x SoC in
> general.
>
> i2s0 on the RK356x is connected to HDMI, and only has one DMA. I've
> confirmed this with the TRM.
>
> To test this, one needs a video clock, i.e. there is no audio if your
> screen is off. The framebuffer console or something else needs to be
> running to get audio output.

Excellent work!
Tested on Quartz64 Model A.
Tested-by: Peter Geis <pgwipeout@gmail.com>

>
> Changes in v3:
>  - rebased onto next-20220610
>
> Changes in v2:
>  - reordered nodes in rk356x.dtsi to conform
>  - reordered properties in rk356x.dtsi to conform
>  - add Michael Riesch's Tested-by to rk356x.dtsi
>
> Nicolas Frattaroli (2):
>   arm64: dts: rockchip: rk356x: Add HDMI audio nodes
>   arm64: dts: rockchip: Enable HDMI audio on Quartz64 A
>
>  .../boot/dts/rockchip/rk3566-quartz64-a.dts   |  8 +++++
>  arch/arm64/boot/dts/rockchip/rk356x.dtsi      | 33 +++++++++++++++++++
>  2 files changed, 41 insertions(+)
>
> --
> 2.36.1
>