Message-ID: <465236EF.40102@redhat.com>
Date: Mon, 21 May 2007 19:18:55 -0500
From: Eric Sandeen <sandeen@redhat.com>
User-Agent: Thunderbird 2.0.0.0 (Macintosh/20070326)
MIME-Version: 1.0
To: Andrew Morton <akpm@linux-foundation.org>
CC: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
       Tejun Heo <htejun@gmail.com>, Maneesh Soni <maneesh@in.ibm.com>,
       stable@kernel.org
Subject: Re: [stable] [PATCH] - fix oops in sysfs_readdir
References: <4651E0C9.3080609@redhat.com> <20070521153935.b549db8f.akpm@linux-foundation.org>
In-Reply-To: <20070521153935.b549db8f.akpm@linux-foundation.org>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1689
Lines: 37

Andrew Morton wrote:
> On Mon, 21 May 2007 13:11:21 -0500
> Eric Sandeen <sandeen@redhat.com> wrote:
> 
>> This is a non-ida backport of Tejun's patch in -mm at:
>> ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.22-rc1/2.6.22-rc1-mm1/broken-out/gregkh-driver-sysfs-allocate-inode-number-using-ida.patch
>> for the 2.6.16 -stable tree - it follows the same scheme of using s_ino to safely
>> store & retrieve the inode number of sysfs entries for use in sysfs_readdir,
>> but uses a brain-dead-simple inode nr allocator rather than ida, which would
>> bring along a lot of newer, more complex code.
>>
>> No, this doesn't guarantee uniqueness of sysfs inode numbers, but then
>> the code in -stable today doesn't either - and with this change, at least
>> it shouldn't oops.
> 
> So I'm sitting here whether to commend this patch to google kernel maintainers
> for 2.6.18 backport, but I realise I don't know what it does.  And I don't know
> if it fixes the reclaim-time oopses they were intermittently seeing, or if it
> fixes something else and if so what that is.
> 
> Sigh.  Better changelogs, please.
> 

Sorry Andrew.  I referenced Tejun's upstream patch in -mm which has a 
nice changelog etc, and this is a backport of that, and does the same 
thing in the same way and solves the same problem - but that doesn't 
help if you just want to toss this message into your patch stack.  Will 
fix up & resend.

-Eric

-Eric
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/