Received: by 2002:a5d:925a:0:0:0:0:0 with SMTP id e26csp454866iol; Sat, 11 Jun 2022 08:17:48 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw4Yzj89Rqm6UWsXwwQLVYDPFULWfaZ2U7hHemXfSQvUFRY3U+LWMvhBDdHhlwyJyeMxsYU X-Received: by 2002:a17:906:4a83:b0:70b:156f:9098 with SMTP id x3-20020a1709064a8300b0070b156f9098mr45361859eju.109.1654960668334; Sat, 11 Jun 2022 08:17:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1654960668; cv=none; d=google.com; s=arc-20160816; b=ZzTwF7wUz4nqU8tWLBglCzAhLrDW3dkBn+TktM/sHDb7GVstDdpXC8GJT9deWVKYne GjKf2Z1a9AAYFs82lmksMHZ4ljRTy9C3Bn25mFDEKiKHhk8IbbaWyPsYt/VYhJjhC/vf B5cFEQcyDCVu/m5PQ3OQ/+J+M8GX8cj8Gj8ako09Co5lBl07fxkEI5CTYj4w5UYDWXn9 29wTwfCbOJSFhRkx2kWJ1PLWSn93ssKNDdlRxAlvE6hhSbZ4zPgo3vth7f0vLnciHIv2 MPI97rXyh4bhmWsBPemuUGEa5+3MNOcevpepLl74SoAt6JNN85SvObklx9AJrgTTirrI s8Vg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=EesJp6Q28Dva5LrN482KPkK1Tg2M3LLR40lrcCvgAAk=; b=lgRT9ShcUZe9iRXHXnjWFbcsGdinHd7S8RZ1rHzOTMQr0B6JgOmCzwRJoyjlBcuiTM Cdpu6oK9CWNSJjOORMKDK3KkZkpzuVndYiiQFs0DbBQuCQGtxdDXaDo26wIj0MQIBBa1 wB09TGmc1GOz13wCt9rwPPpKv0GCku6X1Fd0Wr+lUPowIUyHrvtdYDFt0OMeNz0yvCR0 9lGZrnfCiTZsdDAqTOTXbhIhrlFL3N4ECQjNs8Y6Tnjv0LE8jLWxXso5iUXoFcDkhm6y 6mSXTcPEDt2BdfgS0GH0SdQ2qOOKFxyJ+tPOqal9K2LMwgLfWxMau84vhlIhjiJBzQIH 3pJg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=WMGh50na; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id v6-20020a056402174600b0042da765d456si1975448edx.141.2022.06.11.08.17.24; Sat, 11 Jun 2022 08:17:48 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=WMGh50na; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236699AbiFKO4h (ORCPT + 99 others); Sat, 11 Jun 2022 10:56:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40290 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234101AbiFKO4g (ORCPT ); Sat, 11 Jun 2022 10:56:36 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 145BDB481 for ; Sat, 11 Jun 2022 07:56:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=EesJp6Q28Dva5LrN482KPkK1Tg2M3LLR40lrcCvgAAk=; b=WMGh50naDvnyC2S29Ju83tWUBS aEzMG9CJXl92X/gsKJ/OXv7EBMXs63k3gZkWiwavEUQAP2d24xo6/D3ReKv2dcJoMSMxQgQs+o0LD AILEIcXZRk1OZZZw2FukdV8MKv4UyBBjUXFoW3RBMqmC+Q3b4nP5ENAHg8qq9fTf1U0atiy33QZTm j6nsvfemD/IEUDObGwdIh5j8vLWLZTf9S0c/6EF7pqWiZLOZYVWBkO1+0QlkTk1g4HZeuC5Rv/uvi dSQex/M7UvtgSHsmkF0kYUapzwb+n+/qldIAldWSIhK0aQFSDCBn+0iJzhT3zhgmBD2f1436NUzR+ WW10RAjA==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1o02X8-00FJxM-7v; Sat, 11 Jun 2022 14:56:14 +0000 Date: Sat, 11 Jun 2022 15:56:14 +0100 From: Matthew Wilcox To: Zhangfei Gao Cc: Minchan Kim , John Hubbard , "Paul E . McKenney" , Andrew Morton , shameerali.kolothum.thodi@huawei.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm: fix is_pinnable_page return value Message-ID: References: <20220611133442.15290-1-zhangfei.gao@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220611133442.15290-1-zhangfei.gao@linaro.org> X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Jun 11, 2022 at 09:34:42PM +0800, Zhangfei Gao wrote: > Commit 1c563432588d ("mm: fix is_pinnable_page against a cma page") > Changes from > return !(is_zone_movable_page(page) || is_migrate_cma_page(page)) || > is_zero_pfn(page_to_pfn(page)); > to > return !(is_zone_movable_page(page) || is_zero_pfn(page_to_pfn(page))); Mailing lists can be read as well as written. https://lore.kernel.org/linux-mm/165490039431.944052.12458624139225785964.stgit@omen/