Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sat, 11 Jun 2022 17:16:06 +0200
From:   Andrew Lunn <andrew@lunn.ch>
To:     Oleksij Rempel <o.rempel@pengutronix.de>
Cc:     Heiner Kallweit <hkallweit1@gmail.com>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>, kernel@pengutronix.de,
        linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH net-next v3 3/3] net: phy: dp83td510: disable cable test
 support for 1Vpp PHYs
Message-ID: <YqSxtvZUEmaxmihV@lunn.ch>
References: <20220608123236.792405-1-o.rempel@pengutronix.de>
 <20220608123236.792405-4-o.rempel@pengutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220608123236.792405-4-o.rempel@pengutronix.de>
Precedence: bulk

>  static int dp83td510_cable_test_start(struct phy_device *phydev)
>  {
> -	int ret;
> +	struct dp83td510_priv *priv = phydev->priv;
> +	int ret, cfg = 0;
> +
> +	/* Generate 2.4Vpp pulse if HW is allowed to do so */
> +	if (priv->allow_v2_4_mode) {
> +		cfg |= DP83TD510E_TDR_TX_TYPE;
> +	} else {
> +		/* This PHY do not provide usable results with 1Vpp pulse.

s/do/does


> +		 * Potentially different dp83td510_tdr_init() values are
> +		 * needed.
> +		 */
> +		return -EOPNOTSUPP;
> +	}

I don't remember the details for v2.4. Is it possible to change up
from 1v to 2.4v for the duration of the cable test? Is there a danger
to damage the link peer? I guess not, since you need to pass EMC
testing which zaps it with 100Kv or something. So is this more a local
supply issue?

       Andrew