Received: by 2002:a5d:925a:0:0:0:0:0 with SMTP id e26csp492924iol; Sat, 11 Jun 2022 09:16:01 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyKS1b9X0tDfAeEjO/R2VtQtQ+ejzxdMhfo5oTuO7XgmMghaz6mc2E21bfT89HzhOybM5Yi X-Received: by 2002:a17:90b:4b10:b0:1e8:3609:7fc7 with SMTP id lx16-20020a17090b4b1000b001e836097fc7mr5799549pjb.150.1654964161641; Sat, 11 Jun 2022 09:16:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1654964161; cv=none; d=google.com; s=arc-20160816; b=d/gDRl/XK3Fuofm9To5AnMX2xqWqzKt+bq45chY8Jk51F3xlaB4NWq7szIEyt1zXjg k3Ym4aUN8SA1y6kEhCpV45ZZ1s6XbyeGJU4SsbdF13NiZPymRC2VU3nwWGMYbptfUxaK /Fuf8+UFDkCne2XQg/YIv0l9gig6c6m8P9i81VflXyBlGjHTW4gsF2cm9ONkNC4KoBri 3Ok44TKK6WshDX5nQZLtgptdDgILpjwbUrvnl1a72c1moJf/w/1mJZNJ/Etj1r3JKWzO eKXZCX2U8z8MDtadN7om+p5atScAI8nfJ5AySLoMGyeObCDfGZGrVWVYspC5p47RvoD/ TdQA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-language:content-transfer-encoding :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject:dkim-signature; bh=lsyXcbGVnnHp+ZTNPftnqBlou4cClChxNQXmkWFyJdY=; b=wGGR3T61Qfugejmzns3UJZ0Dr3kxL8BDyXdB+EPzKsPKoEO/rXO4QFzK4JEF8KW+LR ji5msqGoMTtqpzP2P5IRIJ9hF8Ws4AVCAFMyGwxpIFGbV8MljDuu5JthUls3dXhujyzQ 2ND2avrghUL6p4ogQS8ulU6yAXu7k8X9Un9v5AlvF9Q9E0nrmUdgAOdHRr4MJCtJlCoI KCCFL6qvivHDXpaqygJReMmqMui9D8Y5R4YEwD+m5aTarorjWeFlfD0DemyMJvk7eIT+ xuZs4VBJHdzfRFu/BlNCfKelHag3iB0UONRAaC1L2m8v0CSLqZmA3rVNOZH6ibzK3w0R MV0Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=nPcPHBg2; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id z9-20020a633309000000b003c2163cb9d1si2528125pgz.493.2022.06.11.09.15.49; Sat, 11 Jun 2022 09:16:01 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=nPcPHBg2; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238895AbiFKPt3 (ORCPT + 99 others); Sat, 11 Jun 2022 11:49:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44548 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233305AbiFKPt1 (ORCPT ); Sat, 11 Jun 2022 11:49:27 -0400 Received: from mail-pf1-x430.google.com (mail-pf1-x430.google.com [IPv6:2607:f8b0:4864:20::430]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 81CA62E8 for ; Sat, 11 Jun 2022 08:49:26 -0700 (PDT) Received: by mail-pf1-x430.google.com with SMTP id x138so1978037pfc.12 for ; Sat, 11 Jun 2022 08:49:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=lsyXcbGVnnHp+ZTNPftnqBlou4cClChxNQXmkWFyJdY=; b=nPcPHBg2LkXgICUCt2NPzN7d60V1Vh6guMz6DvIQ5NVBuAPZOv1UcCoUe7vLUqS3lr +RK9vgjy53GiYCoS1zFlK7ocFevJ5JhfAYV+7DYOMv/+lsX11UKUMknOAWBYEF54834p GkIw+PTm67eJRd0v+ZDJdscRwY6ZRg+Kahk1l/hNTNfyQS3z2B941AOrNRShZY59TBep ooTcQZF5CWUa6Y+i+2scykCeAQCNRuerXdmH/LUgOOjjoCNANa/OcX/HYnS8bCNTIXcy oCbpvRnwLPEHoXR9oyNVTF1Tgy/uGm4JDLoBkedBtCexnB2fj4zZwLB06SYNDglfQxTB 2KUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=lsyXcbGVnnHp+ZTNPftnqBlou4cClChxNQXmkWFyJdY=; b=n+P7tpyyWV1sL2dVFBCYr+B4XfhAnZfg1hSjVSjwbWot5tXCI1sIYZFXJ89eJB1eiV 6mPUzjhorLJsfNeOmk8uq1onMbAzyh6xzgjZ7CMa0DuA8Qexoq8jbi4VV7FfsqnSIOZM DuXlNfIs4bQJblnoyoCQb9nGMpPbxR3JX1nuEumbJOMIfk2d/F2iobCqbQLvK0BFVBmT j7LfrNh7KCV4fvYAbH4E09zRMk3nlsfw8rGq8cK2kqHQWBTjRGvRsoPlDykpxMVyOkxa Q8/QIJE6pnc90IdMe4GrU1HQHkO9PWWHqiLz7Pf0LXsJ6q/u025cVXMC9YeyMPFrT3iV kFdg== X-Gm-Message-State: AOAM531APwT+uIkBLb7ZFLReNjt2QtKIdW7xkv/Cq8GmPvM+dKm7oOMw wIRySr2xME2M+XZEk3efBrG0nwJw0jEzhw== X-Received: by 2002:a63:f242:0:b0:3fd:8a04:df6 with SMTP id d2-20020a63f242000000b003fd8a040df6mr31834881pgk.300.1654962565866; Sat, 11 Jun 2022 08:49:25 -0700 (PDT) Received: from [10.139.0.6] ([199.101.192.70]) by smtp.gmail.com with ESMTPSA id n6-20020a17090a928600b001df239bab14sm1609621pjo.46.2022.06.11.08.49.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 11 Jun 2022 08:49:25 -0700 (PDT) Subject: Re: [PATCH] mm: fix is_pinnable_page return value To: Matthew Wilcox Cc: Minchan Kim , John Hubbard , "Paul E . McKenney" , Andrew Morton , shameerali.kolothum.thodi@huawei.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20220611133442.15290-1-zhangfei.gao@linaro.org> From: Zhangfei Gao Message-ID: <9379fcb3-43c8-d13d-a425-a55204380db9@linaro.org> Date: Sat, 11 Jun 2022 23:49:11 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-Spam-Status: No, score=-3.3 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2022/6/11 下午10:56, Matthew Wilcox wrote: > On Sat, Jun 11, 2022 at 09:34:42PM +0800, Zhangfei Gao wrote: >> Commit 1c563432588d ("mm: fix is_pinnable_page against a cma page") >> Changes from >> return !(is_zone_movable_page(page) || is_migrate_cma_page(page)) || >> is_zero_pfn(page_to_pfn(page)); >> to >> return !(is_zone_movable_page(page) || is_zero_pfn(page_to_pfn(page))); > Mailing lists can be read as well as written. > > https://lore.kernel.org/linux-mm/165490039431.944052.12458624139225785964.stgit@omen/ Oops, I am stucked in debugging the qemu hung issue, not noticed it has been fixed. Thanks Matthew.