Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sat, 11 Jun 2022 08:53:34 -0700
From:   Colin Foster <colin.foster@in-advantage.com>
To:     Andy Shevchenko <andy.shevchenko@gmail.com>
Cc:     devicetree <devicetree@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        netdev <netdev@vger.kernel.org>,
        linux-arm Mailing List <linux-arm-kernel@lists.infradead.org>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
        Vladimir Oltean <vladimir.oltean@nxp.com>,
        Lee Jones <lee.jones@linaro.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Andrew Lunn <andrew@lunn.ch>,
        Heiner Kallweit <hkallweit1@gmail.com>,
        Russell King <linux@armlinux.org.uk>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Lars Povlsen <lars.povlsen@microchip.com>,
        Steen Hegelund <Steen.Hegelund@microchip.com>,
        Microchip Linux Driver Support <UNGLinuxDriver@microchip.com>,
        Linus Walleij <linus.walleij@linaro.org>,
        Wolfram Sang <wsa@kernel.org>,
        Terry Bowman <terry.bowman@amd.com>
Subject: Re: [PATCH v9 net-next 1/7] mfd: ocelot: add helper to get regmap
 from a resource
Message-ID: <20220611155334.GA848433@euler>
References: <20220610175655.776153-1-colin.foster@in-advantage.com>
 <20220610175655.776153-2-colin.foster@in-advantage.com>
 <CAHp75VfHG7pqvTLcBu=vqx9PzXVrJhxyu6XHr9xaiMmhqke-Tg@mail.gmail.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAHp75VfHG7pqvTLcBu=vqx9PzXVrJhxyu6XHr9xaiMmhqke-Tg@mail.gmail.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?0HHFvRVJHmWpDWbEZYSkt+5OHU+d249t8mM2kPMx6UFWAYG6TyhVKpa3XTgq?=
 =?us-ascii?Q?lkxrihRR2p0JxSRHpHCU0eHbMhmk0BkBfeHTVxEfevuXqwcqMPD3cKPqjFec?=
 =?us-ascii?Q?ivIDGua7XcGun5p07i+CfTEF98qfDZHw0vMjdMrhru23fhLp/+bTC9NaN0/i?=
 =?us-ascii?Q?EK1hCV7qSBJhZuimr8Rse5fTkJu69RIRtCT4SyEMNuOtYlaiRP7rBgya/wwa?=
 =?us-ascii?Q?27XH4vg8h6Q1M3zYwZBeCBeIaIZxsvUCq7P0uEWfavqwMtdtWc4wFRQD0iFA?=
 =?us-ascii?Q?DGp8iUs0aFN5gO/JhWcjKE3unv7v4dsPh8yhnDqKBGLWX8/6AhTeV9UewXmZ?=
 =?us-ascii?Q?01TWACmZ/FvALOxhoi/fyp9ZthQFjSy+pY9l8Q+XElk+LmpipqLWgFYabxfE?=
 =?us-ascii?Q?R/Gv+ooHrhpc8zh6lGI/n4x0rtUJoycIggi4uqBCXmczZ2/iwf9IcsUFMftQ?=
 =?us-ascii?Q?cc/d4QoSegmuXgPpjMY4M20JmuT5RqkqSNvPswiTKKuDFfHzP2kuxFrTH9YY?=
 =?us-ascii?Q?SUNbK9lGKSODsdx7bDffcy8s53Tw34U9O6DaztAjN1WGpbchbetnTNC8bqg1?=
 =?us-ascii?Q?4/WRRn6zdnnhYAUYhDEhJ8NDVyIeoofuNU2Y/RKdqQwjj0/1PN4npXHlYk4X?=
 =?us-ascii?Q?vSvRXLgQ+jLcxlwTAYOK8OpnengDP7ho1PPcDUqZ0Pk+ojkTM0EMNewxkAUj?=
 =?us-ascii?Q?/0ue48sXLUiqO8cH6n5aCobIhT33qopEOV4twow48QspUUCaZstbsUQm78Sh?=
 =?us-ascii?Q?385R8d4r5zgxh+mnSrPnTvUWTWlog1tNJhLB30YfO0t5i0UuKn43XN99TYPs?=
 =?us-ascii?Q?5kBByL2kSxtyCny87AhxlMha/24rxTW8+JjwOQsZDeLPFaCWcQ3HkZWS5/+a?=
 =?us-ascii?Q?eOXYV60d174bWQqRzpjevPo7SG61u3Fhzwbk5t+I+E0fSTl9bsLC30PkjXFs?=
 =?us-ascii?Q?Ow2Gekh/ywH1dqVAS3AOl6YkrVQGxIv1DXJ+YteHKcdcH6D+z44DsHZCIXWz?=
 =?us-ascii?Q?CCL4Q8bpfx4FJPIBHZ2p8UpUa2djDl4jsMqyhLy7Kashe6icGti3a2APLCsH?=
 =?us-ascii?Q?YsEJhx7D2o74E91KNKylkmkspZYey5XCRWj6iXMyt/xpajYF0BaK2mkdC9vx?=
 =?us-ascii?Q?yKQBdWtpZBzA6Pq4LY6ZxQX9EnrfxBwzc3pmqWyuwdYxH8plBqz2tbXjKttI?=
 =?us-ascii?Q?dN12jQeEM+criRNnW7DeacfdnZe9TkKDshkfiQ9bMZtsMGrIKy37Lur+aS6h?=
 =?us-ascii?Q?wthAURqwHiJILnLDdhaajiBppdHMAxJ2y8qugnwQT+WKzPJuqL0rnUnH165X?=
 =?us-ascii?Q?J7O4ckVoq7ADv9Ft2YIrLBDhhVzT7rqqW+SmoYWnYUyWU0K0ehKoSKnz6gdo?=
 =?us-ascii?Q?v7mP8qxQpTeQr0i+TBr+qD5MP34sY8vDlSXjR1H79YQm74lfg8o1D5dwAd+T?=
 =?us-ascii?Q?6F7n53ec1300AueW4Ry8eknajNWCGEByW6PIuHgJsCsmFQE9MBPr+XCza9XJ?=
 =?us-ascii?Q?TXw6e0nfYkLJois8G2u0f2Zpjqk1gti5/p22yQHKb+YO9b1pKyKIF/MC18zd?=
 =?us-ascii?Q?qHde+3yEXIpKx0eCWbiYe05yAnfhXg56n4KRlxdflhE0BaeqY+rAu8IkKmI2?=
 =?us-ascii?Q?1tZpqJSQEzdOkeYtP449l77bHDyqnSyTuY2t4k5YOdtJW2VXws18NXwgYDAR?=
 =?us-ascii?Q?XknHLheiSF1haLiYSrNaQYvD44hoY8eiMiMZv/CV7+HGxDp5ebjuIpiAhIMG?=
 =?us-ascii?Q?8SM7kM53JpafpiGVs567eMGJWpCt9NcDEnhcv9YuvypRMe1aPVuL?=
X-OriginatorOrg: in-advantage.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 091398dd-4339-4cb4-94d7-08da4bc28f7a
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2351.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jun 2022 15:53:43.2229
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 48e842ca-fbd8-4633-a79d-0c955a7d3aae
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 7YAba/Eug1VB/8g4kjkT3vinvcBV/4eVnd1VIoLfqNxE+S++09uI/JnqcJ8/Zt9233wnfnh2VxqcOlc97asWnVDLWghTmn27qZtt6v55T8U=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR10MB4145
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sat, Jun 11, 2022 at 12:26:31PM +0200, Andy Shevchenko wrote:
> On Fri, Jun 10, 2022 at 7:57 PM Colin Foster
> <colin.foster@in-advantage.com> wrote:
> >
> > Several ocelot-related modules are designed for MMIO / regmaps. As such,
> > they often use a combination of devm_platform_get_and_ioremap_resource and
> > devm_regmap_init_mmio.
> >
> > Operating in an MFD might be different, in that it could be memory mapped,
> > or it could be SPI, I2C... In these cases a fallback to use IORESOURCE_REG
> > instead of IORESOURCE_MEM becomes necessary.
> >
> > When this happens, there's redundant logic that needs to be implemented in
> > every driver. In order to avoid this redundancy, utilize a single function
> > that, if the MFD scenario is enabled, will perform this fallback logic.
> 
> ...
> 
> > +#include <linux/err.h>
> > +#include <linux/platform_device.h>
> > +#include <linux/regmap.h>
> 
> Since it's header the rule of thumb is to include headers this one is
> a direct user of. Here I see missed
> types.h
> 
> Also missed forward declarations
> 
> struct resource;

Ahh, thank you. Yes, you mentioned this in v8 but I misuderstood what
you were saying. I'll also include types.h.

> 
> ...
> 
> > +       if (!IS_ERR(regs))
> 
> Why not positive conditional?
> 
> > +               *map = devm_regmap_init_mmio(&pdev->dev, regs, config);
> > +       else
> > +               *map = ERR_PTR(ENODEV);
> 
> Missed -.

Fixed. Thanks.

> 
> -- 
> With Best Regards,
> Andy Shevchenko