Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sat, 11 Jun 2022 10:11:48 -0700
From:   Colin Foster <colin.foster@in-advantage.com>
To:     Andy Shevchenko <andy.shevchenko@gmail.com>
Cc:     devicetree <devicetree@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        netdev <netdev@vger.kernel.org>,
        linux-arm Mailing List <linux-arm-kernel@lists.infradead.org>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
        Vladimir Oltean <vladimir.oltean@nxp.com>,
        Lee Jones <lee.jones@linaro.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Andrew Lunn <andrew@lunn.ch>,
        Heiner Kallweit <hkallweit1@gmail.com>,
        Russell King <linux@armlinux.org.uk>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Lars Povlsen <lars.povlsen@microchip.com>,
        Steen Hegelund <Steen.Hegelund@microchip.com>,
        Microchip Linux Driver Support <UNGLinuxDriver@microchip.com>,
        Linus Walleij <linus.walleij@linaro.org>,
        Wolfram Sang <wsa@kernel.org>,
        Terry Bowman <terry.bowman@amd.com>
Subject: Re: [PATCH v10 net-next 1/7] mfd: ocelot: add helper to get regmap
 from a resource
Message-ID: <20220611171148.GA851137@euler>
References: <20220610202330.799510-1-colin.foster@in-advantage.com>
 <20220610202330.799510-2-colin.foster@in-advantage.com>
 <CAHp75Vc+V3APvBO8rJ0awu65iPbEoYKn5bn4GhC0DEvC4DiKiw@mail.gmail.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAHp75Vc+V3APvBO8rJ0awu65iPbEoYKn5bn4GhC0DEvC4DiKiw@mail.gmail.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?F2hlRyghtkRM1r2vOMq0QB8Dp81xiMOv/sJJhJtlqoevsYXRrKoJVkZA03Qv?=
 =?us-ascii?Q?iGb4BfkcnKxoGoh4Zry/EAlK9r/BE4i1nsW6mBPBCtgzSz7dxXv/sG8uDqVo?=
 =?us-ascii?Q?OE2mGSzFUONjVMxbxmk3gBB3p3E3yejPRwnhEELPvdGHjDrEk7J9t3/+oK+4?=
 =?us-ascii?Q?7PflavQ6Hx+QclkhNpqlaq+hPH2kB4pB+nhQf9DpF3tXxOc4S4oX8pGxbK7B?=
 =?us-ascii?Q?Y1nRog0sQApWzzQhuD/8xgCsWl2c091YgNvEdR1u170pBH/rY5IFZj8wO/NW?=
 =?us-ascii?Q?0y36Mdd4cvUdhx5QXu2Nu6GVVZnlr9wEpt4prXWMWDb16kcWE9tSnDgNGwt6?=
 =?us-ascii?Q?uoFicmi1q6RbSj7wT3PoRXBHI08JZwlw90nEAo0njpl5gXO88YoDA6oJFPMo?=
 =?us-ascii?Q?YnU2IOfc8npQwBDdWO6h1wfTKCY2QYwxVzBj/UdoIvXHQoDM8nHMLPgtqodt?=
 =?us-ascii?Q?Eskcl8i8hKucPipq+HIMbQwGKM+j+Qw9oznSa3RGLA9sbn1xsWg2AcQJ5bXL?=
 =?us-ascii?Q?PSak9FtEH2AB7MwQlUubC3Bx3WjejsH8zG8ex+539Nnw9EWbkQo81YSVTE0o?=
 =?us-ascii?Q?CAgswVjVjBfe6ze76VzC37wXl3NooSIrGtAp+BW1drCGGc4VJHwjv4mmoFiM?=
 =?us-ascii?Q?YJQDNyCQqB4C9zAoTYb0Su0J2DeZwgAjRaS5LvuxYGDF6Ca//W75xvaXcoyN?=
 =?us-ascii?Q?gAAi1xaCsgTumqpjGgxyBFlZNl6Gau43BmsnYsoSi7rZHhaqUYCeg7hM3Jqk?=
 =?us-ascii?Q?FNsVozqpuNAnVFpMy4H0nup+meq9YJBXlNlMmtCSpmeb/aVVGMqXMmGl0+VV?=
 =?us-ascii?Q?c/1yZTrRD+1KdEtcFjGQfmL0hZ51y1fts74I/vT5gpXZSZweQdpywKeQNKVr?=
 =?us-ascii?Q?OzD+aEAyy3KkRn5wy4Q+zbaxFjWrSEBlVg0y9S2D4K2yPkqRlQyUO5Cpqkmg?=
 =?us-ascii?Q?cLDyuBild5J7EcVhmcema6D3dN2V7a3B+lE9880p9YH26huFGV3PuFsJjdez?=
 =?us-ascii?Q?DSQ54c2gdetXfuYbw0cjWu2cJ8X3Cu2OHJ5YPUwGWDt369yoVfL9qCndxTIB?=
 =?us-ascii?Q?38VyjtK80Q22FMV3KiLRonUhI3oDhwb/XoaAXePc7veQz7Pi8paVrfhZ8lIO?=
 =?us-ascii?Q?4ZSdzIb7mx/o0Nn6FQxBnpWGLm/hYqBQdJzippsV78IbZkTPvhxVNFp/ZE1G?=
 =?us-ascii?Q?gJK48XeP6lK1N0q1rJSarzzvsTsa4IR5KO6qfYPHE8nVWn0fcOM16RLrM6sJ?=
 =?us-ascii?Q?9FxTB9wUjPyLZxqJUGwgPP1rzu0z6IVlYwEPeFnPgtKmlYYGv7HhwKFnJafQ?=
 =?us-ascii?Q?WBK6v49/rf38SFPcXvuCfz+4IufdrfcYmw2AZsu2dQ2744F1Fs/sJu9sOvmf?=
 =?us-ascii?Q?G+DHjcKoY3ba6MXy6ReD2tPoxxEOtsrZiUMBTDSOD5vJYG2bh+TGH2MsWf34?=
 =?us-ascii?Q?l7UBwYI31jn3ZhPNpQwAHUBUPQk5mR5fhhZ57aUFuGnAfdaxAzxUpEQQCh9I?=
 =?us-ascii?Q?Zk3APflFYut345bpJ+6vSonrk38X0TGFYgpegB1zjSdbkS/cKVqWbBM2W8nK?=
 =?us-ascii?Q?8EpdhUC6+XCw5NJH73Ge70PsbM5NzG+mVcepZvUuyYEKB1/efGzOXOnxWCeY?=
 =?us-ascii?Q?GLsBeB/9kv/ElHyaRE6Co56XtzaFOvUMw2uGb7Mis9rMOaWm6ftMlarhxTRL?=
 =?us-ascii?Q?ntzSdbCA6U/z25ru/1jmstZi2oaPM7PqgSrLYW8ZGuX5iQ2YpWAg+uGEgkgC?=
 =?us-ascii?Q?ZWWhxzqnVw1gcNcfqLLh/svDZ35FE2TmO0ozCHFRzFRd/Prb+VzH?=
X-OriginatorOrg: in-advantage.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9ec4e7c9-47a6-4b16-fe3e-08da4bcd7bab
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2351.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jun 2022 17:11:54.4094
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 48e842ca-fbd8-4633-a79d-0c955a7d3aae
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: H4aXLQuEQPYKC+PFS87zqc9my2ZvisloQWgavWNpqE5HrBkDqUAg1QLcvkUMB2ujHYeilCuHlifKCgNn/du76dl6f0yAk8N8LCGipSS0aDw=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR10MB3499
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Andy,

On Sat, Jun 11, 2022 at 12:37:26PM +0200, Andy Shevchenko wrote:
> On Fri, Jun 10, 2022 at 10:23 PM Colin Foster
> <colin.foster@in-advantage.com> wrote:
> >
> > Several ocelot-related modules are designed for MMIO / regmaps. As such,
> > they often use a combination of devm_platform_get_and_ioremap_resource and
> > devm_regmap_init_mmio.
> >
> > Operating in an MFD might be different, in that it could be memory mapped,
> > or it could be SPI, I2C... In these cases a fallback to use IORESOURCE_REG
> > instead of IORESOURCE_MEM becomes necessary.
> >
> > When this happens, there's redundant logic that needs to be implemented in
> > every driver. In order to avoid this redundancy, utilize a single function
> > that, if the MFD scenario is enabled, will perform this fallback logic.
> 
> v10 has the same issues I have pointed out in v9.
> 
> Please, take your time and instead of bombing mailing lists with new
> versions try to look how other (most recent) drivers have been done.

Yes - I recognize that my decision to try to throw in a quick fix was
the wrong one. My apologies.

When you mention looking at more recent drivers - are you referencing
the submission process, or something else?

> 
> Also pay attention to the API design.

I understand if I'm making a helper function, that helper function
shouldn't change the API if it can be avoided. Hopefully the updates I
suggested are the correct ones.


Thanks again for the feedback.

> 
> -- 
> With Best Regards,
> Andy Shevchenko