Received: by 2002:a5d:925a:0:0:0:0:0 with SMTP id e26csp811085iol;
        Sat, 11 Jun 2022 20:26:11 -0700 (PDT)
X-Google-Smtp-Source: ABdhPJxmORs9+T6F+fGpStmoz69eZ5LqcGaF+P410sDspotN0cMCiJpGeq9Xk4KM7S3jG+GzE8MU
X-Received: by 2002:a05:6a00:15c9:b0:51c:178:ac7e with SMTP id o9-20020a056a0015c900b0051c0178ac7emr38427311pfu.64.1655004371205;
        Sat, 11 Jun 2022 20:26:11 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1655004371; cv=none;
        d=google.com; s=arc-20160816;
        b=oIa0tPVH6tAR8X6y/bNPp7D2GtZUoVo4xhYrNzuvGK0hnviZ6fRbdGhaSTZvASdjmR
         RnAennudUGHlMEOElgWGvkJDP94wqf1EB0kICdm8UHdsz5xphc/dqZX6yNPAJPUmAaSM
         8UKNaBMx2I8FFCLcpafhlrnxKIzCt9YqaKdsEMiJAryJbQn1/iiAnOiqcab2A2w1v9SV
         +1Nmg5l9KijeG3TPS7alBOZ3KL/59bV5KRXeQD2wmLEGAGnxmJrqnba6aofy//bbv4Ca
         8eHRnL4NgluBgRfFdOMMte9IYAIX5OSKczQgZY0dA3+IBdqJ9oq3MY9BTK7AtC1xTGO3
         TDFg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:content-transfer-encoding:mime-version
         :references:in-reply-to:message-id:subject:cc:to:from:date
         :dkim-signature;
        bh=oBYWAOZvJpGeDNPb4gs/iuLJRRbWVq1kA66BhSE3zSk=;
        b=fq7lo3aqxcw7QBNA8lISxZLFQweM8A6rI8p/ENI2zEzKxcxP4Fa2dQY/D/g9hdaBrQ
         /HYU66fRW3tU6daWcbbv80lwWAM15mxfXpBZFxo24dj8IWEvu3TQBxivXKiJqNuxaAkP
         OVVTooj9QCiF2mIlHsc7VSfrxEHAEGMDz3NSCpBVvpE/k0fZYptKVHR3i4P2if8lHZR5
         G6D7tJPdOKXY7cT7tniLcByO+b69tsozZp634N8QLGqZsKv3fkszXTNInb5FOwMIKnbk
         fsdx1k8KGZxbuQHJNT29ckruEOa0xUO1buqXtvykkgIfmtRqR1+C7FYpx+/1dGWuOJ/P
         K5Ag==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@linux-foundation.org header.s=korg header.b="b/zAgY8Q";
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20])
        by mx.google.com with ESMTP id f3-20020a170902860300b0016406e53e35si4693318plo.33.2022.06.11.20.25.59;
        Sat, 11 Jun 2022 20:26:11 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@linux-foundation.org header.s=korg header.b="b/zAgY8Q";
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S231872AbiFKUdp (ORCPT
        <rfc822;aditya.jainadityajain.jain@gmail.com> + 99 others);
        Sat, 11 Jun 2022 16:33:45 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54724 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S229528AbiFKUdo (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Sat, 11 Jun 2022 16:33:44 -0400
Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1625C112C
        for <linux-kernel@vger.kernel.org>; Sat, 11 Jun 2022 13:33:40 -0700 (PDT)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
        (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
        (No client certificate requested)
        by ams.source.kernel.org (Postfix) with ESMTPS id AE175B80B4D
        for <linux-kernel@vger.kernel.org>; Sat, 11 Jun 2022 20:33:38 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id D9AAFC34116;
        Sat, 11 Jun 2022 20:33:36 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org;
        s=korg; t=1654979617;
        bh=F7EHT9nZNVQPeqtZoCb685s4XBj+VIt+AKyBVKyAR8c=;
        h=Date:From:To:Cc:Subject:In-Reply-To:References:From;
        b=b/zAgY8QdVjsqF7/QCSMna5TOmNv+PT2Q+hVV7LDXhuXgEABctZAXDkPzDEYdS99T
         /Uyvrf+ISelOhLCCUGO+gIdxx3CeSwT+xZxPGocc8G8ucXhBiEJkszNR/TkMdiEXQl
         APDF5E95LyAuBGog8WUrB9eFTPabRgYXJDmIjGk8=
Date:   Sat, 11 Jun 2022 13:33:36 -0700
From:   Andrew Morton <akpm@linux-foundation.org>
To:     Miaohe Lin <linmiaohe@huawei.com>
Cc:     <aarcange@redhat.com>, <willy@infradead.org>, <vbabka@suse.cz>,
        <dhowells@redhat.com>, <neilb@suse.de>, <apopple@nvidia.com>,
        <david@redhat.com>, <surenb@google.com>, <peterx@redhat.com>,
        <linux-mm@kvack.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/7] mm/khugepaged: remove unneeded shmem_huge_enabled()
 check
Message-Id: <20220611133336.b582edd4c2c2df15f5561d2b@linux-foundation.org>
In-Reply-To: <20220611084731.55155-2-linmiaohe@huawei.com>
References: <20220611084731.55155-1-linmiaohe@huawei.com>
        <20220611084731.55155-2-linmiaohe@huawei.com>
X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-redhat-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
X-Spam-Status: No, score=-8.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_HI,
        SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sat, 11 Jun 2022 16:47:25 +0800 Miaohe Lin <linmiaohe@huawei.com> wrote:

> If we reach here, hugepage_vma_check() has already made sure that hugepage
> is enabled for shmem. Remove this duplicated check.

I updated this to

If we reach here, hugepage_vma_check() has already made sure that hugepage
is enabled for shmem, via its call to hugepage_vma_check().  Remove this
duplicated check.