Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
References: <20220606202109.1306034-1-ankur.a.arora@oracle.com>
 <20220606203725.1313715-9-ankur.a.arora@oracle.com>
 <20220608000125.na6z3niyv4ty7xn7@mail>
User-agent: mu4e 1.4.10; emacs 27.2
From:   Ankur Arora <ankur.a.arora@oracle.com>
To:     Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
Cc:     Ankur Arora <ankur.a.arora@oracle.com>,
        linux-kernel@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org,
        torvalds@linux-foundation.org, akpm@linux-foundation.org,
        mike.kravetz@oracle.com, mingo@kernel.org, luto@kernel.org,
        tglx@linutronix.de, bp@alien8.de, peterz@infradead.org,
        ak@linux.intel.com, arnd@arndb.de, jgg@nvidia.com,
        jon.grimm@amd.com, boris.ostrovsky@oracle.com,
        konrad.wilk@oracle.com, joao.m.martins@oracle.com
Subject: Re: [PATCH v3 13/21] clear_page: add generic
 clear_user_pages_incoherent()
In-reply-to: <20220608000125.na6z3niyv4ty7xn7@mail>
Date:   Sun, 12 Jun 2022 16:49:30 +0530
Message-ID: <87mteinn7h.fsf@oracle.com>
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 2
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?/hnVryKnye98wUQqJajis7lSHhgdfkIgrchQe9XT8h23viVsC6sxyeVF24Oz?=
 =?us-ascii?Q?kxckCQji4qg8ZGCffNu5XKB5evcQO75gqQpHzTwOFtBSvvI3Sbt4vvcM0qGW?=
 =?us-ascii?Q?1wCZA5fVqnxSuY3yPN+E6qG5jqXlZHH0JYPZJHQ9F9aiO3cJjduWdhbJHvuY?=
 =?us-ascii?Q?O3xlWGntYQm0qG23f0/pgbANvXBn2AuzfqigjglODySqKUMKnxShnItijzF8?=
 =?us-ascii?Q?3A+gcukaIB8JVFrZKe4tL0MXkVWKOQAJj64lVwr8sl20C1QA62Rl+EJt2BxS?=
 =?us-ascii?Q?iHJt008+BoELKQBMFzwmQds759aUkwXx0wiY2m2unFnfKP8uN2PczvO3YWhS?=
 =?us-ascii?Q?JgDcSx9JIt9Ftv57fT/9Y7j4gmn1GrrIlEEPmYu7+e+Wx9is6aRLPcOdUaCT?=
 =?us-ascii?Q?HipsNwizH2KFxAb3NPh1nv3f52AD9U+DMD0VPtFs3eEDvPWjNE3J6KpUEj/K?=
 =?us-ascii?Q?ONzXFcYGcmqLQSpUlohRXjp5MgycKix9jgKYwvMJyy2GiBTrbVHVKsRK/ayy?=
 =?us-ascii?Q?FKLIQUEjvwaHCZ0GM03TISY1DAR6mkPaokzfX329Z8HMgQEdrk37j5HvuuTi?=
 =?us-ascii?Q?M6BlzFltxlWfzpv6eBGeAKGEyY7cYQqJ8hvB0pXE6GPBB427XtnsOFA53SHp?=
 =?us-ascii?Q?ry5iYGjN7uiT1FwWInsUmBXbQoV/JIEJxCYhg4tfN2tHEFwMOu3YMtkvsm0v?=
 =?us-ascii?Q?6BAnapPqU9MZthOV4bFLBqO+3oVBwW5gVhM4pzYY20kaOQP+I9EA6D2apaqU?=
 =?us-ascii?Q?UEQADDdjKQQTk+G0SQTv0tXEkZ0t2v3d7LxNwHO9MeHctVUZK2Zgcc6nRyRO?=
 =?us-ascii?Q?/N6HoXRII2+SN9SXRHGCNhdpLzZgdhCFrOlNznGsJyDVemew6OUEx3BsWDJv?=
 =?us-ascii?Q?5S5KrNlNxF7wFBA0ODyPRszDEyk5U0c7EEmppnrAeEVV6jHqqtbs0mxgr+/D?=
 =?us-ascii?Q?sORma75ciS7RR9uNgQPhxlGIMkGYCsxfYDMw5RT5vj1LAl671LiuuJ0pft28?=
 =?us-ascii?Q?FKrAsh3627cLBv8F8A7+EjJOwoI5BhkJS+y6n90DF9++sNDrxeNnYO+mMcLo?=
 =?us-ascii?Q?tkh9PeCLHy0xqvwk1sxM3t1O/b2s9myNsEBwBGV+HzFW/LX85K1iXIMlkhA0?=
 =?us-ascii?Q?kIz7gGQc1myQbSx55IyilYq8TmJc9EHx1xYFVek+3qZII2zSUyhtPnKKVQrc?=
 =?us-ascii?Q?Mv/P/LYKrqrFFXUVczu2g153+EV7Psyxej2QLZSwIVBtolWjv28DKKJln7+G?=
 =?us-ascii?Q?ZD1E7F90DqplpzAaDjs2FaY9VBv+XqKoFmlbTBEtxvLwjLRz2+Xql5pmShf6?=
 =?us-ascii?Q?55W5/jt2xw3b+wUWKlDX2dqBw+ojD/Hz8IdfjfX87uKgDHScypGh7Lvps0K+?=
 =?us-ascii?Q?rDvm+z6D0C56/WKbxujpHA/tkbfBUpkej27Izj3rW+HDz+0m3NAof5/TdnVs?=
 =?us-ascii?Q?3PC3VO4y+mLFBYregTKwRW8uXO1yw3pdiKy5nbg9CXqQFqFx5lAHIMdIEXh1?=
 =?us-ascii?Q?DMobapgcTScjZ8f9OSNy4P7/ngAXz8uPS6t86va/Ko8OoR0FLDPP7vsT5XXK?=
 =?us-ascii?Q?pL1TyffJRvpGlNrxGjdiie3qnM2xhk0nTEACD2BlZjysmUjdQXsR7dbFHuF4?=
 =?us-ascii?Q?8/2SesDVCxvRR2lVx2WXsfPUA/qfqvH8+Fs6mQbyhq7w1bS6z0NgQ7eBLPDr?=
 =?us-ascii?Q?H/14K+UG6fwNRXHxMWGyeyhn4eNDFJ5Nc6TX6jnAiyH7FIxPWZCqVyLAVF6v?=
 =?us-ascii?Q?379M8qWqwqQZWhU4DBrig/MpM2Gl+frHNyT7vZgLvXx5u0EaO4otE48M+rIS?=
X-MS-Exchange-AntiSpam-MessageData-1: rwEn1xwCJPAtxcJLUaMnFCuxzmGXiXIDHVU=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1e6df70e-e067-4524-d922-08da4c65704a
X-MS-Exchange-CrossTenant-AuthSource: CO6PR10MB5409.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jun 2022 11:19:39.0238
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: hvJ47w6F1nIuizzJmcmbBk+vjK18HoZbMvdp9/BjvhvwfkMttufapLsJGsgVr9C711bjwWXE39CVUfYjTWOkG0zzpglDm154ruQEeGXlcjc=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR10MB4556
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.517,18.0.874
 definitions=2022-06-12_04:2022-06-09,2022-06-12 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 phishscore=0
 mlxlogscore=929 suspectscore=0 mlxscore=0 spamscore=0 bulkscore=0
 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2204290000 definitions=main-2206120054
X-Proofpoint-ORIG-GUID: B9pdLfRNhLKGACBUCFWPxvzvEbFkYdZI
X-Proofpoint-GUID: B9pdLfRNhLKGACBUCFWPxvzvEbFkYdZI
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


Luc Van Oostenryck <luc.vanoostenryck@gmail.com> writes:

> On Mon, Jun 06, 2022 at 08:37:17PM +0000, Ankur Arora wrote:
>> +static inline void clear_user_pages_incoherent(__incoherent void *page,
>> +					       unsigned long vaddr,
>> +					       struct page *pg,
>> +					       unsigned int npages)
>> +{
>> +	clear_user_pages((__force void *)page, vaddr, pg, npages);
>> +}
>
> Hi,
>
> Please use 'void __incoherent *' and 'void __force *', as it's done
> elsewhere for __force and address spaces.

Thanks Luc. Will fix.

--
ankur