Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <f1402a1d-a74d-f7b9-b9e2-fc3991781e64@gmail.com>
Date:   Sun, 12 Jun 2022 17:09:47 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Subject: Re: [PATCH 3/3] ARM: dts: exynos: add function and color to aat1290
 flash LED node in Galaxy S3
Content-Language: en-US
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        Pavel Machek <pavel@ucw.cz>, Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Alim Akhtar <alim.akhtar@samsung.com>,
        linux-leds@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-samsung-soc@vger.kernel.org
References: <20220607085343.72414-1-krzysztof.kozlowski@linaro.org>
 <20220607085343.72414-3-krzysztof.kozlowski@linaro.org>
 <4a7f8ab6-c061-3861-5790-b6c0fbd7cad1@gmail.com>
 <ef62a7bb-2217-2947-17dd-fc4a51acdea5@linaro.org>
From:   Jacek Anaszewski <jacek.anaszewski@gmail.com>
In-Reply-To: <ef62a7bb-2217-2947-17dd-fc4a51acdea5@linaro.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 6/10/22 12:14, Krzysztof Kozlowski wrote:
> On 09/06/2022 22:31, Jacek Anaszewski wrote:
>> Hi Krzysztof,
>>
>> On 6/7/22 10:53, Krzysztof Kozlowski wrote:
>>> Add common LED properties - the function and color - to aat1290 flash
>>> LED node in Galaxy S3.
>>>
>>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>>> ---
>>>    arch/arm/boot/dts/exynos4412-galaxy-s3.dtsi | 3 +++
>>>    1 file changed, 3 insertions(+)
>>>
>>> diff --git a/arch/arm/boot/dts/exynos4412-galaxy-s3.dtsi b/arch/arm/boot/dts/exynos4412-galaxy-s3.dtsi
>>> index 72901772fcad..d76f3678dcab 100644
>>> --- a/arch/arm/boot/dts/exynos4412-galaxy-s3.dtsi
>>> +++ b/arch/arm/boot/dts/exynos4412-galaxy-s3.dtsi
>>> @@ -7,6 +7,7 @@
>>>     */
>>>    
>>>    /dts-v1/;
>>> +#include <dt-bindings/leds/common.h>
>>>    #include "exynos4412-midas.dtsi"
>>>    
>>>    / {
>>> @@ -27,6 +28,8 @@ led-controller {
>>>    
>>>    		led {
>>>    			label = "flash";
>>> +			function = LED_FUNCTION_FLASH;
>>> +			color = <LED_COLOR_ID_WHITE>;
>>
>> Addition of these two properties will not change anything because
>> the label has precedence. It is deprecated, but if you introduce
>> function and color to the binding instead of the label, the resulting
>> LED class device name will change.
> 
> Which is not necessarily what we want, right? Adding these properties is
> a proper description of hardware, regardless whether current Linux
> implementation uses them or not.

Actually I'd just drop label in addition to your change.
I don't think it would break anybody seriously - not expecting it has
any larger group of users and having uniformly constructed DTS files
in the mainline has greater value.

-- 
Best regards,
Jacek Anaszewski