Received: by 2002:a6b:fb09:0:0:0:0:0 with SMTP id h9csp101110iog; Sun, 12 Jun 2022 20:26:16 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyIJX/NlbfSxzU1AnNH7J+JSzHnCirwJeAhB8t2CxdTF9ZRsD2WeGj0r1BfSLXeegO41sVu X-Received: by 2002:a05:6402:524c:b0:42e:320:bfbc with SMTP id t12-20020a056402524c00b0042e0320bfbcmr63974274edd.65.1655090776003; Sun, 12 Jun 2022 20:26:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1655090775; cv=none; d=google.com; s=arc-20160816; b=AI5kvXYRhUwcaiMyDsCHno4i/X1sga2SUsKgH1QWxpCXgyeAwl9o7XP0lNWB48meqM puZULTK2mzbje+jB7OHTOnny+0GmMv/lc0fVyNYn4mvU75AVVMvX9h9uoQlTQF1USKre Y3tJeK9Saaoy/tL6QPtl3Oc4E88tuhe3un+lhA5l3EPfETfNlwSMSfXCXoRyGrPTtvDy d5rhRxJzOv2Lrm1xaO20iCU5jr3U7m5OKrLPwuwVQJgT9998ouLnWLx4dqsBIBq0B2ID XrForpFXzKNPRgDyDZkhpP8VomeZT25TZ0fZs6EjITw3nzpiGtxm+nu3fZnmHGoq7cos aPSw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=cTRb4c6Ri5jA9cQIXnS6+OvO/HAgNvzGYN6ytAzDNwk=; b=hq/DE78LntG9ugGnxwafNL8U7e1fmsX7lqb8Pp+8Olav0+bGNR2tTRQHkcjs3MnKxC jUbQEYkQ0yEc/8s9hY6ZbSq9amX89zb+i5da+MW2iT/MXxBPYEQs6BcaUjAPL8gCum6v eQJ+U7ejFlfP3PEk3C8m9i3hoERBLHc+2yzeGoFR0ia9obNNWtbWJfuX8weKZHdWW0wj M3Ce3ABXPXxVIWNlmz/UdK2nQqRjk/wFbGL5v0gFDWLbzeoQgk19EheHt+t3s9x81z1P UpXoyygOh/IERiuRgUCriID4qxyqfsfhnL1HZkCzq0LgUiygP2ii+5wrmeR37hSqziJa Tyyg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="PxWK/9l6"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ji17-20020a170907981100b00717917b7d7esi2634112ejc.278.2022.06.12.20.25.52; Sun, 12 Jun 2022 20:26:15 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="PxWK/9l6"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235655AbiFMBQH (ORCPT + 99 others); Sun, 12 Jun 2022 21:16:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42234 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231309AbiFMBQD (ORCPT ); Sun, 12 Jun 2022 21:16:03 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ED783252A4; Sun, 12 Jun 2022 18:16:02 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id AE9F4B80CFB; Mon, 13 Jun 2022 01:16:01 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6A678C341C4; Mon, 13 Jun 2022 01:16:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1655082960; bh=T/oPYXJvfTUUTAn3CsqoozPh9/pXSGnZmlhYNE8gbWs=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=PxWK/9l6TdsQa77yV2AJPnGPvbYWhjRLP+wFfrNAXLjgtstoiHZXCMoo8B2IqcL7y rJYzFIT+mHg3ZKrHvaheUxROxBUNvqFs2qlykv4MpcQSZOCcE5InVYzVY9gAedqrzl FnuwwSzIfvkZHuyrFJ7SxGf5qezL+KsNEXhVx5VKfPjeumd7apyl49oYKlxtRU1zpg GDBh5Hgh8YUFAxR7RJZPuea54fZ5P93OWebgMT4J8xA0g1zF/FoCx8KzlVZ5id19aY dSaS71/WhW/0o+WHBrRP1zFeukLpZRbthXoRShYwKaOPOzZU843Ve5m0UWJoV8qtRs VsQDIkfPoli1Q== Received: by mail-ua1-f48.google.com with SMTP id 63so1644079uaw.10; Sun, 12 Jun 2022 18:16:00 -0700 (PDT) X-Gm-Message-State: AOAM532X/HcAEa2YaFJjCvzIZNL9PJ69x/UlVxmrZ9PxP1xJd59Lnaez pTd191Ygtk+bldpMc6ZaUQWfW507LiPajqQWev8= X-Received: by 2002:ab0:3459:0:b0:378:ec81:4a8b with SMTP id a25-20020ab03459000000b00378ec814a8bmr14374212uaq.83.1655082959409; Sun, 12 Jun 2022 18:15:59 -0700 (PDT) MIME-Version: 1.0 References: <20220405071314.3225832-1-guoren@kernel.org> <20220405071314.3225832-3-guoren@kernel.org> <20220608094108.GA18122@asgard.redhat.com> In-Reply-To: <20220608094108.GA18122@asgard.redhat.com> From: Guo Ren Date: Mon, 13 Jun 2022 09:15:48 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH V12 02/20] uapi: always define F_GETLK64/F_SETLK64/F_SETLKW64 in fcntl.h To: Eugene Syromiatnikov Cc: Christoph Hellwig , Palmer Dabbelt , Arnd Bergmann , Greg Kroah-Hartman , Nathan Chancellor , Naresh Kamboju , linux-arch , Linux Kernel Mailing List , linux-riscv , linux-s390 , sparclinux , linuxppc-dev , Parisc List , "open list:BROADCOM NVRAM DRIVER" , Linux ARM , "the arch/x86 maintainers" , =?UTF-8?Q?Heiko_St=C3=BCbner?= , ldv@strace.io Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-8.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 8, 2022 at 5:41 PM Eugene Syromiatnikov wrote= : > > On Tue, Apr 05, 2022 at 03:12:56PM +0800, guoren@kernel.org wrote: > > From: Christoph Hellwig > > > > Note that before this change they were never visible to userspace due > > to the fact that CONFIG_64BIT is only set for kernel builds. > > > -#ifndef CONFIG_64BIT > > +#if __BITS_PER_LONG =3D=3D 32 || defined(__KERNEL__) > > Actually, it's quite the opposite: "ifndef" usage made it vailable at all= times > to the userspace, and this change has actually broken building strace > with the latest kernel headers[1][2]. There could be some debate > whether having these F_*64 definitions exposed to the user space 64-bit > applications, but it seems that were no harm (as they were exposed alread= y > for quite some time), and they are useful at least for strace for compat > application tracing purposes. > > [1] https://github.com/strace/strace/runs/6779763146?check_suite_focus=3D= true#step:4:3222 > [2] https://pipelines.actions.githubusercontent.com/serviceHosts/e5309ebd= -8a2f-43f4-a212-b52080275b5d/_apis/pipelines/1/runs/1473/signedlogcontent/1= 2?urlExpires=3D2022-06-08T09%3A37%3A13.9248496Z&urlSigningMethod=3DHMACV1&u= rlSignature=3DfIT7vd0O4NNRwzwKWLXY4UVZBIIF3XiVI9skAsGvV0I%3D > Yes, there is no CONFIG_64BIT in userspace, we shouldn't limit it with (__BITS_PER_LONG =3D=3D 32 || defined(__KERNEL__)) to break the compatibility. Just export F_*64 definitions permanently. --=20 Best Regards Guo Ren ML: https://lore.kernel.org/linux-csky/