Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Peng Fan <peng.fan@nxp.com>
To:     "Peng Fan (OSS)" <peng.fan@oss.nxp.com>,
        "djakov@kernel.org" <djakov@kernel.org>,
        "shawnguo@kernel.org" <shawnguo@kernel.org>,
        "s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
        "festevam@gmail.com" <festevam@gmail.com>,
        "robh+dt@kernel.org" <robh+dt@kernel.org>,
        "krzysztof.kozlowski+dt@linaro.org" 
        <krzysztof.kozlowski+dt@linaro.org>, Abel Vesa <abel.vesa@nxp.com>,
        "abailon@baylibre.com" <abailon@baylibre.com>,
        "l.stach@pengutronix.de" <l.stach@pengutronix.de>,
        "laurent.pinchart@ideasonboard.com" 
        <laurent.pinchart@ideasonboard.com>,
        "marex@denx.de" <marex@denx.de>,
        "paul.elder@ideasonboard.com" <paul.elder@ideasonboard.com>,
        "Markus.Niebel@ew.tq-group.com" <Markus.Niebel@ew.tq-group.com>,
        "aford173@gmail.com" <aford173@gmail.com>
CC:     "kernel@pengutronix.de" <kernel@pengutronix.de>,
        "linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        dl-linux-imx <linux-imx@nxp.com>
Subject: RE: [PATCH 0/8] interconnect: support i.MX8MP
Thread-Topic: [PATCH 0/8] interconnect: support i.MX8MP
Thread-Index: AQHYdZuXp1k0Y8bakU2NzRLysk7WMq1Mm6BQ
Date:   Mon, 13 Jun 2022 01:23:18 +0000
Message-ID: <DU0PR04MB941799547BD863444C6F268D88AB9@DU0PR04MB9417.eurprd04.prod.outlook.com>
References: <20220601094156.3388454-1-peng.fan@oss.nxp.com>
In-Reply-To: <20220601094156.3388454-1-peng.fan@oss.nxp.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?xlCNgaBqyJOSQ9yQhKCoUvAsRgOsGf6nCP1otTjqBT+oM4wYLeqfBjmlrJMQ?=
 =?us-ascii?Q?M/cT8eJc6EryYkV0IAAZEi20P4xRsbEZThmn6Q5Dkj6ZasqDhsuGOYAxlLwF?=
 =?us-ascii?Q?H1VNvIDbRMY8tNRxUzUK9I/7+b/TVtxYdWalWug0S0JVn6sqdw0lQ1VR7TO8?=
 =?us-ascii?Q?JglfMMwQS8KTsrCA1BvpJ5SoQcgCdvHFQ5Sx4NpNxB9PhqGF73YKWB+OlqOn?=
 =?us-ascii?Q?+VFdbN4d0bP0y1RhnM7fWGV95u7GipDx9vQrBqn656MSk8YCek+IQWxLU3pl?=
 =?us-ascii?Q?kpQGDiMgtxhizX79qjmrLUHPSxaqvSWA1emwSgq5LB9sLnx01GKgYOYCKp3y?=
 =?us-ascii?Q?U7bjcK2QUrKfi1tot9aoqvpwzuUuJ+kux+AI9L0IRMDYLEETzXO4AoKmwF6q?=
 =?us-ascii?Q?iA7W3YXuafFYhUcSoyJQv6I+YiYLnd9z+P1cnCAco1/bKCghRveDxADPmciY?=
 =?us-ascii?Q?HkM9bqJEYwX8+uxrquUFdqUI3+QLmKNJFVlqkTwXl2bbusApgJiSEqPPvn9Z?=
 =?us-ascii?Q?dlUp26QJsbJSdUlL5OEKscG7yvAH12Tn4Ue38JTuKpy+Uk37HIJ5nflsrM0X?=
 =?us-ascii?Q?Fq83r2YIoToIPP5mmXOhanbB+16p6gpyupJNqOGjyxGUOa035Ht5mEeOStLn?=
 =?us-ascii?Q?u3qabAv31w9052nr5oWn7gMt1HmS9BxpO0L3qpwXa+6LvSCcFZuQu7a+t7jD?=
 =?us-ascii?Q?C4IGV+L2TpIJ/6gDgfrc9kWixU0i0uksQ8lIzyndbXKifMkE+yTNqlv8IIG7?=
 =?us-ascii?Q?y4wCmYWT/RzuEzuEGEUyePcgs0NFdbFvYQveYj4Daa/j2PUcaUfQUrqS5w7c?=
 =?us-ascii?Q?ZgtnWTPQRq5ix04szX7F7gAAY25Tcpw1N8HVrHSde4peiwa9hy12y63xMA2Q?=
 =?us-ascii?Q?Wa8Qq6jQ3FvCrQ/cCBoTcsIatzzDhCIr0NewRaiVLXnAqC4B/QFGCzTi7hl2?=
 =?us-ascii?Q?MytNFWt9QBJmodtQp1F+XH57P6rJliLzSeLR0qNOVqf8G1JeGblYo+RVI7lz?=
 =?us-ascii?Q?ELp7ofV7IjueK+AeOenG2qoNfq2rc4z+vcvFRZ/fPZk6sl3Y5YeNjygdR/BL?=
 =?us-ascii?Q?fpZTmBnFp7cV7vpqU+wsD8SXplGVmCm6g+vmE/nA7OrFCVbmsVOWzegeom1O?=
 =?us-ascii?Q?Ibk6RMOuzNm7+DSBgfNIhGcunBb4TQ5YH34mRZp8HUhOrJ+BbxI6KINodowJ?=
 =?us-ascii?Q?bgkIbImtFCfxdBZPjbrNVedQn8Ahuo+5Qt/7B66wTMPYs7+ieRjzUTsudNnF?=
 =?us-ascii?Q?kKhLgDUKKPKx9c1G52uv2XoLwk1WB4b0ivPxJ5+xjuJZOuX9dCftnlQFSQWJ?=
 =?us-ascii?Q?GFMqWy8NR/K59wcAR+kEXWrm3NSkJN+JvIE9cI/RCppMWgn0QYcr154jHL5g?=
 =?us-ascii?Q?FV9hSHt1jumoMVyY0jmNyVtkKnZn99+LriNyj8FaSJl0m+noetAs6Z4y1+xV?=
 =?us-ascii?Q?0+yu/Q7lHMLnB+prO5/IUwel2HBJ5n3H7lR5Ti8JNfliJUuiLVD8e647KbJn?=
 =?us-ascii?Q?k3UdbCx2wg0PcudFWUgYWkGPN57kYmsb63aW8oKdTpuCQXl3sUpFs/26pNCY?=
 =?us-ascii?Q?7IaYb2Ts8Iod4QO0Q3gkEbPchQ7CyCTHlINnBfjPlN5EJV4rV7bv2c/aviiZ?=
 =?us-ascii?Q?uJ+RzhZLWaM2B3ksx8hRs8jgQSMjw/quYkFcWZV6Ee3bSZuDuKDb79DzoUJN?=
 =?us-ascii?Q?AM4aDmwTk9wXC7Z+HR4Wlu7MX4Gb4a3DyBRGFqFqbcn7A/TY?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DU0PR04MB9417.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: aa016d06-251d-41fa-f610-08da4cdb4c73
X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Jun 2022 01:23:18.9938
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: /DncKipyGXC1h7Kg8kkIo/PWrR+jW00vLOsnHSSQsDfVOFjuZSYVTemkusphesQTdIc1+XXP7X/6Vh4dR6u+TA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB4327
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

All,

> Subject: [PATCH 0/8] interconnect: support i.MX8MP

I am going to send out V2 this week to address the comments until now.
But before that I would like to see if any one has any comments on the
design here.

Georgi, do you have comments on Patch 2 " interconnect: add device
managed bulk API"

Lucas, since you had comments when I first use syscon to configure NoC,
are you ok with the design to use interconnect in this patchset?

Thanks,
Peng.

>=20
> From: Peng Fan <peng.fan@nxp.com>
>=20
> This patchset is to support i.MX8MP NoC settings, i.MX8MP NoC initial val=
ue
> after power up is invalid, need set a valid value after related power dom=
ain up.
>=20
> This patchset also includes two patch[1,2] during my development to enabl=
e the
> ICC feature for i.MX8MP.
>=20
> I not include ddrc DVFS in this patchset, ths patchset is only to support=
 NoC
> value mode/priority/ext_control being set to a valid value that suggested=
 by
> i.MX Chip Design Team. The value is same as NXP downstream one inside Arm
> Trusted Firmware:
> https://source.codeaurora.org/external/imx/imx-atf/tree/plat/imx/imx8m/im=
x
> 8mp/gpc.c?h=3Dlf_v2.4#n97
>=20
> A repo created here:
> https://github.com/MrVan/linux/tree/imx8mp-interconnect
>=20
> Peng Fan (8):
>   dt-bindings: interconnect: imx8m: Add bindings for imx8mp noc
>   interconnect: add device managed bulk API
>   interconnect: imx: fix max_node_id
>   interconnect: imx: set src node
>   interconnect: imx: introduce imx_icc_provider
>   interconnect: imx: set of_node for interconnect provider
>   interconnect: imx: configure NoC mode/prioriry/ext_control
>   interconnect: imx: Add platform driver for imx8mp
>=20
>  .../bindings/interconnect/fsl,imx8m-noc.yaml  |   6 +
>  drivers/interconnect/bulk.c                   |  34 +++
>  drivers/interconnect/imx/Kconfig              |   4 +
>  drivers/interconnect/imx/Makefile             |   2 +
>  drivers/interconnect/imx/imx.c                |  68 +++--
>  drivers/interconnect/imx/imx.h                |  25 +-
>  drivers/interconnect/imx/imx8mm.c             |   2 +-
>  drivers/interconnect/imx/imx8mn.c             |   2 +-
>  drivers/interconnect/imx/imx8mp.c             | 232
> ++++++++++++++++++
>  drivers/interconnect/imx/imx8mq.c             |   2 +-
>  include/dt-bindings/interconnect/fsl,imx8mp.h |  59 +++++
>  include/linux/interconnect.h                  |   6 +
>  12 files changed, 424 insertions(+), 18 deletions(-)  create mode 100644
> drivers/interconnect/imx/imx8mp.c  create mode 100644
> include/dt-bindings/interconnect/fsl,imx8mp.h
>=20
> --
> 2.25.1