Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <2aa6259b-92b8-e169-7004-1876a7aaa1fd@ti.com>
Date:   Mon, 13 Jun 2022 11:16:34 +0530
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [PATCH v2] gpio: davinci: Add support for system suspend/resume
 PM
Content-Language: en-US
To:     Andy Shevchenko <andy.shevchenko@gmail.com>
CC:     Vignesh Raghavendra <vigneshr@ti.com>,
        Devarsh Thakkar <devarsht@ti.com>, Keerthy <j-keerthy@ti.com>,
        Linus Walleij <linus.walleij@linaro.org>,
        Bartosz Golaszewski <brgl@bgdev.pl>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
References: <20220610054622.21281-1-a-govindraju@ti.com>
 <CAHp75VdPXHF96B5QWNOS3zfF+EOnWeRe+LCGnjvLBcb30kVzWg@mail.gmail.com>
From:   Aswath Govindraju <a-govindraju@ti.com>
In-Reply-To: <CAHp75VdPXHF96B5QWNOS3zfF+EOnWeRe+LCGnjvLBcb30kVzWg@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi Andy,

On 10/06/22 17:50, Andy Shevchenko wrote:
> On Fri, Jun 10, 2022 at 8:08 AM Aswath Govindraju <a-govindraju@ti.com> wrote:
>>
>> From: Devarsh Thakkar <devarsht@ti.com>
>>
>> Add support for system suspend/resume PM hooks, save the
>> register context of all the required gpio registers on suspend
>> and restore the context on resume.
> 
> the resume
> 

Fixed this in respin
> ...
> 
>> +       writel_relaxed(0xFFFFFFFF, &g->intstat);
> 
> GENMASK(31, 0) ?

Used this instead of the direct value in the respin

> 
> ...
> 
>> +static int __maybe_unused davinci_gpio_suspend(struct device *dev)
> 
>> +static int __maybe_unused davinci_gpio_resume(struct device *dev)
> 
>> +static const struct dev_pm_ops davinci_gpio_dev_pm_ops = {
>> +       SET_SYSTEM_SLEEP_PM_OPS(davinci_gpio_suspend, davinci_gpio_resume)
>> +};
> 
>> +               .pm = &davinci_gpio_dev_pm_ops,
> 
> Can you utilize pm_sleep_ptr() and corresponding macros instead of
> __maybe_unused?

Used pm_sleep_ptr instead of the __maybe_unused in the respin.

Thank you for the review. I have posted a respin(v3) for this patch,

https://patchwork.ozlabs.org/project/linux-gpio/patch/20220613054310.21186-1-a-govindraju@ti.com/

-- 
Thanks,
Aswath