Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <4845ad23-476c-97b9-9b3f-d8aaa9027d26@amd.com>
Date:   Mon, 13 Jun 2022 08:51:21 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.9.1
Subject: Re: [PATCH -next] drm/syncobj: add missing error return code in
 drm_syncobj_transfer_to_timeline()
Content-Language: en-US
To:     Yang Yingliang <yangyingliang@huawei.com>,
        linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org
Cc:     daniel.vetter@ffwll.ch
References: <20220613063454.2609364-1-yangyingliang@huawei.com>
From:   =?UTF-8?Q?Christian_K=c3=b6nig?= <christian.koenig@amd.com>
In-Reply-To: <20220613063454.2609364-1-yangyingliang@huawei.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RFIveE94YkI1TlorN0NabFJQMEg3YS9UTEJPWmN2bmFUOWMyYVBlWWRHYlRa?=
 =?utf-8?B?OGlZNVJ4a3Fzck9ualZIMzlvcG45WE9vWHhYMEhrbC96YkljWUthRmRJbjYr?=
 =?utf-8?B?R2FzRUhiekhqOEZPSEhaWDN6VHFUUGRLYXViM0NtTXB6MlVQSFZKSVpDbXZP?=
 =?utf-8?B?RzVFM2R0TlVzbTlaUm96YVZWdnhtMFNicnZEVXlhTk1na0xRb1lmbkRxS3hv?=
 =?utf-8?B?OEhsRjVINnBHYjZjQ0Y2SXNFWEpXV3dXWVQ0NytEWEkxS2NNT3grQWd3YkZX?=
 =?utf-8?B?WHhiem1nRE1sVXp4S3NRTkhSQjBCT2JlOVdOQUZiYXdzRnV4UFFRUHRSR1RJ?=
 =?utf-8?B?SXZUZ1Ftb1NoS2dPUytEWlZRSzdlaXRnc3pWaDcrNWVhbjNMaTREK3dSdjlL?=
 =?utf-8?B?d3dzSUFPYlgwSFZKVVc2UkprdUk1czhpd1dDeTBXemU2MnZpcFJ1blNHaU1u?=
 =?utf-8?B?cmp6QzF1WmZzMVZuVWdSMVdmM2d1SWhuSXlPRlBFMWlVbVJ5MXYvRXVLa0ky?=
 =?utf-8?B?YzZTUG54d0hFTngwdlZKdktMNU1kaVoxRlpjTGo5bmtGS3B1OFFaeHViY29n?=
 =?utf-8?B?M3c1bEUrYVRTSmVsRFlwcHFFWHFEMlgvczkxNmFuMkl1dzlBcytHRHVLckR0?=
 =?utf-8?B?TllQQUVhRU50c2F6REx6S2xIRWlqMzFoN0RJaHBBcGxVamlPdFNSdkdqUHc1?=
 =?utf-8?B?MjdrZFFWeUo4d3pmQzd0RFlFMHBqWi9zcHE3WXlGQ3FiK0ZRV2RUYlhNeEVB?=
 =?utf-8?B?TXpRenh6aVpvT3MyZ2lXcFRBZUtNaUpGbWZtdHRTQ0hPbGdITVp5SGRHcnpH?=
 =?utf-8?B?NEFWQXMvYXlLdHpPQkxqRW5INWdaZzdnM0lwUWZTQWIyQ1d2c3lOWnB5U3o5?=
 =?utf-8?B?R0pSdmZESGsvUUJFUGZ2MnpUS25tQVYzeCtUbkdyZzFiZk5rZ05BZ1dxRHZI?=
 =?utf-8?B?cFdwQm9CQW1YZU01SzBhdkh6d0JxbUpCa0ZqTUJMTlYxbXJFK0FuNnpIdzNH?=
 =?utf-8?B?TzlRVVNoMDVVMC90dUNOUEFpaVBHeVlCU3IzT1JKNjZqRVpyclhFKytGTjNF?=
 =?utf-8?B?V1NzbkxyVTA5SElOSGE0NzV0d3BtZDR0YnJGczRPN2xBUXVZcjYwYVpPWmxJ?=
 =?utf-8?B?SEJVOXB5TGkzaFhxRU5HbnFhN1VQZy9aNWJLMjBtenNRNUdxT3JqelVWQ0ZI?=
 =?utf-8?B?dkxWKzUxMTdDQm8xQjdvbmN1b09qSFZvcy93dzFGQ3BreGRPRWZtTGlZSm5Y?=
 =?utf-8?B?UHdGN3MzeUswSU9lVnpXQmx6c1d0eW1kVjlrU1UvM05IQ2xJdUo5WERYSi95?=
 =?utf-8?B?KzI5alRKZ01FL3VzTVRuei9RZzRUYnlrVUZXZENVZTlBQzlML0Q2T1U1T29K?=
 =?utf-8?B?YzBzZlZNemZJa2ZkcWtJeUw3V3haaytJbVFZSWx0Y1JGc0VjcGFYa3Z1ZTFz?=
 =?utf-8?B?YVZBc3FjWU5aakJmLzhoZk9VejFVQkxnNEM4UzhOVHZ0My90bGN2NlhVT1hD?=
 =?utf-8?B?L3FRYmZ6QzBrYmo3bG1XZzUvL1lNc2FNcXY0YjNIbWh4S3AyS0ZCTlU5MW42?=
 =?utf-8?B?dk9NVUZvdmRuVlZRMjMveW1zcDJSeXMyam5HSFp3T2Fla2o5MUwvMFNISkZP?=
 =?utf-8?B?RUlKOU5OcVJMM1dXU2JRMEU2TStvN2xKaW1ZdldwcEdjeUp1NmkrSGpSU3FK?=
 =?utf-8?B?d2s1aTRHazdqcDlkVVNEZnBhNzJCa1d0WmVnQ2RhSU4rZ0FlekptS2FGOHpE?=
 =?utf-8?B?Y3BZcisrbVZlanJCZWJtdStidlpCZVZaTEZZL2ROb1c5NVc3ejNSR2RnL3ds?=
 =?utf-8?B?dC9xeVJOL1JjeEZFd0VrQUoySjNGM2ZvVjY0S29tOHkxaG9TbUV4K1M3OG5r?=
 =?utf-8?B?NkxVQ0Z4Z1k1ZUVGVHlQOExhbjlXYm9Za2VLQnhJdTViajBJVVFOUFhRbDh6?=
 =?utf-8?B?b0kydjZnOVc4MGJtMXlHeGtXMU1BOEcwNXpjQnovYWZjeVZyR0FMRlU3VmZF?=
 =?utf-8?B?MzZaenkyRGI5NUZReXI4bGpvKzVCeFhYdWRnT2F3bW1RcUlVTGNaMXMraC90?=
 =?utf-8?B?RU14YTZYbm4zS2ZCc0prTGlyMFJFS3JrMnJIWDlSUGdMcHZiblhFSFA4VWJS?=
 =?utf-8?B?bnIrQVRiSmM0K2pnRG1Sc2M0bVg5ZFpubXNRVXZKQ1FzT2FaK3pvR2ZtQlJV?=
 =?utf-8?B?RWpMdVdySEhaREtVZ0RXcC9kWHpNQm04TVczdGxkalEwUk0rVmRRb3dHN1Rl?=
 =?utf-8?B?ekJXcFQ0RWpOb0oyYktObVJlSDI2R05Rd2d1QXNrWjlsamJzckZmUTFvQzRK?=
 =?utf-8?B?dm9IK3pjbWZweUVwNXc3R1ZmTW8xKzdwZ0lXL1UzVldSdHpZSGpwQT09?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: cf0cc945-79c6-4763-d6f8-08da4d0923c1
X-MS-Exchange-CrossTenant-AuthSource: BN8PR12MB3587.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jun 2022 06:51:27.9265
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 4vLu/xK12Df/98/3aK4DLkqT1f6idNIyUfixFz5jTMdNkcJJEr0qcEr5/KSw5jZg
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR12MB3300
X-Spam-Status: No, score=-3.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Am 13.06.22 um 08:34 schrieb Yang Yingliang:
> If dma_fence_unwrap_merge() fails, it should return error code
> in drm_syncobj_transfer_to_timeline()
>
> Fixes: ec8d985ff26f ("drm: use dma_fence_unwrap_merge() in drm_syncobj")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>

Reviewed-by: Christian König <christian.koenig@amd.com>

Going to push that in a minute.

Thanks,
Christian.

> ---
>   drivers/gpu/drm/drm_syncobj.c | 4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/drm_syncobj.c b/drivers/gpu/drm/drm_syncobj.c
> index bbad9e4696e7..0c2be8360525 100644
> --- a/drivers/gpu/drm/drm_syncobj.c
> +++ b/drivers/gpu/drm/drm_syncobj.c
> @@ -874,8 +874,10 @@ static int drm_syncobj_transfer_to_timeline(struct drm_file *file_private,
>   
>   	fence = dma_fence_unwrap_merge(tmp);
>   	dma_fence_put(tmp);
> -	if (!fence)
> +	if (!fence) {
> +		ret = -ENOMEM;
>   		goto err_put_timeline;
> +	}
>   
>   	chain = dma_fence_chain_alloc();
>   	if (!chain) {