Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Chanho Park" <chanho61.park@samsung.com>
To:     "'Alim Akhtar'" <alim.akhtar@samsung.com>,
        <linux-arm-kernel@lists.infradead.org>,
        <linux-kernel@vger.kernel.org>, <linux-scsi@vger.kernel.org>,
        <linux-phy@lists.infradead.org>
Cc:     <devicetree@vger.kernel.org>, <robh+dt@kernel.org>,
        <krzysztof.kozlowski+dt@linaro.org>, <vkoul@kernel.org>,
        <avri.altman@wdc.com>, <bvanassche@acm.org>,
        <martin.petersen@oracle.com>, <pankaj.dubey@samsung.com>,
        "'Bharat Uppal'" <bharat.uppal@samsung.com>
In-Reply-To: <20220610104119.66401-3-alim.akhtar@samsung.com>
Subject: RE: [PATCH v4 2/6] phy: samsung-ufs: move cdr offset to drvdata
Date:   Mon, 13 Jun 2022 16:04:02 +0900
Message-ID: <000101d87ef3$c3849b70$4a8dd250$@samsung.com>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Thread-Index: AQEGezFsbNu8B074Ncmz/1JauiaDCQGC/b7jAa3HWsmu12h1YA==
Content-Language: ko
Content-Type: text/plain; charset="utf-8"
CMS-TYPE: 102P
DLP-Filter: Pass
References: <20220610104119.66401-1-alim.akhtar@samsung.com>
        <CGME20220610104346epcas5p4f59c073d15b3cd8fbc99de03d9cd1c41@epcas5p4.samsung.com>
        <20220610104119.66401-3-alim.akhtar@samsung.com>
Precedence: bulk

> Subject: =5BPATCH v4 2/6=5D phy: samsung-ufs: move cdr offset to drvdata
>=20
> Move CDR lock offset to drv data so that it can be extended for other SoC=
s
> which are having CDR lock at different register offset.
>=20
> Signed-off-by: Bharat Uppal <bharat.uppal=40samsung.com>
> Signed-off-by: Alim Akhtar <alim.akhtar=40samsung.com>
> Reviewed-by: Chanho Park <chanho61.park=40samsung.com>

- Reviewed-by: Chanho Park <chanho61.park=40samsung.com>

> ---
>  drivers/phy/samsung/phy-exynos7-ufs.c      =7C 3 +++
>  drivers/phy/samsung/phy-exynosautov9-ufs.c =7C 2 ++
>  drivers/phy/samsung/phy-samsung-ufs.c      =7C 4 +++-
>  drivers/phy/samsung/phy-samsung-ufs.h      =7C 2 +-
>  4 files changed, 9 insertions(+), 2 deletions(-)
>=20
> diff --git a/drivers/phy/samsung/phy-exynos7-ufs.c
> b/drivers/phy/samsung/phy-exynos7-ufs.c
> index d1e9d0ae5c1d..72854336f59d 100644
> --- a/drivers/phy/samsung/phy-exynos7-ufs.c
> +++ b/drivers/phy/samsung/phy-exynos7-ufs.c
> =40=40 -11,6 +11,8 =40=40
>  =23define EXYNOS7_EMBEDDED_COMBO_PHY_CTRL_MASK	0x1
>  =23define EXYNOS7_EMBEDDED_COMBO_PHY_CTRL_EN	BIT(0)
>=20
> +=23define EXYNOS7_EMBEDDED_COMBO_PHY_CDR_LOCK_STATUS	0x5e
> +
>  /* Calibration for phy initialization */  static const struct
> samsung_ufs_phy_cfg exynos7_pre_init_cfg=5B=5D =3D =7B
>  	PHY_COMN_REG_CFG(0x00f, 0xfa, PWR_MODE_ANY), =40=40 -74,4 +76,5 =40=40
> const struct samsung_ufs_phy_drvdata exynos7_ufs_phy =3D =7B
>  		.en =3D EXYNOS7_EMBEDDED_COMBO_PHY_CTRL_EN,
>  	=7D,
>  	.has_symbol_clk =3D 1,
> +	.cdr_lock_status_offset =3D
> EXYNOS7_EMBEDDED_COMBO_PHY_CDR_LOCK_STATUS,
>  =7D;
> diff --git a/drivers/phy/samsung/phy-exynosautov9-ufs.c
> b/drivers/phy/samsung/phy-exynosautov9-ufs.c
> index fa4d2983eec6..2b256070d657 100644
> --- a/drivers/phy/samsung/phy-exynosautov9-ufs.c
> +++ b/drivers/phy/samsung/phy-exynosautov9-ufs.c
> =40=40 -10,6 +10,7 =40=40
>  =23define EXYNOSAUTOV9_EMBEDDED_COMBO_PHY_CTRL		0x728
>  =23define EXYNOSAUTOV9_EMBEDDED_COMBO_PHY_CTRL_MASK	0x1
>  =23define EXYNOSAUTOV9_EMBEDDED_COMBO_PHY_CTRL_EN		BIT(0)
> +=23define EXYNOSAUTOV9_EMBEDDED_COMBO_PHY_CDR_LOCK_STATUS	0x5e
>=20
>  =23define PHY_TRSV_REG_CFG_AUTOV9(o, v, d) =5C
>  	PHY_TRSV_REG_CFG_OFFSET(o, v, d, 0x50) =40=40 -64,4 +65,5 =40=40 const
> struct samsung_ufs_phy_drvdata exynosautov9_ufs_phy =3D =7B
>  		.en =3D EXYNOSAUTOV9_EMBEDDED_COMBO_PHY_CTRL_EN,
>  	=7D,
>  	.has_symbol_clk =3D 0,
> +	.cdr_lock_status_offset =3D
> +EXYNOSAUTOV9_EMBEDDED_COMBO_PHY_CDR_LOCK_STATUS,
>  =7D;
> diff --git a/drivers/phy/samsung/phy-samsung-ufs.c
> b/drivers/phy/samsung/phy-samsung-ufs.c
> index 206a79c69a6c..8cec7652b459 100644
> --- a/drivers/phy/samsung/phy-samsung-ufs.c
> +++ b/drivers/phy/samsung/phy-samsung-ufs.c
> =40=40 -63,7 +63,8 =40=40 static int samsung_ufs_phy_wait_for_lock_acq(st=
ruct phy
> *phy)
>  	=7D
>=20
>  	err =3D readl_poll_timeout(
> -			ufs_phy->reg_pma + PHY_APB_ADDR(PHY_CDR_LOCK_STATUS),
> +			ufs_phy->reg_pma +
> +			PHY_APB_ADDR(ufs_phy->drvdata->cdr_lock_status_offset),
>  			val, (val & PHY_CDR_LOCK_BIT), sleep_us, timeout_us);
>  	if (err)
>  		dev_err(ufs_phy->dev,
> =40=40 -327,6 +328,7 =40=40 static int samsung_ufs_phy_probe(struct
> platform_device *pdev)
>=20
>  	drvdata =3D match->data;
>  	phy->dev =3D dev;
> +	phy->drvdata =3D drvdata;

This can be reversing changes of below patch.
https://git.kernel.org/pub/scm/linux/kernel/git/phy/linux-phy.git/commit/?h=
=3Dnext&id=3Df86c1d0a58b1f63a176f537e2f6851be49c20ad4

By suggestion of Krzysztof, I removed drvdata assignment to samsung_ufs_phy=
 struct and moved has_symbol_clk from drvdata to samsung_ufs_phy struct.
However, I forgot to remove drvdata from samsung_ufs_phy struct...
Anyway, you want to get back the drvdata, you may need to add a preceding p=
atch with reconsideration of has_symbol_clk to the drvdata again.
Otherwise, you can simply put cdr_lock_status_offset to the samsung_ufs_phy=
 struct and assign the data from drvdata same as has_symbol_clk and isol.

Best Regards,
Chanho Park