Received: by 2002:a6b:fb09:0:0:0:0:0 with SMTP id h9csp228256iog; Mon, 13 Jun 2022 01:01:45 -0700 (PDT) X-Google-Smtp-Source: ABdhPJywWnP5Ejjn4ey8SPl3Rdaj5CcWfqySjeiMo0TKMVJo1qrMBsE2SaWAq/WSDMrnO0+HJxQw X-Received: by 2002:a17:902:e791:b0:166:3985:2f78 with SMTP id cp17-20020a170902e79100b0016639852f78mr56247021plb.158.1655107304972; Mon, 13 Jun 2022 01:01:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1655107304; cv=none; d=google.com; s=arc-20160816; b=Aovqf3O00BkaGY8Q7sr3Q4qB3Itm9TIea0qj6brQpPq1F7DGMqUxQ5xLK4Tn9B7nBj /tTaBQn6d9nPE16u09LbPduzaw905XrBO2dKJr/Ib2weXv7F2ZG+k22abUDQxgL8hey0 5z4zzxz6QOxZw/qJJTQmOQxG94kUu+7RJ4XOD6MT/kwftMTOI/ortEABQbTnsDdIIqsq 165YyfDGUgOvbTEv4PMqQBazd3OdBzvVNCuBieX6JoQwPk/7F0NR1se7r8Hqe7egvLFD 2YTcTqZ540BjBshFfbOrQbfonFgtUtqXRvDipZicCE0ahyOL15MD+IxFqEQ7vUNxRI+9 BUig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=d78LaykMI8lFCetg0Yj9eUeqaN1hhCLUXchpfjOugLc=; b=PmskQd2wrcIfsD5UorBx3SkRC/PIVAk0Q/e1J/P0aqFrjqcGQFuwOGC3zujD+yMieQ PWVYTcciTn3GBEEf7oItIcsP2jvjRJysjUOHlJWmRPiy5SBgm4rNhY2XuoVHqleh094W OjIKda+HZxf2+jSR5DxaN3zv8hMqnQCt6FsGmndTdkMOQiGe8Q6pQrE8dArgYSQc9y8i Y+FQXu1MlR8jGxHW988nqcH/88ffLZlVVXpN7qRCik3f+Di6SWvWT4aQVRVAHtd1Ar5R TgKywQh/CtKe5ImpcGS0qwTeXE3bDoYRh7f6ochpTiTp6YwIAZOiTeHBqbPtae7btSvz wbNg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id h5-20020a63f905000000b00401ae0f4a06si8517616pgi.577.2022.06.13.01.01.32; Mon, 13 Jun 2022 01:01:44 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239043AbiFMHWs (ORCPT + 99 others); Mon, 13 Jun 2022 03:22:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51414 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238916AbiFMHWq (ORCPT ); Mon, 13 Jun 2022 03:22:46 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1D3B01A3AF for ; Mon, 13 Jun 2022 00:22:46 -0700 (PDT) Received: from gallifrey.ext.pengutronix.de ([2001:67c:670:201:5054:ff:fe8d:eefb] helo=bjornoya.blackshift.org) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o0ePE-0004li-1r; Mon, 13 Jun 2022 09:22:36 +0200 Received: from pengutronix.de (unknown [IPv6:2a01:4f8:1c1c:29e9:22:41ff:fe00:1400]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: mkl-all@blackshift.org) by smtp.blackshift.org (Postfix) with ESMTPSA id 199EA938F6; Mon, 13 Jun 2022 07:22:34 +0000 (UTC) Date: Mon, 13 Jun 2022 09:22:33 +0200 From: Marc Kleine-Budde To: Dario Binacchi Cc: linux-kernel@vger.kernel.org, michael@amarulasolutions.com, Amarula patchwork , Oliver Hartkopp , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Wolfgang Grandegger , linux-can@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH v3 09/13] can: slcan: send the close command to the adapter Message-ID: <20220613072233.or64qzh2jko2jhob@pengutronix.de> References: <20220612213927.3004444-1-dario.binacchi@amarulasolutions.com> <20220612213927.3004444-10-dario.binacchi@amarulasolutions.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="kqbqd6v2shjjrfph" Content-Disposition: inline In-Reply-To: <20220612213927.3004444-10-dario.binacchi@amarulasolutions.com> X-SA-Exim-Connect-IP: 2001:67c:670:201:5054:ff:fe8d:eefb X-SA-Exim-Mail-From: mkl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --kqbqd6v2shjjrfph Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 12.06.2022 23:39:23, Dario Binacchi wrote: > In case the bitrate has been set via ip tool, this patch changes the > driver to send the close command ("C\r") to the adapter. >=20 > Signed-off-by: Dario Binacchi Nitpick: Please squash the open and close patches. Marc --=20 Pengutronix e.K. | Marc Kleine-Budde | Embedded Linux | https://www.pengutronix.de | Vertretung West/Dortmund | Phone: +49-231-2826-924 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | --kqbqd6v2shjjrfph Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEBsvAIBsPu6mG7thcrX5LkNig010FAmKm5bcACgkQrX5LkNig 010T9gf9HNXL3Mnnekggg0MEFpnO12bDWBZB64mSw9O5auqtI/2Zmi2olHK22bPe E1oFWdk+Ej4G1gnxyKKv5EUj92QlQMNTPT75WKYQkEZvz2UVvgs51XVULRx/ZIXX f5RcyODulmRmJ6o45vxmdMCcjvKL3IhzQ6z1BkWWmzQhjrg8M3v3wgC703VyukA8 HHObwomdcjhbO/AmwzwFvGTBR705ZgYKoXhRK1yE4+AR1w9PmMeO9ltLedfWioT7 e2NTeHJqRviQwEm01UoZpiSPvpyW13d+bmIRckiRc0K78RL+oAnkHBOkjw76r/sa MfBA8bS5IQCOsv+/nbfHUVoRiyabcw== =d4nN -----END PGP SIGNATURE----- --kqbqd6v2shjjrfph--