Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 13 Jun 2022 10:24:23 +0200
From:   Pali =?utf-8?B?Um9ow6Fy?= <pali@kernel.org>
To:     Armin Wolf <W_Armin@gmx.de>
Cc:     jdelvare@suse.com, linux@roeck-us.net, linux-hwmon@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] hwmon: (dell-smm) Add Dell G5 5590 to DMI table
Message-ID: <20220613082423.bs7r2iz7rjklxcnb@pali>
References: <20220612232208.27901-1-W_Armin@gmx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20220612232208.27901-1-W_Armin@gmx.de>
User-Agent: NeoMutt/20180716
Precedence: bulk

On Monday 13 June 2022 01:22:08 Armin Wolf wrote:
> According to Bug 215983 at bugzilla.kernel.org,
> the Dell G5 5590 supports the SMM interface and
> can thus be loaded with ignore_dmi being set.
> Add the model the DMI table to allow for
> automatic loadig on this model.
> 
> Compile-tested only.
> 
> Signed-off-by: Armin Wolf <W_Armin@gmx.de>

Acked-by: Pali Rohár <pali@kernel.org>

> ---
>  drivers/hwmon/dell-smm-hwmon.c | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/drivers/hwmon/dell-smm-hwmon.c b/drivers/hwmon/dell-smm-hwmon.c
> index 16c10ac84a91..d419885dd771 100644
> --- a/drivers/hwmon/dell-smm-hwmon.c
> +++ b/drivers/hwmon/dell-smm-hwmon.c
> @@ -1131,6 +1131,13 @@ static const struct i8k_config_data i8k_config_data[] __initconst = {
>  };
> 
>  static const struct dmi_system_id i8k_dmi_table[] __initconst = {
> +	{
> +		.ident = "Dell G5 5590",
> +		.matches = {
> +			DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
> +			DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "G5 5590"),
> +		},
> +	},
>  	{
>  		.ident = "Dell Inspiron",
>  		.matches = {
> --
> 2.30.2
>