Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <1a631963-8b76-b14a-892c-9e22a23a55f7@kernel.org>
Date:   Mon, 13 Jun 2022 10:28:27 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.10.0
Subject: Re: [PATCH 1/2] serial: 8250: Use UART_LCR_WLEN8 instead of literal
Content-Language: en-US
To:     =?UTF-8?Q?Ilpo_J=c3=a4rvinen?= <ilpo.jarvinen@linux.intel.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20220613075736.12283-1-ilpo.jarvinen@linux.intel.com>
From:   Jiri Slaby <jirislaby@kernel.org>
In-Reply-To: <20220613075736.12283-1-ilpo.jarvinen@linux.intel.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 13. 06. 22, 9:57, Ilpo Järvinen wrote:
> Use UART_LCR_WLEN8 instead of literal 0x03 in size_fifo().
> 
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>

Reviewed-by: Jiri Slaby <jirislaby@kernel.org>

> ---
>   drivers/tty/serial/8250/8250_port.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/tty/serial/8250/8250_port.c b/drivers/tty/serial/8250/8250_port.c
> index 953b0fadfd4c..8365c7ad3576 100644
> --- a/drivers/tty/serial/8250/8250_port.c
> +++ b/drivers/tty/serial/8250/8250_port.c
> @@ -843,7 +843,7 @@ static int size_fifo(struct uart_8250_port *up)
>   	serial_out(up, UART_LCR, UART_LCR_CONF_MODE_A);
>   	old_dl = serial_dl_read(up);
>   	serial_dl_write(up, 0x0001);
> -	serial_out(up, UART_LCR, 0x03);
> +	serial_out(up, UART_LCR, UART_LCR_WLEN8);
>   	for (count = 0; count < 256; count++)
>   		serial_out(up, UART_TX, count);
>   	mdelay(20);/* FIXME - schedule_timeout */


-- 
js
suse labs