Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 13 Jun 2022 11:44:42 +0200
From:   Jonathan =?utf-8?Q?Neusch=C3=A4fer?= <j.neuschaefer@gmx.net>
To:     Andy Shevchenko <andy.shevchenko@gmail.com>
Cc:     Jonathan =?utf-8?Q?Neusch=C3=A4fer?= <j.neuschaefer@gmx.net>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
        Linus Walleij <linus.walleij@linaro.org>,
        OpenBMC Maillist <openbmc@lists.ozlabs.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] pinctrl: nuvoton: wpcm450: Convert irqchip to
 IRQCHIP_IMMUTABLE
Message-ID: <YqcHClQU0hNYTbgt@latitude>
References: <20220610001609.276220-1-j.neuschaefer@gmx.net>
 <CAHp75VcLn5Ue0efoH_3kKJJqrD5OMbvetPh13FCQFshG9hnN9w@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="nFuUPyBHrWNRC1jf"
Content-Disposition: inline
In-Reply-To: <CAHp75VcLn5Ue0efoH_3kKJJqrD5OMbvetPh13FCQFshG9hnN9w@mail.gmail.com>
Precedence: bulk


--nFuUPyBHrWNRC1jf
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Jun 10, 2022 at 02:07:55PM +0200, Andy Shevchenko wrote:
> On Fri, Jun 10, 2022 at 2:24 AM Jonathan Neusch=C3=A4fer
> <j.neuschaefer@gmx.net> wrote:
> >
> > Commit 6c846d026d490 ("gpio: Don't fiddle with irqchips marked as
> > immutable") added a warning for irqchips that are not marked with
> > IRQCHIP_IMMUTABLE.
> >
> > Convert the pinctrl-wpcm450 driver to an immutable irqchip.
>=20
> ...
>=20
> > +       gpiochip_disable_irq(gc, d->hwirq);
>=20
> > +       gpiochip_enable_irq(gc, d->hwirq);
>=20
> Can you use the helper (*) as stated in the documentation?
>=20
> *) irqd_to_hwirq(d)

Ah, oops. I'll fix it.


Thanks,
Jonathan

--nFuUPyBHrWNRC1jf
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEvHAHGBBjQPVy+qvDCDBEmo7zX9sFAmKnBukACgkQCDBEmo7z
X9vOiw//dDj/H/znJVravzUdFFJgpBmzBRjArecl9dEDhZj+Cgw7HXPNn2G0MgBh
+RqDSwTl+gtMn1n+a8sCt4m+O7inm4I29Za1AzaKTEfoG3Iw01QpCrHoFEyhpcpV
oeNoyTDBaj72D2XJmlgC5oMwFql5jtnOCh2gJ77Uoi7synnH4822GoleNj27zCpf
98Ch1TbqRWygSATj93FUHH0kPSLdWwYO1kaCofq80YwAOG+NkjBqzTEawdsb4CqI
DLc1Zu4sptwe6NrrqIgj1/iD4oTjc0oYUnH4R2QY8pRF1LBS5y/3yLF3EByqww5z
vY7Rv0j5qwM6yjYGb9mD3Ig7nhKk8/fGk/1y0QNsti21Gnz6wY6Wz9smfig/6X51
7fIYUrRBrVG6b9nxGuhXev5/P5s/VxkD87RpBHqXKGdJf9PMMt8EviYwy1Ys4oHT
NucOrKLS3ErEiNG63xTiwEMYflaVvpJz15PJ4hLZHrHeUx3bV5MqHeV0F/c69rKf
NVWyD4zuhCU3u98Pbfvrdlhz83rfEWmNdC60PQ4Qwg1MF5yQR0B8ZjmKjCXvC1yU
Id6Svok5zN+WdrYag+aYyri7F52ny/YEAYLDBJISzHDxy4471HSlIF8pTIdHJeVn
YrPTuNChRzjXRTTq67Kl+1SmuwYUyMM3q9Ej8JtQWYp4mPRgOTI=
=I1MA
-----END PGP SIGNATURE-----

--nFuUPyBHrWNRC1jf--