Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 13 Jun 2022 11:50:58 +0100 (BST)
Message-Id: <20220613.115058.818063822562949798.davem@davemloft.net>
To:     longli@microsoft.com, longli@linuxonhyperv.com
Cc:     kys@microsoft.com, haiyangz@microsoft.com, sthemmin@microsoft.com,
        wei.liu@kernel.org, decui@microsoft.com, kuba@kernel.org,
        pabeni@redhat.com, jgg@ziepe.ca, leon@kernel.org,
        edumazet@google.com, shiraz.saleem@intel.com,
        sharmaajay@microsoft.com, linux-hyperv@vger.kernel.org,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-rdma@vger.kernel.org
Subject: Re: [Patch v3 03/12] net: mana: Handle vport sharing between
 devices
From:   David Miller <davem@davemloft.net>
In-Reply-To: <1655068494-16440-4-git-send-email-longli@linuxonhyperv.com>
References: <1655068494-16440-1-git-send-email-longli@linuxonhyperv.com>
        <1655068494-16440-4-git-send-email-longli@linuxonhyperv.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Precedence: bulk

From: longli@linuxonhyperv.com
Date: Sun, 12 Jun 2022 14:14:45 -0700

> +int mana_cfg_vport(struct mana_port_context *apc, u32 protection_dom_id,
> +		   u32 doorbell_pg_id)
>  {
> +	/* Ethernet driver and IB driver can't take the port at the same time */
> +	refcount_inc(&apc->port_use_count);
> +	if (refcount_read(&apc->port_use_count) > 2) {

This is a racy test, the count could change after the test against
'2'.  It would be nice if there was a primitive to do the increment
and test atomically, but I fail to see one that matches this scenerio
currently.

Thank you.