Received: by 2002:a6b:fb09:0:0:0:0:0 with SMTP id h9csp441810iog; Mon, 13 Jun 2022 06:05:23 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxopTAxeCCyf5jG6ePglVNrkt2J9f48UzXrslFFC2j1Zx4nGzbfmor6NTyu5YWcCWUf7nZ5 X-Received: by 2002:a17:906:649b:b0:712:24cd:6102 with SMTP id e27-20020a170906649b00b0071224cd6102mr14661919ejm.664.1655125414633; Mon, 13 Jun 2022 06:03:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1655125414; cv=none; d=google.com; s=arc-20160816; b=RIB2O1WKmFsnPlrox7ow73R4mPKn4LFHFCQNM6WMaDBaO+XBnhP10efw2VxuEyZQ8V ZefaVkqvYb/Wn5wXkM0FftcSX/elsSo7nmXY+dtCM8FeuMlndoYSndPKOUsWM4xKa1bA Xyn1lKgfmsWcY+B8FmyQ1MhWbdAXAnbNubdK2RW+s2SawLqIi2WCUgrQX4EqcBgjWQxi 3jgVWY3KVnJoIgPcBw6ceWpkT55yp8Vte/sxgysROwyVnL2W5liCXHb5E2J/XhTuFsHq iZYcXz9J34sMk1sGUS6kqXkjQxGjPXiCp4sjbOHD6q8ZZ+anrk6UzOmu0Bu2FvFkpuUZ b0+g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=MjKgqEdp/GmqEDKq0DmLDqEN4oZwKn97RJfvcHAtaoY=; b=Ni+orBZxwR1bnGYJ/tvlyEgtSHL2RLeKPiYr86gKIIGviiVtsFEjFbQM3Z4Im2viTC dS2FnrQJp75xG5ClayP6L1zKRmB/aOxVOE1Z/0NjXG2Enlg1hpKs1dhn1J497BZWTYGe oytWzCluNJNouQVk5Fs4b52TpnElJRl4Lr2n4QD8CJZHmSU185q8db6feBEtG5QcNVyj N43OJkVuXl6b4wxqGWEFd5UMf34tT1BHXpIVmfLjjraTB2Qu0taOqVEZ+PO+SFraSstb tu3FitJZYG5UAD4dFpX+C6Gln76pZUBtRC2pB5A0mR43411vMXPBuaHn0xV0oc4qBhvm LuNQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=N+ovfpKb; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id b9-20020a056402278900b0042dd795f5cesi8991506ede.283.2022.06.13.06.03.06; Mon, 13 Jun 2022 06:03:34 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=N+ovfpKb; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1350021AbiFMLBB (ORCPT + 99 others); Mon, 13 Jun 2022 07:01:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39568 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1350218AbiFMKyp (ORCPT ); Mon, 13 Jun 2022 06:54:45 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 73253CE8; Mon, 13 Jun 2022 03:30:23 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id E9388B80E5E; Mon, 13 Jun 2022 10:30:21 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1CC53C34114; Mon, 13 Jun 2022 10:30:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1655116220; bh=PVI05kPBXQYxAUafjp6oKDIM1E+3bVSwSqCRqIipfZA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=N+ovfpKbC0jxTmfSjmVRSiZ76d+j79eB4ePCiQDce/xNKwBpgQd9/tMCqadbr2p2N xjWF8lEC9NoF0Qg0i2bS7GQ+Wgor1FbQKsqoDZ7qRLZq3WpQFJBAH7R6mN0+C54WLo TQmzKdTBGtXEXJv47KO7BPbaMplCINcop6eUJBRc= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= , Sasha Levin Subject: [PATCH 4.14 153/218] serial: txx9: Dont allow CS5-6 Date: Mon, 13 Jun 2022 12:10:11 +0200 Message-Id: <20220613094925.233523219@linuxfoundation.org> X-Mailer: git-send-email 2.36.1 In-Reply-To: <20220613094908.257446132@linuxfoundation.org> References: <20220613094908.257446132@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-8.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Ilpo Järvinen [ Upstream commit 79ac88655dc0551e3571ad16bdabdbe65d61553e ] Only CS7 and CS8 are supported but CSIZE is not sanitized with CS5 or CS6 to CS8. Set CSIZE correctly so that userspace knows the effective value. Incorrect CSIZE also results in miscalculation of the frame bits in tty_get_char_size() or in its predecessor where the roughly the same code is directly within uart_update_timeout(). Fixes: 1da177e4c3f4 (Linux-2.6.12-rc2) Signed-off-by: Ilpo Järvinen Link: https://lore.kernel.org/r/20220519081808.3776-5-ilpo.jarvinen@linux.intel.com Signed-off-by: Greg Kroah-Hartman Signed-off-by: Sasha Levin --- drivers/tty/serial/serial_txx9.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/tty/serial/serial_txx9.c b/drivers/tty/serial/serial_txx9.c index ba77e72057a9..5d41884f5012 100644 --- a/drivers/tty/serial/serial_txx9.c +++ b/drivers/tty/serial/serial_txx9.c @@ -652,6 +652,8 @@ serial_txx9_set_termios(struct uart_port *port, struct ktermios *termios, case CS6: /* not supported */ case CS8: cval |= TXX9_SILCR_UMODE_8BIT; + termios->c_cflag &= ~CSIZE; + termios->c_cflag |= CS8; break; } -- 2.35.1