Received: by 2002:a6b:fb09:0:0:0:0:0 with SMTP id h9csp444905iog; Mon, 13 Jun 2022 06:07:50 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz9eY/FwibhasKbNIjvpSFMEB4X+rove5Y3ZrCbno1QQ1vNKZEl2NhvpVmv5yIrgOymffuN X-Received: by 2002:a05:6a00:a8f:b0:51b:5ca1:47f1 with SMTP id b15-20020a056a000a8f00b0051b5ca147f1mr59943135pfl.50.1655125670466; Mon, 13 Jun 2022 06:07:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1655125670; cv=none; d=google.com; s=arc-20160816; b=CGlqfyzwT6hN4sayyvhVE7Q3ol3ESESDbtc7x+pehCAXdo1Ni/qIJtoLxW5fVsnVfo KW8+1384gAhpe1em6PmyTfOesmdoLCQX8ktvxYtQc2ALcRR+9dj2+d7W1pR6FcqxEd0n WPzevhQnDwHLMRbEdhyRmpKM3v+GDrid555F6EwqRlCgaShnwcsYL1Ui1TCjGRXEB6ml 5ETFaLXPmwxxFI/CXetBavHdfO0WzV0HY+TALp9pX9RWgz+IKAlBa/BTRUcNY8Q2KC2U YCDmFAzy7D7gnYmGXmHoYkE5AvpACvklogW12X/cqYxNPKZtyHhai4P6SOSKkJSdqmA+ VfRA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=WFwoPtPQR9lYsma+RHf93EIgOXVYxg7c9gjXu6/D9kg=; b=rqZlIhAp68HVk1GMrHTczCVjP8GpmBqHMOr3ZIdpCASH4z7xnQwgCuOL1i20LdRFy4 JTt7uQNG8yObpGOh6MRk+qpL4uWqZ6Jounc+Ynel8Wt+8u2iT5Yrq20kNGSV6u8VpOMy HPzITgZu2969AhF9yRePTjBppl45EUbCrvLt/FqGtpMdjIfttO/0P0/NSD/3z1zuOVNY GmrYnCgjmotwSpALmkgI+Zq74EYK9YhnzsZotB3pNgfpqWEmoGyPGjxFUqulmyOpJaKA mcbePPRyKNeXompIgQIuh0Ipb37PcDrZvH0B+jJ7GhZbTecqT7YaNgoxsRkF66HquXTx A2dA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=1M2zBScv; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id q80-20020a632a53000000b004051848da30si10000171pgq.528.2022.06.13.06.07.34; Mon, 13 Jun 2022 06:07:50 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=1M2zBScv; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241189AbiFMK6I (ORCPT + 99 others); Mon, 13 Jun 2022 06:58:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44320 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1350061AbiFMKyk (ORCPT ); Mon, 13 Jun 2022 06:54:40 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 58BAC2496A; Mon, 13 Jun 2022 03:28:53 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id DA63860B8B; Mon, 13 Jun 2022 10:28:52 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E4901C34114; Mon, 13 Jun 2022 10:28:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1655116132; bh=/QdSKNOpC8Zo65YAdy/tPhlzNZ0sdR1gpKn2cxWiK8Q=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=1M2zBScvM/nNpSLtCO3TJkS+lNK6IUShCHtLc0ZJN6oPeeaPHTZOX9vetXIE8Bsso 84EZQ8RyjdKMIMU1slRU7Xz3M9Oa/J1E0zQtKYeJK46x6+CGUsJ8rp1BN9AV7VmR/K Yaju6EF0MgqHZ6ff0FGUrdmvvS0CpyF34MT+0baY= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Mark Brown Subject: [PATCH 4.14 129/218] ASoC: rt5514: Fix event generation for "DSP Voice Wake Up" control Date: Mon, 13 Jun 2022 12:09:47 +0200 Message-Id: <20220613094924.490998698@linuxfoundation.org> X-Mailer: git-send-email 2.36.1 In-Reply-To: <20220613094908.257446132@linuxfoundation.org> References: <20220613094908.257446132@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-8.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Mark Brown commit 4213ff556740bb45e2d9ff0f50d056c4e7dd0921 upstream. The driver has a custom put function for "DSP Voice Wake Up" which does not generate event notifications on change, instead returning 0. Since we already exit early in the case that there is no change this can be fixed by unconditionally returning 1 at the end of the function. Signed-off-by: Mark Brown Cc: stable@vger.kernel.org Link: https://lore.kernel.org/r/20220428162444.3883147-1-broonie@kernel.org Signed-off-by: Mark Brown Signed-off-by: Greg Kroah-Hartman --- sound/soc/codecs/rt5514.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/sound/soc/codecs/rt5514.c +++ b/sound/soc/codecs/rt5514.c @@ -352,7 +352,7 @@ static int rt5514_dsp_voice_wake_up_put( } } - return 0; + return 1; } static const struct snd_kcontrol_new rt5514_snd_controls[] = {