Received: by 2002:a6b:fb09:0:0:0:0:0 with SMTP id h9csp576537iog; Mon, 13 Jun 2022 08:26:57 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxgGAnRBTTDWs9hHncNMdRMmmEbfk+j50zqsimpOmiYJfNi3kth3KvgzlaWUKKoEy8aV3Ht X-Received: by 2002:aa7:de8c:0:b0:433:5eea:27f7 with SMTP id j12-20020aa7de8c000000b004335eea27f7mr299468edv.328.1655134017087; Mon, 13 Jun 2022 08:26:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1655134017; cv=none; d=google.com; s=arc-20160816; b=FH1E9P1UvtcHLnaNUL35EZe2Xh6bU7wg1VPKakWQvU0W9nJKm0jCuZvtBerlDmoClN ZkQ+XavBIpqmgtKdGxr+pzPxmy4fx6Dsev4YoSVOhYH3T+uTd8Ifp/aTE1t2CRxjls89 yIciAIDgNE3WIOlYJk2iCTrDQNgDSiuSTvjRcHHSCjFpRGLDwJ7RloAtea4djyQxS6/B /t/KUAWxHR4tuWvqG13XXB8TIpFPk3EDiJJtV8umL4BvY+8cC6qM+wwZ+zdQR5DHOeVh CqDZ78MODOOdah0Tf5gU0F2cwKEH3qEYi3MhRsKF5NaNQ1HpstctKmFX3WvkKcMj4Pje dgtg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=Q6P6zaufLfBA81rePl6XJEGJV9wrwFS+qA/tO/tQ9zM=; b=pqNWOuhkLsYa+qHKjq1r5xmvQIY3oqoHvt40RPZHY+ymPmTrZkVAN68Ugm6RIC6b5y wNr96mPGmrQam+mfhFWIY4nZyr2IVPMRTJGi6uR2yjP7DMqyc08UnpId+A1kVKniVcsT fHACyboLeF1Or0A1+CDqJPnXrVEjjx6H59DyNgcXmNAr4My/96X+GE8B9vwDTwnZJy72 6TunwdU7+p6XOZKKLsNp7KQONZquTclCQadPjBcn+NvGUuxNUeZMS8MjtbQWKEsESmci tmDEvN8Ow7IXPjJA+Fxp3ex7O0PSSWGPGGRq3mtRwr1z73Sx+FuhIDvbuZ5xxl+g7K1Z Xnfw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=l5pjI1Td; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id j30-20020a170906535e00b00715785bb696si6056402ejo.447.2022.06.13.08.26.30; Mon, 13 Jun 2022 08:26:57 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=l5pjI1Td; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243993AbiFMKZx (ORCPT + 99 others); Mon, 13 Jun 2022 06:25:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45624 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244906AbiFMKYO (ORCPT ); Mon, 13 Jun 2022 06:24:14 -0400 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 66E1CBF7F; Mon, 13 Jun 2022 03:18:29 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id C4910CE1167; Mon, 13 Jun 2022 10:18:27 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A9842C34114; Mon, 13 Jun 2022 10:18:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1655115506; bh=oqPA/ACm87bq+HnUmgZY5Y57yeqqGG49MOp2WmCKenE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=l5pjI1TdxBq50W0ccPqLB/ZDHZVxVt73YcVOrOY5mt1m05CTYtNioyaShuqISj6Sx CCa6lb7yM9B8iMN63/hAU3k0d3WBKbJxryc+tlYm37t0/ba73NeXzV1ayC3Zl4ABb3 NgPVCUlQo6W7a20hKNzJEhJ0HdrNefHIw6am28Rw= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Mark Brown Subject: [PATCH 4.9 100/167] ASoC: rt5514: Fix event generation for "DSP Voice Wake Up" control Date: Mon, 13 Jun 2022 12:09:34 +0200 Message-Id: <20220613094904.269247136@linuxfoundation.org> X-Mailer: git-send-email 2.36.1 In-Reply-To: <20220613094840.720778945@linuxfoundation.org> References: <20220613094840.720778945@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-8.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Mark Brown commit 4213ff556740bb45e2d9ff0f50d056c4e7dd0921 upstream. The driver has a custom put function for "DSP Voice Wake Up" which does not generate event notifications on change, instead returning 0. Since we already exit early in the case that there is no change this can be fixed by unconditionally returning 1 at the end of the function. Signed-off-by: Mark Brown Cc: stable@vger.kernel.org Link: https://lore.kernel.org/r/20220428162444.3883147-1-broonie@kernel.org Signed-off-by: Mark Brown Signed-off-by: Greg Kroah-Hartman --- sound/soc/codecs/rt5514.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/sound/soc/codecs/rt5514.c +++ b/sound/soc/codecs/rt5514.c @@ -345,7 +345,7 @@ static int rt5514_dsp_voice_wake_up_put( } } - return 0; + return 1; } static const struct snd_kcontrol_new rt5514_snd_controls[] = {