Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <23bb9f5d-85fe-d7a7-d178-1185981f1b89@quicinc.com>
Date:   Mon, 13 Jun 2022 16:25:51 +0530
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
Subject: Re: [PATCH 1/2] ASoC: dt-bindings: lpass-cpu: Update external mclck0
 name
Content-Language: en-US
To:     Mark Brown <broonie@kernel.org>, Rob Herring <robh@kernel.org>
CC:     <agross@kernel.org>, <bjorn.andersson@linaro.org>,
        <lgirdwood@gmail.com>, <quic_plai@quicinc.com>,
        <bgoswami@quicinc.com>, <perex@perex.cz>, <tiwai@suse.com>,
        <srinivas.kandagatla@linaro.org>, <quic_rohkumar@quicinc.com>,
        <linux-arm-msm@vger.kernel.org>, <alsa-devel@alsa-project.org>,
        <linux-kernel@vger.kernel.org>, <swboyd@chromium.org>,
        <judyhsiao@chromium.org>, <devicetree@vger.kernel.org>
References: <1654169206-12255-1-git-send-email-quic_srivasam@quicinc.com>
 <1654169206-12255-2-git-send-email-quic_srivasam@quicinc.com>
 <20220602143245.GA2256965-robh@kernel.org> <YpjL3X73LyefYjI7@sirena.org.uk>
From:   Srinivasa Rao Mandadapu <quic_srivasam@quicinc.com>
Organization: Qualcomm
In-Reply-To: <YpjL3X73LyefYjI7@sirena.org.uk>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 6/2/2022 8:10 PM, Mark Brown wrote:
Thanks for your time Mark Brown and Rob Herring!!!
> On Thu, Jun 02, 2022 at 09:32:45AM -0500, Rob Herring wrote:
>> On Thu, Jun 02, 2022 at 04:56:45PM +0530, Srinivasa Rao Mandadapu wrote:
>>> Update "audio_cc_ext_mclk0" name to "core_cc_ext_mclk0",
>>> as MI2S mclk is being used is from lpass core cc.
>> This is safe to change breaking the ABI because ...
> The driver was only just merged so didn't make it into a full
> release.
yes. DTS changes are still in review state.
>
>> Names are supposed to be local to the module, not based on their source.
> Indeed.

Okay. Will take care next time. As external MCLK is supported from both 
modules, audio cc and core cc,

for now it's mandatory to change the name to avoid confusion.